Skip to contentSkip to conversation

package/libsolv: Adding ability to add build option flags

PATCH In review Justin Basinger 2 participants 2 messages Jul 9, 2025 – Jan 4

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libsolv: Adding ability to add build option flags

---
 package/libsolv/Config.in  | 6 ++++++
 package/libsolv/libsolv.mk | 2 ++
 2 files changed, 8 insertions(+)
package/libsolv/Config.in +6 -0
index 1415d2bc2b..b680c9319c 100644
@@ -7,3 +7,9 @@ config BR2_PACKAGE_LIBSOLV
 	  algorithm.
 
 	  https://github.com/openSUSE/libsolv
+
+config BR2_PACKAGE_LIBSOLV_CONF_OPTS
+	string "Libsolv option flags"
+	depends on BR2_PACKAGE_LIBSOLV
+	help
+	  Allow the user to add optional build flags in Libsolv
package/libsolv/libsolv.mk +2 -0
index 2317d3e663..94dc482205 100644
@@ -24,4 +24,6 @@ else
 LIBSOLV_CONF_OPTS += -DDISABLE_SHARED=ON
 endif
 
+LIBSOLV_CONF_OPTS += $(patsubst "%",%,$(BR2_PACKAGE_LIBSOLV_CONF_OPTS))
+
 $(eval $(cmake-package))
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Justin,

Quoted 1 line · On Wed, 9 Jul 2025 18:59:56 +0000 Justin Basinger…

Thanks for your patch, and sorry for the very long delay with which we are getting back to you.

package/libsolv/Config.in config BR2_PACKAGE_LIBSOLV · line 13

Quoted 3 lines
package/libsolv/Config.in +3 -0
+config BR2_PACKAGE_LIBSOLV_CONF_OPTS
+	string "Libsolv option flags"
+	depends on BR2_PACKAGE_LIBSOLV

Could you clarify which option flags were needed in your case? Indeed in general, we don't like to add this kind of free-form options, except for very specific packages that have lots and lots of options (for example a similar option is under discussion for EDK2, but that's very different from a usual user-space library).

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot