Skip to contentSkip to conversation

irqchip: irq-msi-lib: fix build with PCI disabled

PATCH Applied Arnd Bergmann 3 participants 3 messages Jul 10, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irqchip: irq-msi-lib: fix build with PCI disabled

From: Arnd Bergmann <[email protected]>

The armada-370-xp irqchip fails in some randconfig builds because of a missing declaration:

In file included from drivers/irqchip/irq-armada-370-xp.c:23:
include/linux/irqchip/irq-msi-lib.h:25:39: error: 'struct msi_domain_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

Add a forward declaration for the msi_domain_info structure.

Fixes e51b27438a10 ("irqchip: Make irq-msi-lib.h globally available")
---
 include/linux/irqchip/irq-msi-lib.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/irqchip/irq-msi-lib.h +1 -0
index dd8d1d138544..224ac28e88d7 100644
@@ -17,6 +17,7 @@
 
 #define MATCH_PLATFORM_MSI	BIT(DOMAIN_BUS_PLATFORM_MSI)
 
+struct msi_domain_info;
 int msi_lib_irq_domain_select(struct irq_domain *d, struct irq_fwspec *fwspec,
 			      enum irq_domain_bus_token bus_token);
 
Signature · 1 line
2.39.5
Acked-by on v1 1/1
#1 lore raw
Quoted 22 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The armada-370-xp irqchip fails in some randconfig builds because of a missing declaration:

In file included from drivers/irqchip/irq-armada-370-xp.c:23:
include/linux/irqchip/irq-msi-lib.h:25:39: error: 'struct msi_domain_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

Add a forward declaration for the msi_domain_info structure.

Fixes e51b27438a10 ("irqchip: Make irq-msi-lib.h globally available")
---
 include/linux/irqchip/irq-msi-lib.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/irqchip/irq-msi-lib.h +0 -0
index dd8d1d138544..224ac28e88d7 100644

include/linux/irqchip/irq-msi-lib.h line 23

Quoted 7 lines
include/linux/irqchip/irq-msi-lib.h +1 -0
@@ -17,6 +17,7 @@
 
 #define MATCH_PLATFORM_MSI	BIT(DOMAIN_BUS_PLATFORM_MSI)
 
+struct msi_domain_info;
 int msi_lib_irq_domain_select(struct irq_domain *d, struct irq_fwspec *fwspec,
 			      enum irq_domain_bus_token bus_token);
 
	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
merge bot Applied
#2 lore raw

[tip: irq/urgent] irqchip/irq-msi-lib: Fix build with PCI disabled

In reply to Arnd Bergmann
The following commit has been merged into the irq/urgent branch of tip:

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     a8b289f0f2dcbadd8c207ad8f33cf7ba2b4eb088
Gitweb:        https://git.kernel.org/tip/a8b289f0f2dcbadd8c207ad8f33cf7ba2b4eb088
Author:        Arnd Bergmann <[email protected]>
AuthorDate:    Thu, 10 Jul 2025 10:00:12 +02:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Thu, 10 Jul 2025 23:46:05 +02:00

irqchip/irq-msi-lib: Fix build with PCI disabled

The armada-370-xp irqchip fails in some randconfig builds because of a missing declaration:

In file included from drivers/irqchip/irq-armada-370-xp.c:23:
include/linux/irqchip/irq-msi-lib.h:25:39: error: 'struct msi_domain_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

Add a forward declaration for the msi_domain_info structure.

[ tglx: Fixed up the subsystem prefix. Is it really that hard to get right? ]

Fixes e51b27438a10 ("irqchip: Make irq-msi-lib.h globally available")
---
 include/linux/irqchip/irq-msi-lib.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/irqchip/irq-msi-lib.h +1 -0
index dd8d1d1..224ac28 100644
@@ -17,6 +17,7 @@
 
 #define MATCH_PLATFORM_MSI	BIT(DOMAIN_BUS_PLATFORM_MSI)
 
+struct msi_domain_info;
 int msi_lib_irq_domain_select(struct irq_domain *d, struct irq_fwspec *fwspec,
 			      enum irq_domain_bus_token bus_token);