accel/tcg: Do not dump NaN statistics
PATCH 1/1 accel/tcg: Do not dump NaN statistics
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
--- accel/tcg/monitor.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-)
accel/tcg/monitor.c +15 -7
@@ -19,7 +19,7 @@#include "tcg/tcg.h" #include "internal-common.h" #include "tb-context.h" - +#include <math.h> static void dump_drift_info (GString *buf) {
@@ -57,6 +57,7 @@ static void print_qht_statistics(struct qht_stats hst, GString *buf)uint32_t hgram_opts;size_t hgram_bins;char *hgram; +double avg;if (!hst.head_buckets) {return ;
@@ -73,9 +74,13 @@ static void print_qht_statistics(struct qht_stats hst, GString *buf) hgram_opts |=QDIST_PR_NODECIMAL ; } hgram =qdist_pr (&hst.occupancy,10 , hgram_opts); -g_string_append_printf (buf,"TB hash occupancy %0.2f%% avg chain occ. " -"Histogram: %s\n" , -qdist_avg (&hst.occupancy) *100 , hgram); + avg =qdist_avg (&hst.occupancy); +if (!isnan (avg)) { +g_string_append_printf (buf,"TB hash occupancy " +"%0.2f%% avg chain occ. " +"Histogram: %s\n" , + avg *100 , hgram); + }g_free (hgram); hgram_opts =QDIST_PR_BORDER |QDIST_PR_LABELS ;
@@ -87,9 +92,12 @@ static void print_qht_statistics(struct qht_stats hst, GString *buf) hgram_opts |=QDIST_PR_NODECIMAL |QDIST_PR_NOBINRANGE ; } hgram =qdist_pr (&hst.chain, hgram_bins, hgram_opts); -g_string_append_printf (buf,"TB hash avg chain %0.3f buckets. " -"Histogram: %s\n" , -qdist_avg (&hst.chain), hgram); + avg =qdist_avg (&hst.chain); +if (!isnan (avg)) { +g_string_append_printf (buf,"TB hash avg chain %0.3f buckets. " +"Histogram: %s\n" , + avg, hgram); + }g_free (hgram); }
Signature · 1 line
2.49.0
Quoted 61 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- accel/tcg/monitor.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-)accel/tcg/monitor.c +15
-8@@ -19,7 +19,7 @@#include "tcg/tcg.h" #include "internal-common.h" #include "tb-context.h" - +#include <math.h> static void dump_drift_info (GString *buf) {@@ -57,6 +57,7 @@ static void print_qht_statistics(struct qht_stats hst, GString *buf)uint32_t hgram_opts;size_t hgram_bins;char *hgram; +double avg;if (!hst.head_buckets) {return ;@@ -73,9 +74,13 @@ static void print_qht_statistics(struct qht_stats hst, GString *buf) hgram_opts |=QDIST_PR_NODECIMAL ; } hgram =qdist_pr (&hst.occupancy,10 , hgram_opts); -g_string_append_printf (buf,"TB hash occupancy %0.2f%% avg chain occ. " -"Histogram: %s\n" , -qdist_avg (&hst.occupancy) *100 , hgram); + avg =qdist_avg (&hst.occupancy); +if (!isnan (avg)) { +g_string_append_printf (buf,"TB hash occupancy " +"%0.2f%% avg chain occ. " +"Histogram: %s\n" , + avg *100 , hgram); + }g_free (hgram); hgram_opts =QDIST_PR_BORDER |QDIST_PR_LABELS ;@@ -87,9 +92,12 @@ static void print_qht_statistics(struct qht_stats hst, GString *buf) hgram_opts |=QDIST_PR_NODECIMAL |QDIST_PR_NOBINRANGE ; } hgram =qdist_pr (&hst.chain, hgram_bins, hgram_opts); -g_string_append_printf (buf,"TB hash avg chain %0.3f buckets. " -"Histogram: %s\n" , -qdist_avg (&hst.chain), hgram); + avg =qdist_avg (&hst.chain); +if (!isnan (avg)) { +g_string_append_printf (buf,"TB hash avg chain %0.3f buckets. " +"Histogram: %s\n" , + avg, hgram); + }g_free (hgram); } --
Quoted 2 lines
2.49.0
Reviewed-by Manos Pitsidianakis <[email protected]>
Philippe Mathieu-Daudé
AppliedQuoted 4 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- accel/tcg/monitor.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-)
Queued, thanks.