Skip to contentSkip to conversation

net: lwip: remove eth_init from net_init as it is called later

PATCH In review Tim Harvey 2 participants 2 messages Jul 10, 2025 Networking

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 net: lwip: remove eth_init from net_init as it is called later

The call to eth_init within net_init causes the network interface to start, stop, start again which can cause issues with certain network device drivers. Remove it to make it behave like the legacy network path.

Fixes 5666865decb8 ("net: lwip: fix initialization sequence before a command")
---
 net/lwip/net-lwip.c | 1 -
 1 file changed, 1 deletion(-)
net/lwip/net-lwip.c +0 -1
index 3918d57d7e58..d53faa39ba11 100644
@@ -285,7 +285,6 @@ int net_init(void)
 
 	if (!init_done) {
 		eth_init_rings();
-		eth_init();
 		lwip_init();
 		init_done = true;
 	}
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Tim Harvey

The call to eth_init within net_init causes the network interface to start, stop, start again which can cause issues with certain network device drivers. Remove it to make it behave like the legacy network path.

Fixes 5666865decb8 ("net: lwip: fix initialization sequence before a command")
---
 net/lwip/net-lwip.c | 1 -
 1 file changed, 1 deletion(-)
net/lwip/net-lwip.c +0 -0
index 3918d57d7e58..d53faa39ba11 100644

net/lwip/net-lwip.c int net_init(void) · line 290

Quoted 7 lines
net/lwip/net-lwip.c +0 -1
@@ -285,7 +285,6 @@ int net_init(void)
 
 	if (!init_done) {
 		eth_init_rings();
-		eth_init();
 		lwip_init();
 		init_done = true;
 	}

Thanks,

Signature · 1 line
Jerome