f2fs: fix to avoid out-of-boundary access in devs.path
Chao Yu
maintainerPATCH 1/1 f2fs: fix to avoid out-of-boundary access in devs.path
- touch /mnt/f2fs/012345678901234567890123456789012345678901234567890123
- truncate -s $((1024*1024*1024)) \
/mnt/f2fs/012345678901234567890123456789012345678901234567890123
- touch /mnt/f2fs/file
- truncate -s $((1024*1024*1024)) /mnt/f2fs/file
- mkfs.f2fs /mnt/f2fs/012345678901234567890123456789012345678901234567890123 \
-c /mnt/f2fs/file
- mount /mnt/f2fs/012345678901234567890123456789012345678901234567890123 \
/mnt/f2fs/loop
[16937.192225] F2FS-fs (loop0): Mount Device [ 0]: /mnt/f2fs/012345678901234567890123456789012345678901234567890123\xff\x01, 511, 0 - 3ffff [16937.192268] F2FS-fs (loop0): Failed to find devices
If device path length equals to MAX_PATH_LEN, sbi->devs.path[] may not end up w/ null character due to path array is fully filled, So accidently, fields locate after path[] may be treated as part of device path, result in parsing wrong device path.
struct f2fs_dev_info {
...
char path[MAX_PATH_LEN];
...
};
Let's add one byte space for sbi->devs.path[] to store null character of device path string.
--- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/f2fs.h +1 -1
@@ -1289,7 +1289,7 @@ struct f2fs_bio_info {struct f2fs_dev_info {struct file *bdev_file;struct block_device *bdev; -char path[MAX_PATH_LEN ]; +char path[MAX_PATH_LEN +1 ];unsigned int total_segments;block_t start_blk;block_t end_blk;
Signature · 1 line
2.49.0
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 11 lines · On Fri, 11 Jul 2025 15:14:50 +0800 you wrote:
- touch
/mnt/f2fs/012345678901234567890123456789012345678901234567890123
- truncate -s $((1024*1024*1024)) \
/mnt/f2fs/012345678901234567890123456789012345678901234567890123
- touch/mnt/f2fs/file
- truncate -s $((1024*1024*1024))/mnt/f2fs/file
- mkfs.f2fs/mnt/f2fs/012345678901234567890123456789012345678901234567890123\
-c/mnt/f2fs/file
- mount/mnt/f2fs/012345678901234567890123456789012345678901234567890123\
/mnt/f2fs/loop[...]
Here is the summary with links:
- [f2fs-dev] f2fs: fix to avoid out-of-boundary access in devs.path
https://git.kernel.org/jaegeuk/f2fs/c/65eeef059d04
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html