Skip to contentSkip to conversation

usb: typec: ucsi: Add poll_cci operation to cros_ec_ucsi

PATCH In review Jameson Thies 2 participants 2 messages Jul 11, 2025

Subsystems (4)
lore
Share & tools
lore

Jameson Thies

author maintainer
#0 lore raw

PATCH 1/1 usb: typec: ucsi: Add poll_cci operation to cros_ec_ucsi

cros_ec_ucsi fails to allocate a UCSI instance in it's probe function because it does not define all operations checked by ucsi_create. Update cros_ec_ucsi operations to use the same function for read_cci and poll_cci.

---
 drivers/usb/typec/ucsi/cros_ec_ucsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/ucsi/cros_ec_ucsi.c +1 -0
index 4ec1c6d22310..eed2a7d0ebc6 100644
@@ -137,6 +137,7 @@ static int cros_ucsi_sync_control(struct ucsi *ucsi, u64 cmd, u32 *cci,
 static const struct ucsi_operations cros_ucsi_ops = {
 	.read_version = cros_ucsi_read_version,
 	.read_cci = cros_ucsi_read_cci,
+	.poll_cci = cros_ucsi_read_cci,
 	.read_message_in = cros_ucsi_read_message_in,
 	.async_control = cros_ucsi_async_control,
 	.sync_control = cros_ucsi_sync_control,

base-commit: b4b4dbfa96dea8e299a47ef877eb0cfe210a7291

Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jameson Thies

cros_ec_ucsi fails to allocate a UCSI instance in it's probe function because it does not define all operations checked by ucsi_create. Update cros_ec_ucsi operations to use the same function for read_cci and poll_cci.

Quoted 21 lines
---
 drivers/usb/typec/ucsi/cros_ec_ucsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/ucsi/cros_ec_ucsi.c +1 -0
index 4ec1c6d22310..eed2a7d0ebc6 100644
@@ -137,6 +137,7 @@ static int cros_ucsi_sync_control(struct ucsi *ucsi, u64 cmd, u32 *cci,
 static const struct ucsi_operations cros_ucsi_ops = {
 	.read_version = cros_ucsi_read_version,
 	.read_cci = cros_ucsi_read_cci,
+	.poll_cci = cros_ucsi_read_cci,
 	.read_message_in = cros_ucsi_read_message_in,
 	.async_control = cros_ucsi_async_control,
 	.sync_control = cros_ucsi_sync_control,

base-commit: b4b4dbfa96dea8e299a47ef877eb0cfe210a7291

Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog