Skip to contentSkip to conversation

hv_netvsc: Set VF priv_flags to IFF_NO_ADDRCONF before open to prevent IPv6 addrconf

PATCH Superseded Li Tian 2 participants 2 messages Jul 12, 2025 – Jul 15, 2025

Subsystems (4)
lore
Share & tools
lore

Li Tian

author
#0 lore raw

PATCH v3 1/1 hv_netvsc: Set VF priv_flags to IFF_NO_ADDRCONF before open to prevent IPv6 addrconf

Set an additional flag IFF_NO_ADDRCONF to prevent ipv6 addrconf.

Commit 8a321cf7becc
("net: add IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf")

This new flag change was not made to hv_netvsc resulting in the VF being assinged an IPv6.

Fixes 8a321cf7becc ("net: add IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf")

---
v3:
- only fix commit message.
v2: https://lore.kernel.org/netdev/[email protected]/
- instead of replacing flag, add it.
v1: https://lore.kernel.org/netdev/[email protected]/

---
 drivers/net/hyperv/netvsc_drv.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/hyperv/netvsc_drv.c +4 -1
index c41a025c66f0..8be9bce66a4e 100644
@@ -2317,8 +2317,11 @@ static int netvsc_prepare_bonding(struct net_device *vf_netdev)
 	if (!ndev)
 		return NOTIFY_DONE;
 
-	/* set slave flag before open to prevent IPv6 addrconf */
+	/* Set slave flag and no addrconf flag before open
+	 * to prevent IPv6 addrconf.
+	 */
 	vf_netdev->flags |= IFF_SLAVE;
+	vf_netdev->priv_flags |= IFF_NO_ADDRCONF;
 	return NOTIFY_DONE;
 }
 
Signature · 1 line
2.50.0
maintainer
#1 lore raw
Quoted 4 lines · On Sat, 12 Jul 2025 18:07:08 +0800 Li Tian wrote:

Set an additional flag IFF_NO_ADDRCONF to prevent ipv6 addrconf.

Commit 8a321cf7becc
("net: add IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf")

This line looks quite odd, it's in the middle of the commit message but it's not a real sentence. If there's a single Fixes tag I usually refer to it as "commit under Fixes", e.g. "Commit under Fixes changed XYZ but it missed .." Please make this commit message read like a coherent explanation rather than set of notes..

Quoted 4 lines

This new flag change was not made to hv_netvsc resulting in the VF being assinged an IPv6.

Fixes 8a321cf7becc ("net: add IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf")
Signature · 1 line
pw-bot: cr