Skip to contentSkip to conversation

of xvip_enum_frame_size and xvip_get_format_by_code

DISCUSSION Dr. David Alan Gilbert 2 participants 3 messages Jul 13, 2025 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi,
I noticed in xilinx-cip.c there's xvip_enum_frame_size()
which was added back in 2013 but seems unused in tree, however I had a dig and I found
https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841638/Xilinx+V4L2+TPG+driver
has a commit:
https://github.com/Xilinx/linux-xlnx/commit/1c113b4aef14004152fefc0e8b8dbbcc2314566f#diff-bb594682a92148570df8826933cf8629
from 2014 that uses it - but it looks like that commit never went
anywhere.

So is xvip_enum_frame_size() or not?
I also see xvip_get_format_by_code() looks unused, but I don't see any uses of it, even digging in that wiki.

Thanks in advance,

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#1 lore raw
Quoted 10 lines · Dr. David Alan Gilbert

Hi,
I noticed in xilinx-cip.c there's xvip_enum_frame_size()
which was added back in 2013 but seems unused in tree, however I had a dig and I found
https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841638/Xilinx+V4L2+TPG+driver
has a commit:
https://github.com/Xilinx/linux-xlnx/commit/1c113b4aef14004152fefc0e8b8dbbcc2314566f#diff-bb594682a92148570df8826933cf8629
from 2014 that uses it - but it looks like that commit never went
anywhere.

Quoted 3 lines

So is xvip_enum_frame_size() or not?
I also see xvip_get_format_by_code() looks unused, but I don't see any uses of it, even digging in that wiki.

Those functions seem to have never been used in the mainline kernel. They were likely added to support drivers that have not been upstreamed. Both functions are used in the Xilinx BSP kernel.

Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw
Quoted 11 lines · * Laurent Pinchart ([email protected]) wrote:
Quoted 10 lines · Dr. David Alan Gilbert

Hi,
I noticed in xilinx-cip.c there's xvip_enum_frame_size()
which was added back in 2013 but seems unused in tree, however I had a dig and I found
https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841638/Xilinx+V4L2+TPG+driver
has a commit:
https://github.com/Xilinx/linux-xlnx/commit/1c113b4aef14004152fefc0e8b8dbbcc2314566f#diff-bb594682a92148570df8826933cf8629
from 2014 that uses it - but it looks like that commit never went
anywhere.

Quoted 6 lines
Quoted 3 lines

So is xvip_enum_frame_size() or not?
I also see xvip_get_format_by_code() looks unused, but I don't see any uses of it, even digging in that wiki.

Those functions seem to have never been used in the mainline kernel. They were likely added to support drivers that have not been upstreamed.

Ah, shame.

Quoted 1 line

Both functions are used in the Xilinx BSP kernel.

OK, I'll stay clear.

Dave

Quoted 5 lines
Signature · 3 lines
Regards,

Laurent Pinchart
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/