Skip to contentSkip to conversation

stating: media: atomisp: fix open brace placement

PATCH In review Woohee Yang 3 participants 4 messages Jul 14, 2025 – Apr 18

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 stating: media: atomisp: fix open brace placement

Fix checkpatch error "ERROR: that open brace { should be on the previous line" in isp_param.c

---

Hey, this is my first patch, I appreciate any feedback, thank you!

Changelog:
v2: modified commit message
v1: https://lore.kernel.org/linux-media/[email protected]/

---
 .../media/atomisp/pci/runtime/isp_param/src/isp_param.c     | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c +2 -4
index 251dd75a7613..b4aac76c2ed5 100644
@@ -102,8 +102,7 @@ ia_css_isp_param_allocate_isp_parameters(
 	unsigned int mem, pclass;
 
 	pclass = IA_CSS_PARAM_CLASS_PARAM;
-	for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++)
-	{
+	for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++) {
 		for (pclass = 0; pclass < IA_CSS_NUM_PARAM_CLASSES; pclass++) {
 			u32 size = 0;
 
@@ -178,8 +177,7 @@ ia_css_isp_param_copy_isp_mem_if_to_ddr(
     enum ia_css_param_class pclass) {
 	unsigned int mem;
 
-	for (mem = 0; mem < N_IA_CSS_ISP_MEMORIES; mem++)
-	{
+	for (mem = 0; mem < N_IA_CSS_ISP_MEMORIES; mem++) {
 		size_t       size	  = host->params[pclass][mem].size;
 		ia_css_ptr ddr_mem_ptr  = ddr->params[pclass][mem].address;
 		char	    *host_mem_ptr = host->params[pclass][mem].address;
Signature · 1 line
2.47.2
#1 lore raw
Quoted 3 lines · Woohee Yang

Fix checkpatch error "ERROR: that open brace { should be on the previous line" in isp_param.c

Missing period at the end.

...

Quoted 1 line

Hey, this is my first patch, I appreciate any feedback, thank you!

Already second iteration of it :-)

Is this the only file in that driver with the same issue? There is another patch floating around, perhaps you can combine the efforts, so only one patch for the same issue for the whole driver can be applied?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

Hi,

Quoted 8 lines · Andy Shevchenko
Quoted 3 lines · Woohee Yang

Fix checkpatch error "ERROR: that open brace { should be on the previous line" in isp_param.c

In case Hans wants to apply this,

with the added period in the commit message.

No longer applies to my atomisp branch. :-\

Signature · 1 line
Sakari Ailus