media: staging: atomisp: stylefix
Subsystems (4)
PATCH 1/1 media: staging: atomisp: stylefix
change the spaces at the beginning of the line to tabs
---
My first contribution to the linux kernel, so starting out with a stylefix
--- drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +1 -1
@@ -2347,7 +2347,7 @@ int atomisp_css_video_configure_output(struct atomisp_sub_device *asd, }int atomisp_css_video_configure_viewfinder ( -struct atomisp_sub_device *asd, +struct atomisp_sub_device *asd,unsigned int width,unsigned int height,unsigned int min_width,enum ia_css_frame_format format)
Signature · 1 line
2.39.5
Quoted 2 lines · sina hosseinizad
change the spaces at the beginning of the line to tabs
You have to respect English grammar and punctuation.
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c int atomisp_css_video_configure_output(struct atomisp_sub_device *asd, · line 2353
Quoted 6 lines
int atomisp_css_video_configure_viewfinder(
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +1
-1-struct atomisp_sub_device *asd, +struct atomisp_sub_device *asd, unsigned int width, unsigned int height, unsigned int min_width, enum ia_css_frame_format format)
As a standalone this is useless change and just a churn. Try to find something better to fix, please.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 3 lines · sina hosseinizad
change the spaces at the beginning of the line to tabs
Signed-off-by sina hosseinizad <[email protected]>
You probably want to capitalize your name. It's supposed to be written like you would write it on a legal document. (These Signed off by lines are supposed to be like a legal thing which says that you haven't stolen any code or violated any copy rights in this patch).
Quoted 11 lines
---
My first contribution to the linux kernel, so starting out with a stylefix--- drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +0
-0
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c int atomisp_css_video_configure_output(struct atomisp_sub_device *asd, · line 2351
Quoted 6 lines
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +1
-1@@ -2347,7 +2347,7 @@ int atomisp_css_video_configure_output(struct atomisp_sub_device *asd, } int atomisp_css_video_configure_viewfinder( - struct atomisp_sub_device *asd, + struct atomisp_sub_device *asd, unsigned int width, unsigned int height,
The other lines don't match now.
regards,
dan carpenter
Quoted 5 lines
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +0
-0unsigned int min_width, enum ia_css_frame_format format)Signature · 1 line
2.39.5