hwmon: w83627ehf: make the read-only arrays 'bit' static const
Subsystems (2)
PATCH 1/1 hwmon: w83627ehf: make the read-only arrays 'bit' static const
Don't populate the read-only arrays 'bit' on the stack at run time, instead make them static const.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/hwmon/w83627ehf.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/hwmon/w83627ehf.c +6 -3
@@ -1448,7 +1448,8 @@ w83627ehf_do_read_temp(struct w83627ehf_data *data, u32 attr,return 0 ;case hwmon_temp_alarm:if (channel <3 ) { -int bit[] = {4 ,5 ,13 }; +static const int bit[] = {4 ,5 ,13 }; + *val = (data->alarms >> bit[channel]) &1 ;return 0 ; }
@@ -1479,7 +1480,8 @@ w83627ehf_do_read_in(struct w83627ehf_data *data, u32 attr,return 0 ;case hwmon_in_alarm:if (channel <10 ) { -int bit[] = {0 ,1 ,2 ,3 ,8 ,21 ,20 ,16 ,17 ,19 }; +static const int bit[] = {0 ,1 ,2 ,3 ,8 ,21 ,20 ,16 ,17 ,19 }; + *val = (data->alarms >> bit[channel]) &1 ;return 0 ; }
@@ -1507,7 +1509,8 @@ w83627ehf_do_read_fan(struct w83627ehf_data *data, u32 attr,return 0 ;case hwmon_fan_alarm:if (channel <5 ) { -int bit[] = {6 ,7 ,11 ,10 ,23 }; +static const int bit[] = {6 ,7 ,11 ,10 ,23 }; + *val = (data->alarms >> bit[channel]) &1 ;return 0 ; }
Signature · 1 line
2.50.0
Quoted 4 lines · Colin Ian King
Don't populate the read-only arrays 'bit' on the stack at run time, instead make them static const.
Signed-off-by Colin Ian King <[email protected]>
Applied.
Guenter