Skip to contentSkip to conversation

net: pcs: xpcs: Use devm_clk_get_optional

PATCH Applied Jack Ping CHNG 3 participants 3 messages Jul 15, 2025 – Jul 17, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: pcs: xpcs: Use devm_clk_get_optional

Synopsys DesignWare XPCS CSR clock is optional,
so it is better to use devm_clk_get_optional
instead of devm_clk_get.

---
v2:
- indicate net-next in the subject line
v1: https://lore.kernel.org/netdev/[email protected]/

---
 drivers/net/pcs/pcs-xpcs-plat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/pcs/pcs-xpcs-plat.c +1 -1
index 629315f1e57c..137d91038fb4 100644
@@ -280,7 +280,7 @@ static int xpcs_plat_init_clk(struct dw_xpcs_plat *pxpcs)
 	struct device *dev = &pxpcs->pdev->dev;
 	int ret;
 
-	pxpcs->cclk = devm_clk_get(dev, "csr");
+	pxpcs->cclk = devm_clk_get_optional(dev, "csr");
 	if (IS_ERR(pxpcs->cclk))
 		return dev_err_probe(dev, PTR_ERR(pxpcs->cclk),
 				     "Failed to get CSR clock\n");
Signature · 1 line
2.43.0
#2 lore raw
In reply to Jack Ping CHNG
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 11 lines · On Tue, 15 Jul 2025 10:19:56 +0800 you wrote:

Synopsys DesignWare XPCS CSR clock is optional,
so it is better to use devm_clk_get_optional
instead of devm_clk_get.

---
v2:
- indicate net-next in the subject line
v1: https://lore.kernel.org/netdev/[email protected]/

[...]

Here is the summary with links:
- [net-next,v2] net: pcs: xpcs: Use devm_clk_get_optional

    https://git.kernel.org/netdev/net-next/c/8a2a6bb01664

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html