Skip to contentSkip to conversation

net: skmsg: fix NULL pointer dereference in sk_msg_recvmsg()

PATCH In review Pranav Tyagi 3 participants 4 messages Jul 15, 2025 – Jul 25, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: skmsg: fix NULL pointer dereference in sk_msg_recvmsg()

A NULL page from sg_page() in sk_msg_recvmsg() can reach __kmap_local_page_prot() and crash the kernel. Add a check for the page before calling copy_page_to_iter() and fail early with -EFAULT to prevent the crash.

Reported-by [email protected]
Fixes 2bc793e3272a ("skmsg: Extract __tcp_bpf_recvmsg() and tcp_bpf_wait_data()")
---
 net/core/skmsg.c | 4 ++++
 1 file changed, 4 insertions(+)
net/core/skmsg.c +4 -0
index 4d75ef9d24bf..f5367356a483 100644
@@ -432,6 +432,10 @@ int sk_msg_recvmsg(struct sock *sk, struct sk_psock *psock, struct msghdr *msg,
 			sge = sk_msg_elem(msg_rx, i);
 			copy = sge->length;
 			page = sg_page(sge);
+			if (!page) {
+				copied = copied ? copied : -EFAULT;
+				goto out;
+			}
 			if (copied + copy > len)
 				copy = len - copied;
 			copy = copy_page_to_iter(page, sge->offset, copy, iter);
Signature · 1 line
2.49.0
#1 lore raw
Quoted 32 lines · Pranav Tyagi

A NULL page from sg_page() in sk_msg_recvmsg() can reach __kmap_local_page_prot() and crash the kernel. Add a check for the page before calling copy_page_to_iter() and fail early with -EFAULT to prevent the crash.

Reported-by [email protected]
Fixes 2bc793e3272a ("skmsg: Extract __tcp_bpf_recvmsg() and tcp_bpf_wait_data()")
---
 net/core/skmsg.c | 4 ++++
 1 file changed, 4 insertions(+)
net/core/skmsg.c +4 -0
index 4d75ef9d24bf..f5367356a483 100644
@@ -432,6 +432,10 @@ int sk_msg_recvmsg(struct sock *sk, struct sk_psock *psock, struct msghdr *msg,
 			sge = sk_msg_elem(msg_rx, i);
 			copy = sge->length;
 			page = sg_page(sge);
+			if (!page) {
+				copied = copied ? copied : -EFAULT;
+				goto out;
+			}
 			if (copied + copy > len)
 				copy = len - copied;
 			copy = copy_page_to_iter(page, sge->offset, copy, iter);
Signature · 1 line
2.49.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

maintainer
#2 lore raw
In reply to Pranav Tyagi
Quoted 4 lines · Pranav Tyagi

A NULL page from sg_page() in sk_msg_recvmsg() can reach __kmap_local_page_prot() and crash the kernel. Add a check for the page before calling copy_page_to_iter() and fail early with -EFAULT to prevent the crash.

Interesting. I thought the sge in this case are build from the kernel, I did not expect a null page to be possible. Can you describe in the commit message how such bad sges are created?

Quoted 5 lines
Reported-by [email protected]
Fixes 2bc793e3272a ("skmsg: Extract __tcp_bpf_recvmsg() and tcp_bpf_wait_data()")

Does not apply to net. Please rebase and resend, adding the target tree in the subj prefix and specifying a revision number.

Thanks,

Paolo

#3 lore raw
Quoted 17 lines · Paolo Abeni
Quoted 4 lines · Pranav Tyagi

A NULL page from sg_page() in sk_msg_recvmsg() can reach __kmap_local_page_prot() and crash the kernel. Add a check for the page before calling copy_page_to_iter() and fail early with -EFAULT to prevent the crash.

Interesting. I thought the sge in this case are build from the kernel, I did not expect a null page to be possible. Can you describe in the commit message how such bad sges are created?

Quoted 5 lines
Reported-by [email protected]
Fixes 2bc793e3272a ("skmsg: Extract __tcp_bpf_recvmsg() and tcp_bpf_wait_data()")
Quoted 8 lines

Does not apply to net. Please rebase and resend, adding the target tree in the subj prefix and specifying a revision number.

Thanks,

Paolo

Hi Paolo,

Apologies for a delayed response. I will send a v2 of the patch with all the required changes shortly. Also, as I am a beginner at kernel work, my initial intention was to just fix the bug and (honestly) I did not think about the cause of
bad sges. But, I will definitely take a deep dive and try my level best to look for a suitable explanation for the same.

Thanks for the feedback.

Regards
Pranav Tyagi