selftests: packetdrill: correct the expected timing in tcp_rcv_big_endseq
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 selftests: packetdrill: correct the expected timing in tcp_rcv_big_endseq
Commit f5fda1a86884 ("selftests/net: packetdrill: add tcp_rcv_big_endseq.pkt") added this test recently, but it's failing with:
# tcp_rcv_big_endseq.pkt:41: error handling packet: timing error: expected outbound packet at 1.230105 sec but happened at 1.190101 sec; tolerance 0.005046 sec
# script packet: 1.230105 . 1:1(0) ack 54001 win 0 # actual packet: 1.190101 . 1:1(0) ack 54001 win 0
It's unclear why the test expects the ack to be delayed. Correct it.
--- tools/testing/selftests/net/packetdrill/tcp_rcv_big_endseq.pkt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/packetdrill/tcp_rcv_big_endseq.pkt +1 -1
@@ -38,7 +38,7 @@ // If queue is empty, accept a packet even if its end_seq is above wup + rcv_wnd +0 < P. 4001:54001(50000) ack 1 win 257 - +.040 > . 1:1(0) ack 54001 win 0 + +0 > . 1:1(0) ack 54001 win 0 // Check LINUX_MIB_BEYOND_WINDOW has been incremented 3 times. +0 `nstat | grep TcpExtBeyondWindow | grep -q " 3 "`
Signature · 1 line
2.50.1
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Tue, 15 Jul 2025 07:28:49 -0700 you wrote:
Commit
f5fda1a86884("selftests/net: packetdrill: add tcp_rcv_big_endseq.pkt") added this test recently, but it's failing with:# tcp_rcv_big_endseq.pkt:41: error handling packet: timing error: expected outbound packet at 1.230105 sec but happened at 1.190101 sec; tolerance 0.005046 sec
# script packet: 1.230105 . 1:1(0) ack 54001 win 0 # actual packet: 1.190101 . 1:1(0) ack 54001 win 0[...]
Here is the summary with links:
- [net-next] selftests: packetdrill: correct the expected timing in tcp_rcv_big_endseq
https://git.kernel.org/netdev/net-next/c/511ad4c26446
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html