Skip to contentSkip to conversation

accel/ivpu: Remove lockdep_assert_irqs_disabled()

PATCH Superseded Maarten Lankhorst 2 participants 3 messages Jul 15, 2025 – Jul 22, 2025

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 accel/ivpu: Remove lockdep_assert_irqs_disabled()

This breaks on PREEMPT_RT, and should be unneeded since lockdep can track irq disabled status itself.

---
 drivers/accel/ivpu/ivpu_ipc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/accel/ivpu/ivpu_ipc.c +0 -1
index 39f83225c1815..5f00809d448af 100644
@@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
 	struct ivpu_ipc_rx_msg *rx_msg;
 
 	lockdep_assert_held(&ipc->cons_lock);
-	lockdep_assert_irqs_disabled();
 
 	rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
 	if (!rx_msg) {
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Maarten Lankhorst

This breaks on PREEMPT_RT, and should be unneeded since lockdep can track irq disabled status itself.

---
 drivers/accel/ivpu/ivpu_ipc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/accel/ivpu/ivpu_ipc.c +0 -1
index 39f83225c1815..5f00809d448af 100644
@@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
 	struct ivpu_ipc_rx_msg *rx_msg;
 
 	lockdep_assert_held(&ipc->cons_lock);
-	lockdep_assert_irqs_disabled();
 
 	rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
 	if (!rx_msg) {
#2 lore raw

Hey,

Den 2025-07-22 kl. 09:53, skrev Jacek Lawrynowicz:

Quoted 1 line

Thanks, pushed to misc-next.

Best regards,
~Maarten

Quoted 22 lines · Maarten Lankhorst
Quoted 20 lines

This breaks on PREEMPT_RT, and should be unneeded since lockdep can track irq disabled status itself.

---
 drivers/accel/ivpu/ivpu_ipc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/accel/ivpu/ivpu_ipc.c +0 -1
index 39f83225c1815..5f00809d448af 100644
@@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
 	struct ivpu_ipc_rx_msg *rx_msg;
 
 	lockdep_assert_held(&ipc->cons_lock);
-	lockdep_assert_irqs_disabled();
 
 	rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
 	if (!rx_msg) {