PCI/sysfs: Expose PCIe device serial number
v2 cover PCI/sysfs: Expose PCIe device serial number
Add a single sysfs read-only interface for reading PCIe device serial numbers from userspace, using the same hexadecimal 1-byte dashed formatting as lspci serial number capability output:
more /sys/devices/pci0000:c0/0000:c0:01.1/0000:c1:00.0/0000:c2:1f.0/0000:cc:00.0/device_serial_number
00-80-ee-00-00-00-41-80If a device doesn't support the serial number capability, the device_serial_number sysfs attribute will not be visible.
Comparing serial number format to lspci output:
sudo lspci -vvv -s cc:00.0
cc:00.0 Serial Attached SCSI controller: Broadcom / LSI PCIe Switch management endpoint (rev b0)
Subsystem: Broadcom / LSI Device 0144
...
Capabilities: [100 v1] Device Serial Number 00-80-ee-00-00-00-41-80
...This PCIe device sysfs attribute eliminates the need for parsing lspci output (e.g. regexp) for userspace applications that utilize serial numbers.
Matthew Wood (1):
PCI/sysfs: Expose PCIe device serial number
drivers/pci/pci-sysfs.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)
Signature · 1 line
2.50.0
PATCH v2 1/1 PCI/sysfs: Expose PCIe device serial number
Add a single sysfs read-only interface for reading PCIe device serial numbers from userspace in a programmatic way. This device attribute uses the same hexadecimal 1-byte dashed formatting as lspci serial number capability output. If a device doesn't support the serial number capability, the device_serial_number sysfs attribute will not be visible.
--- drivers/pci/pci-sysfs.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)
drivers/pci/pci-sysfs.c +22 -1
@@ -239,6 +239,22 @@ static ssize_t current_link_width_show(struct device *dev, }static DEVICE_ATTR_RO (current_link_width); +static ssize_t device_serial_number_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct pci_dev *pci_dev =to_pci_dev (dev); +u64 dsn; + + dsn =pci_get_dsn (pci_dev); +if (!dsn) +return -EINVAL ; + +return sysfs_emit (buf,"%02llx-%02llx-%02llx-%02llx-%02llx-%02llx-%02llx-%02llx\n" , + dsn >>56 , (dsn >>48 ) &0xff , (dsn >>40 ) &0xff , (dsn >>32 ) &0xff , + (dsn >>24 ) &0xff , (dsn >>16 ) &0xff , (dsn >>8 ) &0xff , dsn &0xff ); +} +static DEVICE_ATTR_RO (device_serial_number); +static ssize_t secondary_bus_number_show (struct device *dev,struct device_attribute *attr,char *buf)
@@ -660,6 +676,7 @@ static struct attribute *pcie_dev_attrs[] = { &dev_attr_current_link_width.attr, &dev_attr_max_link_width.attr, &dev_attr_max_link_speed.attr, + &dev_attr_device_serial_number.attr, NULL, };
@@ -1749,8 +1766,12 @@ static umode_t pcie_dev_attrs_are_visible(struct kobject *kobj,struct device *dev =kobj_to_dev (kobj);struct pci_dev *pdev =to_pci_dev (dev); -if (pci_is_pcie (pdev)) +if (pci_is_pcie (pdev)) { +if (strncmp (a->name,"device_serial_number" ,20 ) ==0 && + !pci_get_dsn (pdev)) +return 0 ;return a->mode; + }return 0 ; }
Signature · 1 line
2.50.0
Quoted 18 lines · Matthew Wood
Add a single sysfs read-only interface for reading PCIe device serial numbers from userspace in a programmatic way. This device attribute uses the same hexadecimal 1-byte dashed formatting as lspci serial number capability output. If a device doesn't support the serial number capability, the
device_serial_numbersysfs attribute will not be visible.Signed-off-by Matthew Wood <[email protected]>--- drivers/pci/pci-sysfs.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)drivers/pci/pci-sysfs.c +0
-0@@ -239,6 +239,22 @@ static ssize_t current_link_width_show(struct device *dev, }static DEVICE_ATTR_RO (current_link_width);
drivers/pci/pci-sysfs.c static ssize_t current_link_width_show(struct device *dev, · line 250
Quoted 10 lines
drivers/pci/pci-sysfs.c +9
-0+static ssize_t device_serial_number_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct pci_dev *pci_dev =to_pci_dev (dev); +u64 dsn; + + dsn =pci_get_dsn (pci_dev); +if (!dsn) +return -EINVAL ;
-EIO
Quoted 19 lines
drivers/pci/pci-sysfs.c +8
-0+ +return sysfs_emit (buf,"%02llx-%02llx-%02llx-%02llx-%02llx-%02llx-%02llx-%02llx\n" , + dsn >>56 , (dsn >>48 ) &0xff , (dsn >>40 ) &0xff , (dsn >>32 ) &0xff , + (dsn >>24 ) &0xff , (dsn >>16 ) &0xff , (dsn >>8 ) &0xff , dsn &0xff ); +} +static DEVICE_ATTR_RO (device_serial_number); +static ssize_t secondary_bus_number_show (struct device *dev,struct device_attribute *attr,char *buf)@@ -660,6 +676,7 @@ static struct attribute *pcie_dev_attrs[] = { &dev_attr_current_link_width.attr, &dev_attr_max_link_width.attr, &dev_attr_max_link_speed.attr, + &dev_attr_device_serial_number.attr, NULL, };
drivers/pci/pci-sysfs.c static umode_t pcie_dev_attrs_are_visible(struct kobject *kobj, · line 1770
Quoted 6 lines
drivers/pci/pci-sysfs.c +2
-1@@ -1749,8 +1766,12 @@ static umode_t pcie_dev_attrs_are_visible(struct kobject *kobj,struct device *dev =kobj_to_dev (kobj);struct pci_dev *pdev =to_pci_dev (dev); -if (pci_is_pcie (pdev)) +if (pci_is_pcie (pdev)) { + if (strncmp(a->name, "device_serial_number", 20) == 0 &&
Compare to the real 'struct attribute *' instead of the name. You could restructure this a bit to be easier to read.
if (!pci_is_pcie(pdev))
return 0;
if (a == &dev_addr_device_serial_number.attr && !pci_get_dns(pdev))
return 0;
return a->mode;
drivers/pci/pci-sysfs.c static umode_t pcie_dev_attrs_are_visible(struct kobject *kobj, · line 1774
Quoted 4 lines
drivers/pci/pci-sysfs.c +3
-0+ !pci_get_dsn(pdev)) +return 0 ;return a->mode; + }
Also should have some docs in Documentation/ABI/testing/sysfs-bus-pci.
Quoted 6 lines
drivers/pci/pci-sysfs.c +0
-0return 0 ; }Signature · 1 line
2.50.0