riscv: dts: starfive: jh7110-milkv-mars sort properties
Subsystems (3)
PATCH 1/1 riscv: dts: starfive: jh7110-milkv-mars sort properties
Improve style with node property order sort of common properties before vendor prefixes
--- arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts +6 -6
@@ -12,9 +12,9 @@ / { }; &gmac0 { - starfive,tx-use-rgmii-clk; assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>; assigned-clock-parents = <&aoncrg JH7110_AONCLK_GMAC0_RMII_RTX>; + starfive,tx-use-rgmii-clk; status = "okay"; };
@@ -31,14 +31,14 @@ &pcie1 { }; &phy0 { - motorcomm,tx-clk-adj-enabled; + rx-internal-delay-ps = <1500>; + tx-internal-delay-ps = <1500>; + motorcomm,rx-clk-drv-microamp = <3970>; + motorcomm,rx-data-drv-microamp = <2910>; motorcomm,tx-clk-10-inverted; motorcomm,tx-clk-100-inverted; motorcomm,tx-clk-1000-inverted; - motorcomm,rx-clk-drv-microamp = <3970>; - motorcomm,rx-data-drv-microamp = <2910>; - rx-internal-delay-ps = <1500>; - tx-internal-delay-ps = <1500>; + motorcomm,tx-clk-adj-enabled; }; &pwm {
base-commit: 155a3c003e555a7300d156a5252c004c392ec6b0
Signature · 1 line
2.50.0
Quoted 4 lines · E Shattow
Improve style with node property order sort of common properties before vendor prefixes
Signed-off-by E Shattow <[email protected]>
Thanks!
Quoted 44 lines
--- arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts +6
-6@@ -12,9 +12,9 @@ / { }; &gmac0 { - starfive,tx-use-rgmii-clk; assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>; assigned-clock-parents = <&aoncrg JH7110_AONCLK_GMAC0_RMII_RTX>; + starfive,tx-use-rgmii-clk; status = "okay"; };@@ -31,14 +31,14 @@ &pcie1 { }; &phy0 { - motorcomm,tx-clk-adj-enabled; + rx-internal-delay-ps = <1500>; + tx-internal-delay-ps = <1500>; + motorcomm,rx-clk-drv-microamp = <3970>; + motorcomm,rx-data-drv-microamp = <2910>; motorcomm,tx-clk-10-inverted; motorcomm,tx-clk-100-inverted; motorcomm,tx-clk-1000-inverted; - motorcomm,rx-clk-drv-microamp = <3970>; - motorcomm,rx-data-drv-microamp = <2910>; - rx-internal-delay-ps = <1500>; - tx-internal-delay-ps = <1500>; + motorcomm,tx-clk-adj-enabled; }; &pwm {base-commit:
155a3c003e555a7300d156a5252c004c392ec6b0--
2.50.0
Conor Dooley
maintainerQuoted 9 lines · Emil Renner Berthing
Quoted 4 lines · E Shattow
Improve style with node property order sort of common properties before vendor prefixes
Signed-off-by E Shattow <[email protected]>Thanks!
I'm going to pick this up, but it may be very late for 6.17.
Quoted 5 lines · Conor Dooley
Quoted 4 lines · Emil Renner Berthing
Quoted 3 lines · E Shattow
Improve style with node property order sort of common properties before vendor prefixes
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by E Shattow <[email protected]>Thanks!
I'm going to pick this up, but it may be very late for 6.17.
Yes. The other questionable sort style in this dts I was looking at are whether we want "compatible" before "model" in the root '/' node? And then why we have this common pattern of 'pinmux' (or pinctrl*) prioritized firstly in the natural sort order, also pinctrl-names before pinctrl-N is a common pattern that seems an arbitrary reversal of natural sort order?
Thanks,
-E
Conor Dooley
maintainerQuoted 10 lines · E Shattow
Quoted 7 lines · Conor Dooley
Quoted 6 lines · Emil Renner Berthing
Quoted 4 lines · E Shattow
Improve style with node property order sort of common properties before vendor prefixes
Signed-off-by E Shattow <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Thanks!
I'm going to pick this up, but it may be very late for 6.17.
Yes. The other questionable sort style in this dts I was looking at are whether we want "compatible" before "model" in the root '/' node? And
I think usually model comes first, yeah. Whether that's worth doing something about, I'll leave up to you.
Quoted 4 lines
then why we have this common pattern of 'pinmux' (or pinctrl*) prioritized firstly in the natural sort order, also pinctrl-names before pinctrl-N is a common pattern that seems an arbitrary reversal of natural sort order?
Usually "foo" is followed by "foo-names", but pinctrl does appear to be a bit different since everything has a -something suffix. Skimming, it looks like there are actually more instances where pinctrl-names appears before pinctrl-N.