staging: rtl8723bs: Fix comment style warnings
PATCH 1/1 staging: rtl8723bs: Fix comment style warnings
Fix checkpatch warnings in rtl8723bs driver:
- Fix block comment style by moving */ to separate line
- Add missing blank line after variable declarations
- Remove space before tab in commented code
These are coding style fixes that don't change functionality.
--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_efuse.c | 19 +++++++++++++------ 2 files changed, 14 insertions(+), 7 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +1 -1
@@ -1318,7 +1318,7 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue)u8 res = _SUCCESS;/* if (!pwrctrlpriv->bLeisurePs) */ -/* return res; */ +/* return res; */ if (enqueue) { ph2c =rtw_zmalloc (sizeof (struct cmd_obj ));
drivers/staging/rtl8723bs/core/rtw_efuse.c +13 -6
@@ -70,7 +70,8 @@ Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)* When Who Remark * 11/17/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ void Efuse_PowerSwitch( struct adapter *padapter,
@@ -85,6 +86,7 @@ u8 Efuse_CalculateWordCnts(u8 word_en) {u8 word_cnts =0 ; +if (!(word_en &BIT (0 ))) word_cnts++;/* 0 : write enable */ if (!(word_en &BIT (1 )))
@@ -163,7 +165,8 @@ EFUSE_GetEfuseDefinition(* When Who Remark * 09/23/2008 MHC Copy from WMAC. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ u8 EFUSE_Read1Byte( struct adapter *Adapter,
@@ -313,7 +316,8 @@ Efuse_WordEnableDataWrite(struct adapter *padapter,* When Who Remark * 11/11/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ void Efuse_ReadAllMap( struct adapter *padapter,
@@ -350,7 +354,8 @@ void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse, bool bP* When Who Remark * 11/12/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ static void efuse_ShadowRead1Byte (struct adapter *padapter,u16 Offset,u8 *Value) {struct eeprom_priv *pEEPROM =GET_EEPROM_EFUSE_PRIV (padapter);
@@ -396,7 +401,8 @@ static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Val* When Who Remark * 11/13/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ void EFUSE_ShadowMapUpdate (struct adapter *padapter,u8 efuseType,bool bPseudoTest) {struct eeprom_priv *pEEPROM =GET_EEPROM_EFUSE_PRIV (padapter);
@@ -429,7 +435,8 @@ void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoT* When Who Remark * 11/12/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ void EFUSE_ShadowRead (struct adapter *padapter,u8 Type,u16 Offset,u32 *Value) {if (Type ==1 )
Signature · 1 line
2.39.5 (Apple Git-154)
Greg Kroah-Hartman
maintainerQuoted 102 lines · Ignacio Peña
Fix checkpatch warnings in rtl8723bs driver:
- Fix block comment style by moving */ to separate line
- Add missing blank line after variable declarations
- Remove space before tab in commented codeThese are coding style fixes that don't change functionality.
Signed-off-by Ignacio Peña <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_efuse.c | 19 +++++++++++++------ 2 files changed, 14 insertions(+), 7 deletions(-)drivers/staging/rtl8723bs/core/rtw_cmd.c +1
-1@@ -1318,7 +1318,7 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue)u8 res = _SUCCESS;/* if (!pwrctrlpriv->bLeisurePs) */ -/* return res; */ +/* return res; */ if (enqueue) { ph2c =rtw_zmalloc (sizeof (struct cmd_obj ));drivers/staging/rtl8723bs/core/rtw_efuse.c +13
-6@@ -70,7 +70,8 @@ Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)* When Who Remark * 11/17/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ void Efuse_PowerSwitch( struct adapter *padapter,@@ -85,6 +86,7 @@ u8 Efuse_CalculateWordCnts(u8 word_en) {u8 word_cnts =0 ; +if (!(word_en &BIT (0 ))) word_cnts++;/* 0 : write enable */ if (!(word_en &BIT (1 )))@@ -163,7 +165,8 @@ EFUSE_GetEfuseDefinition(* When Who Remark * 09/23/2008 MHC Copy from WMAC. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ u8 EFUSE_Read1Byte( struct adapter *Adapter,@@ -313,7 +316,8 @@ Efuse_WordEnableDataWrite(struct adapter *padapter,* When Who Remark * 11/11/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ void Efuse_ReadAllMap( struct adapter *padapter,@@ -350,7 +354,8 @@ void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse, bool bP* When Who Remark * 11/12/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ static void efuse_ShadowRead1Byte (struct adapter *padapter,u16 Offset,u8 *Value) {struct eeprom_priv *pEEPROM =GET_EEPROM_EFUSE_PRIV (padapter);@@ -396,7 +401,8 @@ static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Val* When Who Remark * 11/13/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ void EFUSE_ShadowMapUpdate (struct adapter *padapter,u8 efuseType,bool bPseudoTest) {struct eeprom_priv *pEEPROM =GET_EEPROM_EFUSE_PRIV (padapter);@@ -429,7 +435,8 @@ void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType, bool bPseudoT* When Who Remark * 11/12/2008 MHC Create Version 0. * -*---------------------------------------------------------------------------*/ +*--------------------------------------------------------------------------- +*/ void EFUSE_ShadowRead (struct adapter *padapter,u8 Type,u16 Offset,u32 *Value) {if (Type ==1 )Signature · 1 line
2.39.5 (Apple Git-154)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot