Skip to contentSkip to conversation

rtc: add amlogic C3 RTC node

PATCH Applied Xianwei Zhao 4 participants 7 messages Jul 17, 2025 – Sep 4, 2025

Subsystems (4)
lore
Share & tools
lore

Xianwei Zhao

author maintainer
#0 lore raw

cover rtc: add amlogic C3 RTC node

Add C3 rtc compatible string and device node.

---
Xianwei Zhao (2):
dt-bindings: rtc: amlogic,a4-rtc: Add compatible string for C3
arm64: dts: amlogic: C3: Add RTC controller node

 .../devicetree/bindings/rtc/amlogic,a4-rtc.yaml          | 11 ++++++++---
 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi              | 16 ++++++++++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)

---
base-commit: 0bafe291cb429d39b5ff70bcf7b2f3ab026dcb02
change-id: 20250717-rtc-c3-node-bb78598d91b3

Best regards,

Signature · 1 line
Xianwei Zhao <[email protected]>
author maintainer
#1 lore raw

PATCH 1/2 dt-bindings: rtc: amlogic,a4-rtc: Add compatible string for C3

Amlogic C3 SoCs uses the same rtc controller as A5 SoCs. There is no need for an extra compatible line in the driver, but add C3 compatible line for documentation.

---
 Documentation/devicetree/bindings/rtc/amlogic,a4-rtc.yaml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/rtc/amlogic,a4-rtc.yaml +8 -3
index 5d3ac737abcb..e61f22eca85b 100644
@@ -16,9 +16,14 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - amlogic,a4-rtc
-      - amlogic,a5-rtc
+    oneOf:
+      - enum:
+          - amlogic,a4-rtc
+          - amlogic,a5-rtc
+      - items:
+          - enum:
+              - amlogic,c3-rtc
+          - const: amlogic,a5-rtc
 
   reg:
     maxItems: 1
Signature · 1 line
2.37.1
maintainer Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: rtc: amlogic,a4-rtc: Add compatible string for C3

Quoted 9 lines · Xianwei Zhao

Amlogic C3 SoCs uses the same rtc controller as A5 SoCs. There is no need for an extra compatible line in the driver, but add C3 compatible line for documentation.

---
 Documentation/devicetree/bindings/rtc/amlogic,a4-rtc.yaml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
maintainer Applied
#3 lore raw

Re: (subset) [PATCH 1/2] dt-bindings: rtc: amlogic,a4-rtc: Add compatible string for C3

In reply to Xianwei Zhao
Quoted 5 lines · Xianwei Zhao

Amlogic C3 SoCs uses the same rtc controller as A5 SoCs. There is no need for an extra compatible line in the driver, but add C3 compatible line for documentation.

Applied, thanks!

[1/2] dt-bindings: rtc: amlogic,a4-rtc: Add compatible string for C3

      https://git.kernel.org/abelloni/c/db22fd8880a2

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author maintainer
#4 lore raw

PATCH 2/2 arm64: dts: amlogic: C3: Add RTC controller node

In reply to Xianwei Zhao

Add the RTC controller node for C3 SoC family.

---
 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi +16 -0
index cb9ea3ca6ee0..b81bffac7732 100644
@@ -53,6 +53,13 @@ xtal: xtal-clk {
 		#clock-cells = <0>;
 	};
 
+	xtal_32k: xtal-clk-32k {
+		compatible = "fixed-clock";
+		clock-frequency = <32768>;
+		clock-output-names = "xtal_32k";
+		#clock-cells = <0>;
+	};
+
 	sm: secure-monitor {
 		compatible = "amlogic,meson-gxbb-sm";
 
@@ -967,6 +974,15 @@ nand: nand-controller@8d000 {
 				clock-names = "core", "device";
 				status = "disabled";
 			};
+
+			rtc@9a000 {
+				compatible = "amlogic,c3-rtc",
+					     "amlogic,a5-rtc";
+				reg = <0x0 0x9a000 0x0 0x38>;
+				interrupts = <GIC_SPI 131 IRQ_TYPE_EDGE_RISING>;
+				clocks = <&xtal_32k>, <&clkc_periphs CLKID_SYS_RTC>;
+				clock-names = "osc", "sys";
+			};
 		};
 
 		ethmac: ethernet@fdc00000 {
Signature · 1 line
2.37.1
maintainer Reviewed-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] arm64: dts: amlogic: C3: Add RTC controller node

Quoted 34 lines · On 17/07/2025 11:38, Xianwei Zhao via B4 Relay wrote:

From: Xianwei Zhao <[email protected]>

Add the RTC controller node for C3 SoC family.

---
  arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)
arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi +9 -0
index cb9ea3ca6ee0..b81bffac7732 100644
@@ -53,6 +53,13 @@ xtal: xtal-clk {
  		#clock-cells = <0>;
  	};
 
+	xtal_32k: xtal-clk-32k {
+		compatible = "fixed-clock";
+		clock-frequency = <32768>;
+		clock-output-names = "xtal_32k";
+		#clock-cells = <0>;
+	};
+
  	sm: secure-monitor {
  		compatible = "amlogic,meson-gxbb-sm";
 
@@ -967,6 +974,15 @@ nand: nand-controller@8d000 {
  				clock-names = "core", "device";
  				status = "disabled";
  			};
+
+			rtc@9a000 {

arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi nand: nand-controller@8d000 { · line 988

Quoted 10 lines
arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi +7 -0
+				compatible = "amlogic,c3-rtc",
+					     "amlogic,a5-rtc";
+				reg = <0x0 0x9a000 0x0 0x38>;
+				interrupts = <GIC_SPI 131 IRQ_TYPE_EDGE_RISING>;
+				clocks = <&xtal_32k>, <&clkc_periphs CLKID_SYS_RTC>;
+				clock-names = "osc", "sys";
+			};
  		};
 
  		ethmac: ethernet@fdc00000 {
maintainer Applied
#6 lore raw

Re: (subset) [PATCH 0/2] rtc: add amlogic C3 RTC node

In reply to Xianwei Zhao

Hi,

Quoted 3 lines · Xianwei Zhao

Add C3 rtc compatible string and device node.

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.18/arm64-dt)

[2/2] arm64: dts: amlogic: C3: Add RTC controller node

      https://git.kernel.org/amlogic/c/59b4c260582a74e641c973d016725e5dca32f300

These changes has been applied on the intermediate git tree [1].

The v6.18/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

Signature · 1 line
Neil