Skip to contentSkip to conversation

drm/tidss: encoder: convert to devm_drm_bridge_alloc()

PATCH In review Michael Walle 3 participants 6 messages Jul 16, 2025 – Jul 18, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tidss: encoder: convert to devm_drm_bridge_alloc()

Convert the tidss encoder to use devm_drm_bridge_alloc(). Instead of allocating the memory by drmm_simple_encoder_alloc() use devm_drm_bridge_alloc() and initialize the encoder afterwards.

Fixes a7748dd127ea ("drm/bridge: get/put the bridge reference in drm_bridge_add/remove()")
---
 drivers/gpu/drm/tidss/tidss_encoder.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/tidss/tidss_encoder.c +7 -3
index 95b4aeff2775..81a04f767770 100644
@@ -90,14 +90,18 @@ int tidss_encoder_create(struct tidss_device *tidss,
 	struct drm_connector *connector;
 	int ret;
 
-	t_enc = drmm_simple_encoder_alloc(&tidss->ddev, struct tidss_encoder,
-					  encoder, encoder_type);
+	t_enc = devm_drm_bridge_alloc(tidss->dev, struct tidss_encoder,
+				      bridge, &tidss_bridge_funcs);
 	if (IS_ERR(t_enc))
 		return PTR_ERR(t_enc);
 
+	ret = drm_simple_encoder_init(&tidss->ddev, &t_enc->encoder,
+				      encoder_type);
+	if (ret)
+		return ret;
+
 	t_enc->tidss = tidss;
 	t_enc->next_bridge = next_bridge;
-	t_enc->bridge.funcs = &tidss_bridge_funcs;
 
 	enc = &t_enc->encoder;
 	enc->possible_crtcs = possible_crtcs;
Signature · 1 line
2.39.5
#1 lore raw

Hello Michael,

Quoted 17 lines · On Wed, 16 Jul 2025 15:41:07 +0200 Michael Walle <[email protected]> wrote:

Convert the tidss encoder to use devm_drm_bridge_alloc(). Instead of allocating the memory by drmm_simple_encoder_alloc() use devm_drm_bridge_alloc() and initialize the encoder afterwards.

Fixes a7748dd127ea ("drm/bridge: get/put the bridge reference in drm_bridge_add/remove()")
---
 drivers/gpu/drm/tidss/tidss_encoder.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/tidss/tidss_encoder.c +0 -0
index 95b4aeff2775..81a04f767770 100644
@@ -90,14 +90,18 @@ int tidss_encoder_create(struct tidss_device *tidss,
 	struct drm_connector *connector;
 	int ret;

drivers/gpu/drm/tidss/tidss_encoder.c int tidss_encoder_create(struct tidss_device *tidss, · line 99

Quoted 10 lines
drivers/gpu/drm/tidss/tidss_encoder.c +4 -2
 
-	t_enc = drmm_simple_encoder_alloc(&tidss->ddev, struct tidss_encoder,
-					  encoder, encoder_type);
+	t_enc = devm_drm_bridge_alloc(tidss->dev, struct tidss_encoder,
+				      bridge, &tidss_bridge_funcs);
 	if (IS_ERR(t_enc))
 		return PTR_ERR(t_enc);
 
+	ret = drm_simple_encoder_init(&tidss->ddev, &t_enc->encoder,
+				      encoder_type);

Nit: this should be a single line (< 100 chars).

drivers/gpu/drm/tidss/tidss_encoder.c int tidss_encoder_create(struct tidss_device *tidss, · line 107

Quoted 9 lines
drivers/gpu/drm/tidss/tidss_encoder.c +3 -1
+	if (ret)
+		return ret;
+
 	t_enc->tidss = tidss;
 	t_enc->next_bridge = next_bridge;
-	t_enc->bridge.funcs = &tidss_bridge_funcs;
 
 	enc = &t_enc->encoder;
 	enc->possible_crtcs = possible_crtcs;

This patch switches from drmm_ to devm_, but I haven't checked in detail whether this introduces a different lifetime. At a very quick glance however it looks fine.

With that assumption, looks like a correct patch.

However allocating an encoder using a bridge alloc function (while we used to call an encoder allocation function) looks counter-intuitive.

We had discussed on IRC a different idea, adding a wrapper structure around the bridge. Quoting your proposal:

  struct tidss_encoder_bridge {
    struct drm_bridge bridge;
    struct tidss_encoder *encoder
  }

and then in the bridge funcs go from drm_bridge to tidss_encoder_brigde and use the pointer to get the original private struct.

That would be cleaner and more intuitive, but use a bit more memory and have an additional pointer deref, thus I think we can live with the patch you just sent, at least for now.

In the long term it may be that more and more components of the DRM subsystem become dynamically allocated like bridges and panels [0] have recently become. So at some point it may make sense to add the bridge wrapper struct and then go back to drmm_simple_encoder_alloc() for allocation.

[0] https://lore.kernel.org/all/[email protected]/

Luca

Signature · 3 lines
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

Hi,

thanks for taking a look!

Quoted 6 lines

However allocating an encoder using a bridge alloc function (while we used to call an encoder allocation function) looks counter-intuitive.

We had discussed on IRC a different idea, adding a wrapper structure around the bridge. Quoting your proposal:

Quoted 7 lines
  struct tidss_encoder_bridge {
    struct drm_bridge bridge;
    struct tidss_encoder *encoder
  }

and then in the bridge funcs go from drm_bridge to tidss_encoder_brigde and use the pointer to get the original private struct.

I was doing that until I've realized that meson/meson_encoder_* is doing it the way this patch does it.

Quoted 3 lines

That would be cleaner and more intuitive, but use a bit more memory and have an additional pointer deref, thus I think we can live with the patch you just sent, at least for now.

I'm fine with changing it to the wrapper struct. It's your/the maintainers call :)

-michael

Quoted 9 lines

In the long term it may be that more and more components of the DRM subsystem become dynamically allocated like bridges and panels [0] have recently become. So at some point it may make sense to add the bridge wrapper struct and then go back to drmm_simple_encoder_alloc() for allocation.

[0] https://lore.kernel.org/all/[email protected]/

Luca

#3 lore raw

Hello Jyri, Tomi, Michael,

Quoted 15 lines · On Thu, 17 Jul 2025 09:49:44 +0200 "Michael Walle" <[email protected]> wrote:

Hi,

thanks for taking a look!

Quoted 11 lines

However allocating an encoder using a bridge alloc function (while we used to call an encoder allocation function) looks counter-intuitive.

We had discussed on IRC a different idea, adding a wrapper structure around the bridge. Quoting your proposal:

  struct tidss_encoder_bridge {
    struct drm_bridge bridge;
    struct tidss_encoder *encoder
  }
Quoted 5 lines
Quoted 2 lines

and then in the bridge funcs go from drm_bridge to tidss_encoder_brigde and use the pointer to get the original private struct.

I was doing that until I've realized that meson/meson_encoder_* is doing it the way this patch does it.

Which was done by, er, myself. O:-)

To my excuse, meson was using *_encoder_alloc() but rather devm_kzalloc() + drm_simple_encoder_init(), and the change was semi-automated via a coccinelle script, so I didn't fully realize that.

Quoted 6 lines
Quoted 3 lines

That would be cleaner and more intuitive, but use a bit more memory and have an additional pointer deref, thus I think we can live with the patch you just sent, at least for now.

I'm fine with changing it to the wrapper struct. It's your/the maintainers call :)

I think the driver maintainers opinion is more relevant, but in lack of one I think we can take the patch as is, given it's already written.

Jyri, Tomi?

Luca

Signature · 3 lines
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer
#4 lore raw

Hi,

Quoted 36 lines · Luca Ceresoli

Hello Jyri, Tomi, Michael,

Quoted 15 lines · On Thu, 17 Jul 2025 09:49:44 +0200 "Michael Walle" <[email protected]> wrote:

Hi,

thanks for taking a look!

Quoted 11 lines

However allocating an encoder using a bridge alloc function (while we used to call an encoder allocation function) looks counter-intuitive.

We had discussed on IRC a different idea, adding a wrapper structure around the bridge. Quoting your proposal:

  struct tidss_encoder_bridge {
    struct drm_bridge bridge;
    struct tidss_encoder *encoder
  }
Quoted 5 lines
Quoted 2 lines

and then in the bridge funcs go from drm_bridge to tidss_encoder_brigde and use the pointer to get the original private struct.

I was doing that until I've realized that meson/meson_encoder_* is doing it the way this patch does it.

Which was done by, er, myself. O:-)

To my excuse, meson was using *_encoder_alloc() but rather devm_kzalloc() + drm_simple_encoder_init(), and the change was semi-automated via a coccinelle script, so I didn't fully realize that.

Quoted 4 lines
Quoted 3 lines

That would be cleaner and more intuitive, but use a bit more memory and have an additional pointer deref, thus I think we can live with the patch you just sent, at least for now.

Quoted 7 lines
Quoted 2 lines

I'm fine with changing it to the wrapper struct. It's your/the maintainers call :)

I think the driver maintainers opinion is more relevant, but in lack of one I think we can take the patch as is, given it's already written.

Jyri, Tomi?

I think this is fine, even though I do agree the tidss_encoder.c is very confusing.

I'll pick this up. I think drm-misc-next-fixes is the correct branch here.

Tomi

#5 lore raw

Hello Tomi,

Quoted 45 lines · On Fri, 18 Jul 2025 14:13:03 +0300 Tomi Valkeinen…

Hi,

Quoted 42 lines · Luca Ceresoli

Hello Jyri, Tomi, Michael,

Quoted 15 lines · On Thu, 17 Jul 2025 09:49:44 +0200 "Michael Walle" <[email protected]> wrote:

Hi,

thanks for taking a look!

Quoted 11 lines

However allocating an encoder using a bridge alloc function (while we used to call an encoder allocation function) looks counter-intuitive.

We had discussed on IRC a different idea, adding a wrapper structure around the bridge. Quoting your proposal:

  struct tidss_encoder_bridge {
    struct drm_bridge bridge;
    struct tidss_encoder *encoder
  }
Quoted 5 lines
Quoted 2 lines

and then in the bridge funcs go from drm_bridge to tidss_encoder_brigde and use the pointer to get the original private struct.

I was doing that until I've realized that meson/meson_encoder_* is doing it the way this patch does it.

Which was done by, er, myself. O:-)

To my excuse, meson was using *_encoder_alloc() but rather devm_kzalloc() + drm_simple_encoder_init(), and the change was semi-automated via a coccinelle script, so I didn't fully realize that.

Quoted 6 lines
Quoted 3 lines

That would be cleaner and more intuitive, but use a bit more memory and have an additional pointer deref, thus I think we can live with the patch you just sent, at least for now.

I'm fine with changing it to the wrapper struct. It's your/the maintainers call :)

I think the driver maintainers opinion is more relevant, but in lack of one I think we can take the patch as is, given it's already written.

Quoted 6 lines
Quoted 1 line

Jyri, Tomi?

I think this is fine, even though I do agree the tidss_encoder.c is very confusing.

I'll pick this up. I think drm-misc-next-fixes is the correct branch here.

Looks like to correct branch to me.

Thanks for handling this!

Luca

Signature · 3 lines
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com