usb: typec: ucsi: yoga-c630: add DRM dependency
Subsystems (2)
PATCH 1/1 usb: typec: ucsi: yoga-c630: add DRM dependency
From: Arnd Bergmann <[email protected]>
Selecting DRM_AUX_HPD_BRIDGE is not possible from a built-in driver when CONFIG_DRM=m:
WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y] && OF [=y]
Selected by [y]:
- UCSI_LENOVO_YOGA_C630 [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_UCSI [=y] && EC_LENOVO_YOGA_C630 [=y] && DRM_BRIDGE [=y] && OF [=y]
arm-linux-gnueabi-ld: drivers/gpu/drm/bridge/aux-hpd-bridge.o: in function `drm_aux_hpd_bridge_notify':
aux-hpd-bridge.c:(.text.drm_aux_hpd_bridge_notify+0x28): undefined reference to `drm_bridge_hpd_notify'
arm-linux-gnueabi-ld: drivers/gpu/drm/bridge/aux-hpd-bridge.o: in function `drm_aux_hpd_bridge_probe':
aux-hpd-bridge.c:(.text.drm_aux_hpd_bridge_probe+0x20): undefined reference to `__devm_drm_bridge_alloc'
Add a dependency to force UCSI_LENOVO_YOGA_C630 to be a loadable module as well in this configuration.
--- drivers/usb/typec/ucsi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/usb/typec/ucsi/Kconfig +1 -0
@@ -85,6 +85,7 @@ config CROS_EC_UCSI config UCSI_LENOVO_YOGA_C630 tristate "UCSI Interface Driver for Lenovo Yoga C630" depends on EC_LENOVO_YOGA_C630 + depends on DRM || !DRM select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF help This driver enables UCSI support on the Lenovo Yoga C630 laptop.
Signature · 1 line
2.39.5
Quoted 14 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Selecting
DRM_AUX_HPD_BRIDGEis not possible from a built-in driver whenCONFIG_DRM=m:WARNING: unmet direct dependencies detected for
DRM_AUX_HPD_BRIDGE
Depends on [m]:HAS_IOMEM[=y] && DRM [=m] &&DRM_BRIDGE[=y] && OF [=y]
Selected by [y]:
-UCSI_LENOVO_YOGA_C630[=y] &&USB_SUPPORT[=y] && TYPEC [=y] &&TYPEC_UCSI[=y] &&EC_LENOVO_YOGA_C630[=y] &&DRM_BRIDGE[=y] && OF [=y]
arm-linux-gnueabi-ld:drivers/gpu/drm/bridge/aux-hpd-bridge.o: in function `drm_aux_hpd_bridge_notify':
aux-hpd-bridge.c:(.text.drm_aux_hpd_bridge_notify+0x28): undefined reference to `drm_bridge_hpd_notify'
arm-linux-gnueabi-ld:drivers/gpu/drm/bridge/aux-hpd-bridge.o: in function `drm_aux_hpd_bridge_probe':
aux-hpd-bridge.c:(.text.drm_aux_hpd_bridge_probe+0x20): undefined reference to `__devm_drm_bridge_alloc'
Quoted 5 lines
Add a dependency to force
UCSI_LENOVO_YOGA_C630to be a loadable module as well in this configuration.Fixes eb90d36bfa06 ("usb: typec: ucsi: yoga-c630: register DRM HPD bridge")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 18 lines
--- drivers/usb/typec/ucsi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/usb/typec/ucsi/Kconfig +1
-0@@ -85,6 +85,7 @@ config CROS_EC_UCSI config UCSI_LENOVO_YOGA_C630 tristate "UCSI Interface Driver for Lenovo Yoga C630" depends on EC_LENOVO_YOGA_C630 + depends on DRM || !DRM select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF help This driver enables UCSI support on the Lenovo Yoga C630 laptop.Signature · 1 line
2.39.5
Signature · 1 line
heikki