Skip to contentSkip to conversation

drm/sitronix/st7571-i2c: Make st7571_panel_data to be static variables

PATCH Superseded Javier Martinez Canillas 2 participants 2 messages Jul 18, 2025

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/sitronix/st7571-i2c: Make st7571_panel_data to be static variables

The kernel test robot reported that sparse gives the following warnings:

make C=2 M=drivers/gpu/drm/sitronix/
CC [M] st7571-i2c.o
CHECK st7571-i2c.c
st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static? st7571-i2c.c:1039:26: warning: symbol 'st7571_config' was not declared. Should it be static?
MODPOST Module.symvers
LD [M] st7571-i2c.ko

---

 drivers/gpu/drm/sitronix/st7571-i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/sitronix/st7571-i2c.c +2 -2
index 453eb7e045e5..7fe5b69e6f2f 100644
@@ -1024,7 +1024,7 @@ static void st7571_remove(struct i2c_client *client)
 	drm_dev_unplug(&st7571->dev);
 }
 
-struct st7571_panel_data st7567_config = {
+static struct st7571_panel_data st7567_config = {
 	.init = st7567_lcd_init,
 	.parse_dt = st7567_parse_dt,
 	.constraints = {
@@ -1036,7 +1036,7 @@ struct st7571_panel_data st7567_config = {
 	},
 };
 
-struct st7571_panel_data st7571_config = {
+static struct st7571_panel_data st7571_config = {
 	.init = st7571_lcd_init,
 	.parse_dt = st7571_parse_dt,
 	.constraints = {
Signature · 4 lines
2.49.0

base-commit: a55863ba4c9ea9febe81ecf7dba36e7989a37b7e
branch: drm-misc-next
#1 lore raw

Hi Javier

Am 18.07.25 um 09:25 schrieb Javier Martinez Canillas:

Quoted 23 lines

The kernel test robot reported that sparse gives the following warnings:

make C=2 M=drivers/gpu/drm/sitronix/
CC [M] st7571-i2c.o
CHECK st7571-i2c.c
st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static? st7571-i2c.c:1039:26: warning: symbol 'st7571_config' was not declared. Should it be static?
MODPOST Module.symvers
LD [M] st7571-i2c.ko

---

  drivers/gpu/drm/sitronix/st7571-i2c.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/sitronix/st7571-i2c.c +0 -0
index 453eb7e045e5..7fe5b69e6f2f 100644

drivers/gpu/drm/sitronix/st7571-i2c.c static void st7571_remove(struct i2c_client *client) · line 1027

Quoted 5 lines
drivers/gpu/drm/sitronix/st7571-i2c.c +1 -1
@@ -1024,7 +1024,7 @@ static void st7571_remove(struct i2c_client *client)
  	drm_dev_unplug(&st7571->dev);
  }
 
-struct st7571_panel_data st7567_config = {
+static struct st7571_panel_data st7567_config = {

Make it 'static const' please. Here and below.

Best regards
Thomas

Quoted 12 lines
drivers/gpu/drm/sitronix/st7571-i2c.c +1 -1
  	.init = st7567_lcd_init,
  	.parse_dt = st7567_parse_dt,
  	.constraints = {
@@ -1036,7 +1036,7 @@ struct st7571_panel_data st7567_config = {
  	},
  };
 
-struct st7571_panel_data st7571_config = {
+static struct st7571_panel_data st7571_config = {
  	.init = st7571_lcd_init,
  	.parse_dt = st7571_parse_dt,
  	.constraints = {
Signature · 7 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)