Skip to contentSkip to conversation

net/ixgbe: fix port mask default value on E610

PATCH In review Yuan Wang 2 participants 3 messages Jul 18, 2025 – Sep 10, 2025 Network drivers

lore
Share & tools
lore

Yuan Wang

author
#0 lore raw

PATCH 1/1 net/ixgbe: fix port mask default value on E610

Modification of default values should be limited to E610, as 82599 handles raw IP well.

Fixes c81daae2383a (net/ixgbe: fix port mask default value in filter)
---
 drivers/net/intel/ixgbe/ixgbe_flow.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/intel/ixgbe/ixgbe_flow.c +4 -2
index 1bf0af330f..71b11f9e70 100644
@@ -1644,8 +1644,10 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
 	memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
 	rule->mask.vlan_tci_mask = 0;
 	rule->mask.flex_bytes_mask = 0;
-	rule->mask.dst_port_mask = 0;
-	rule->mask.src_port_mask = 0;
+	if (hw->mac.type == ixgbe_mac_E610) {
+		rule->mask.dst_port_mask = 0;
+		rule->mask.src_port_mask = 0;
+	}
 
 	/**
 	 * The first not void item should be
Signature · 1 line
2.47.1
#1 lore raw
Quoted 3 lines · Yuan Wang

Modification of default values should be limited to E610, as 82599 handles raw IP well.

Hi,

I think you could do with clarifying the issue here. The patch title seems to imply that there is an issue with the E610, but in fact the code change is for all NICs except E610. What is the observed behaviour on an X550 or an 82599 NIC vs what is desired? Is setting the default masks to zero not ok?

Thanks,
/Bruce

Quoted 28 lines
Fixes c81daae2383a (net/ixgbe: fix port mask default value in filter)
---
 drivers/net/intel/ixgbe/ixgbe_flow.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/intel/ixgbe/ixgbe_flow.c +4 -2
index 1bf0af330f..71b11f9e70 100644
@@ -1644,8 +1644,10 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
 	memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
 	rule->mask.vlan_tci_mask = 0;
 	rule->mask.flex_bytes_mask = 0;
-	rule->mask.dst_port_mask = 0;
-	rule->mask.src_port_mask = 0;
+	if (hw->mac.type == ixgbe_mac_E610) {
+		rule->mask.dst_port_mask = 0;
+		rule->mask.src_port_mask = 0;
+	}
 
 	/**
 	 * The first not void item should be
Signature · 1 line
2.47.1
#2 lore raw

Hi Bruce,

Sorry for the late reply.

The purpose of this patch is to prevent issues introduced after values are initialized to zero, such as the failure to create a second rule on 82599.

I understand and agree with your concern. I didn't take models other than E610 and 82599 into account, so this patch will be dropped.

Thanks for pointing this out.

Best regards,
Yuan

Quoted 53 lines

-----Original Message-----
From: Richardson, Bruce <[email protected]>
Sent: Monday, August 11, 2025 8:31 PM
To: Wang, YuanX <[email protected]>
Cc: Burakov, Anatoly <[email protected]>; Medvedkin, Vladimir <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH] net/ixgbe: fix port mask default value on E610

Quoted 3 lines · Yuan Wang

Modification of default values should be limited to E610, as 82599 handles raw IP well.

Hi,

I think you could do with clarifying the issue here. The patch title seems to imply that there is an issue with the E610, but in fact the code change is for all NICs except E610. What is the observed behaviour on an X550 or an 82599 NIC vs what is desired? Is setting the default masks to zero not ok?

Thanks,
/Bruce

drivers/net/intel/ixgbe/ixgbe_flow.c ixgbe_parse_fdir_filter_normal(struct

Quoted 14 lines
Fixes c81daae2383a (net/ixgbe: fix port mask default value in filter)
---
 drivers/net/intel/ixgbe/ixgbe_flow.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/intel/ixgbe/ixgbe_flow.c +0 -0
index 1bf0af330f..71b11f9e70 100644
@@ -1644,8 +1644,10 @@ ixgbe_parse_fdir_filter_normal(struct

rte_eth_dev *dev,

Quoted 15 lines
drivers/net/intel/ixgbe/ixgbe_flow.c +4 -3
 	memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
 	rule->mask.vlan_tci_mask = 0;
 	rule->mask.flex_bytes_mask = 0;
-	rule->mask.dst_port_mask = 0;
-	rule->mask.src_port_mask = 0;
+	if (hw->mac.type == ixgbe_mac_E610) {
+		rule->mask.dst_port_mask = 0;
+		rule->mask.src_port_mask = 0;
+	}
 
 	/**
 	 * The first not void item should be
--

2.47.1