Skip to contentSkip to conversation

bcachefs: Use user_backed_iter instead of iter_is_iovec

PATCH Applied Alan Huang 2 participants 2 messages Jul 18, 2025

lore
Share & tools
lore

Alan Huang

author
#0 lore raw

PATCH v2 1/1 bcachefs: Use user_backed_iter instead of iter_is_iovec

ITER_UBUF is also one of the user backed iter, which is equivalent of single-segment iovec. DIO handling should use user_backed_iter.

---

V2: imporve commit message

 fs/bcachefs/fs-io-direct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/fs-io-direct.c +1 -1
index 1f5154d9676b..6fdc477c81af 100644
@@ -127,7 +127,7 @@ static int bch2_direct_IO_read(struct kiocb *req, struct iov_iter *iter)
 	 * the dirtying of requests that are internal from the kernel (i.e. from
 	 * loopback), because we'll deadlock on page_lock.
 	 */
-	dio->should_dirty = iter_is_iovec(iter);
+	dio->should_dirty = user_backed_iter(iter);
 
 	blk_start_plug(&plug);
 
Signature · 1 line
2.48.1
#1 lore raw
Quoted 2 lines · Alan Huang

ITER_UBUF is also one of the user backed iter, which is equivalent of single-segment iovec. DIO handling should use user_backed_iter.

Applied...

Quoted 26 lines

---

V2: imporve commit message

 fs/bcachefs/fs-io-direct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/fs-io-direct.c +1 -1
index 1f5154d9676b..6fdc477c81af 100644
@@ -127,7 +127,7 @@ static int bch2_direct_IO_read(struct kiocb *req, struct iov_iter *iter)
 	 * the dirtying of requests that are internal from the kernel (i.e. from
 	 * loopback), because we'll deadlock on page_lock.
 	 */
-	dio->should_dirty = iter_is_iovec(iter);
+	dio->should_dirty = user_backed_iter(iter);
 
 	blk_start_plug(&plug);
 
Signature · 1 line
2.48.1