Skip to contentSkip to conversation

spidev: introduce trivial abb sensor device

PATCH In review Heiko Schocher 6 participants 15 messages Jul 19, 2025 – Aug 1, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover spidev: introduce trivial abb sensor device

This series introduces the changes needed for trivial spi based sensors from ABB, currently operated from userspace.

The last patch adds the spidevices to the DTS files, already in mainline.

make dtbs_check showed no errors/warnings for the dts files

DTC [C] arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-adpismarc.dtb DTC [C] arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-helios.dtb
DTC arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-helios-lvds.dtbo
DTC [C] arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-proton2s.dtb

Heiko Schocher (3):
dt-bindings: trivial-devices: Document ABB sensors
spi: spidev: Add an entry for the ABB spi sensors
arm64: dts: imx8mp: add ABB spi sensors

 .../devicetree/bindings/trivial-devices.yaml  |  2 ++
 .../freescale/imx8mp-aristainetos3-helios.dts | 28 +++++++++++++++++++
 .../imx8mp-aristainetos3-proton2s.dts         | 22 +++++++++++++++
 drivers/spi/spidev.c                          |  2 ++
 4 files changed, 54 insertions(+)
Signature · 3 lines
2.20.1

base-commit: 3668990919df7a8df60ab1f39ec95f59434b68ec
#1 lore raw

PATCH 1/3 dt-bindings: trivial-devices: Document ABB sensors

Add documentation for spi based ABB sensors, which are currently operated from userspace.

---

 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
index 27930708ccd5..25260c2b81df 100644
@@ -30,6 +30,8 @@ properties:
     items:
       # Entries are sorted alphanumerically by the compatible
       - enum:
+            # ABB register based spi sensors
+          - abb,spi-sensor
             # Acbel fsg032 power supply
           - acbel,fsg032
             # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
Signature · 1 line
2.20.1
maintainer
#2 lore raw

Re: [PATCH v1 1/3] dt-bindings: trivial-devices: Document ABB sensors

Quoted 2 lines · Heiko Schocher

Add documentation for spi based ABB sensors, which are currently operated from userspace.

What is userspace? That has nothing to do with bindings.

Please provide some details about this h/w and convince me it is trivial.

Quoted 23 lines

---

 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
index 27930708ccd5..25260c2b81df 100644
@@ -30,6 +30,8 @@ properties:
     items:
       # Entries are sorted alphanumerically by the compatible
       - enum:
+            # ABB register based spi sensors
+          - abb,spi-sensor
             # Acbel fsg032 power supply
           - acbel,fsg032
             # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
Signature · 1 line
2.20.1
#3 lore raw

Re: [PATCH v1 1/3] dt-bindings: trivial-devices: Document ABB sensors

Quoted 6 lines · Rob Herring
Quoted 2 lines · Heiko Schocher

Add documentation for spi based ABB sensors, which are currently operated from userspace.

What is userspace? That has nothing to do with bindings.

Taking one step further back ... what are "spi based ABB sensors" ?

Guenter

Quoted 26 lines

Please provide some details about this h/w and convince me it is trivial.

Quoted 23 lines

---

  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
  1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
index 27930708ccd5..25260c2b81df 100644
@@ -30,6 +30,8 @@ properties:
      items:
        # Entries are sorted alphanumerically by the compatible
        - enum:
+            # ABB register based spi sensors
+          - abb,spi-sensor
              # Acbel fsg032 power supply
            - acbel,fsg032
              # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
Signature · 1 line
2.20.1
#4 lore raw

Re: [PATCH v1 1/3] dt-bindings: trivial-devices: Document ABB sensors

Hi Guenther, Rob,

Quoted 5 lines · Guenter Roeck
Quoted 4 lines · Rob Herring
Quoted 2 lines · Heiko Schocher

Add documentation for spi based ABB sensors, which are currently operated from userspace.

Quoted 9 lines
Quoted 2 lines

What is userspace? That has nothing to do with bindings.

Taking one step further back ... what are "spi based ABB sensors" ?

Guenter

Quoted 2 lines

Please provide some details about this h/w and convince me it is trivial.

This sensors are fully controlled through spidev driver, with a simple register based interface and they have no other connections as the SPI lines, so they only need a compatible entry.

bye,
Heiko

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines

---

  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++

  1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +0 -0
index 27930708ccd5..25260c2b81df 100644
@@ -30,6 +30,8 @@ properties:

      items:
        # Entries are sorted alphanumerically by the compatible
        - enum:
+            # ABB register based spi sensors
+          - abb,spi-sensor
              # Acbel fsg032 power supply
            - acbel,fsg032
              # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin

Signature · 1 line
2.20.1
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
#5 lore raw

PATCH 2/3 spi: spidev: Add an entry for the ABB spi sensors

In reply to Heiko Schocher

This sensors are currently controlled from userspace, ideally we will add full drivers in the future.

---

 drivers/spi/spidev.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/spidev.c +2 -0
index 6108959c28d9..5300c942a2a4 100644
@@ -703,6 +703,7 @@ static const struct class spidev_class = {
  * spidev_dt_ids array below. Both arrays are kept in the same ordering.
  */
 static const struct spi_device_id spidev_spi_ids[] = {
+	{ .name = /* abb */ "spi-sensor" },
 	{ .name = /* cisco */ "spi-petra" },
 	{ .name = /* dh */ "dhcom-board" },
 	{ .name = /* elgin */ "jg10309-01" },
@@ -735,6 +736,7 @@ static int spidev_of_check(struct device *dev)
 }
 
 static const struct of_device_id spidev_dt_ids[] = {
+	{ .compatible = "abb,spi-sensor", .data = &spidev_of_check },
 	{ .compatible = "cisco,spi-petra", .data = &spidev_of_check },
 	{ .compatible = "dh,dhcom-board", .data = &spidev_of_check },
 	{ .compatible = "elgin,jg10309-01", .data = &spidev_of_check },
Signature · 1 line
2.20.1
#6 lore raw

PATCH 3/3 arm64: dts: imx8mp: add ABB spi sensors

In reply to Heiko Schocher

add for the spi busses the ABB sensor trivial compatible entry, so they can be accessed from userspace.

---

 .../freescale/imx8mp-aristainetos3-helios.dts | 28 +++++++++++++++++++
 .../imx8mp-aristainetos3-proton2s.dts         | 22 +++++++++++++++
 2 files changed, 50 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-helios.dts +28 -0
index a4e649a8239b..b6ba6229acd7 100644
@@ -52,6 +52,34 @@
 	};
 };
 
+&ecspi1 {
+	spidev0_0: spi@0 {
+		reg = <0>;
+		compatible = "abb,spi-sensor";
+		spi-max-frequency = <54000000>;
+	};
+
+	spidev0_1: spi@1 {
+		compatible = "abb,spi-sensor";
+		reg = <1>;
+		spi-max-frequency = <54000000>;
+	};
+};
+
+&ecspi2 {
+	spidev1_0: spi@0 {
+		reg = <0>;
+		compatible = "abb,spi-sensor";
+		spi-max-frequency = <54000000>;
+	};
+
+	spidev1_1: spi@1 {
+		reg = <1>;
+		compatible = "abb,spi-sensor";
+		spi-max-frequency = <54000000>;
+	};
+};
+
 &ethphy1 {
 	status = "disabled";
 };
arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-proton2s.dts +22 -0
index 2a736dbe96b4..e804688b2e74 100644
@@ -28,6 +28,28 @@
 	};
 };
 
+&ecspi1 {
+	spidev0_0: spi@0 {
+		compatible = "abb,spi-sensor";
+		reg = <0>;
+		spi-max-frequency = <54000000>;
+	};
+
+	spidev0_1: spi@1 {
+		compatible = "abb,spi-sensor";
+		reg = <1>;
+		spi-max-frequency = <54000000>;
+	};
+};
+
+&ecspi2 {
+	spidev1_0: spi@0 {
+		compatible = "abb,spi-sensor";
+		reg = <0>;
+		spi-max-frequency = <54000000>;
+	};
+};
+
 &ethphy1 {
 	status = "disabled";
 };
Signature · 1 line
2.20.1
maintainer
#7 lore raw

Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device

In reply to Heiko Schocher
Quoted 9 lines · Heiko Schocher

This series introduces the changes needed for trivial spi based sensors from ABB, currently operated from userspace.

The last patch adds the spidevices to the DTS files, already in mainline.

make dtbs_check showed no errors/warnings for the dts files

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] dt-bindings: trivial-devices: Document ABB sensors

      commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
      commit: d60f7cab7c04944a79af16caa43c141e780a59c6

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#8 lore raw

Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device

Quoted 13 lines · Mark Brown
Quoted 9 lines · Heiko Schocher

This series introduces the changes needed for trivial spi based sensors from ABB, currently operated from userspace.

The last patch adds the spidevices to the DTS files, already in mainline.

make dtbs_check showed no errors/warnings for the dts files

[...]

Applied to

Quoted 9 lines

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] dt-bindings: trivial-devices: Document ABB sensors

      commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
      commit: d60f7cab7c04944a79af16caa43c141e780a59c6

That's unexpected, Mark. Patches received two objections/comments and I don't think discussion was resolved.

ABB is huge company, probably making hundreds or more of sensors. The patchset basically claims that all of them work with spidev. It does not providing any model names or details, so it seems really incomplete to call them trivial devices.

Best regards,
Krzysztof

maintainer
#9 lore raw

Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device

Quoted 9 lines · Krzysztof Kozlowski
Quoted 4 lines · Mark Brown

[1/3] dt-bindings: trivial-devices: Document ABB sensors

      commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
      commit: d60f7cab7c04944a79af16caa43c141e780a59c6

That's unexpected, Mark. Patches received two objections/comments and I don't think discussion was resolved.

Oh, sorry - I'd missed those (possibly due to only being CCed on part of the series). I guess I'll drop this then.

#10 lore raw

Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device

In reply to Krzysztof Kozlowski

Hello Krzysztof,

Quoted 25 lines · Krzysztof Kozlowski
Quoted 13 lines · Mark Brown
Quoted 9 lines · Heiko Schocher

This series introduces the changes needed for trivial spi based sensors from ABB, currently operated from userspace.

The last patch adds the spidevices to the DTS files, already in mainline.

make dtbs_check showed no errors/warnings for the dts files

[...]

Applied to

Quoted 9 lines

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] dt-bindings: trivial-devices: Document ABB sensors

       commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
       commit: d60f7cab7c04944a79af16caa43c141e780a59c6
Quoted 7 lines

That's unexpected, Mark. Patches received two objections/comments and I don't think discussion was resolved.

ABB is huge company, probably making hundreds or more of sensors. The patchset basically claims that all of them work with spidev. It does not providing any model names or details, so it seems really incomplete to call them trivial devices.

I do not know how many different sensors they have, nor if that department can speak for the whole company...

What I have as information is:
https://lore.kernel.org/linux-spi/[email protected]/

and I get no more information about them currently. May I should add some sort of trivial into compatible name? Something like

"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"

which makes it clearer, that only ABB trivial sensor, controlled through spidev driver, is connected here?

Looking into definiton of "trivial devices" in Documentation/devicetree/bindings/trivial-devices.yaml
"""
description: |
This is a list of trivial I2C and SPI devices that have simple device tree bindings, consisting only of a compatible field, an address and possibly an interrupt line.
"""

which fits exactly, as they even have nothing more than the SPI lines connected to the carrier board(s).

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
#11 lore raw

Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device

Quoted 45 lines · Heiko Schocher

Hello Krzysztof,

Quoted 25 lines · Krzysztof Kozlowski
Quoted 13 lines · Mark Brown
Quoted 9 lines · Heiko Schocher

This series introduces the changes needed for trivial spi based sensors from ABB, currently operated from userspace.

The last patch adds the spidevices to the DTS files, already in mainline.

make dtbs_check showed no errors/warnings for the dts files

[...]

Applied to

Quoted 9 lines

    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] dt-bindings: trivial-devices: Document ABB sensors
       commit: aad2f87cbcab56b322109d26d7b11842a09df91f [2/3] spi: spidev: Add an entry for the ABB spi sensors
       commit: d60f7cab7c04944a79af16caa43c141e780a59c6

Quoted 7 lines

That's unexpected, Mark. Patches received two objections/comments and I don't think discussion was resolved.

ABB is huge company, probably making hundreds or more of sensors. The patchset basically claims that all of them work with spidev. It does not providing any model names or details, so it seems really incomplete to call them trivial devices.

I do not know how many different sensors they have, nor if that department can speak for the whole company...

What I have as information is:
https://lore.kernel.org/linux-spi/[email protected]/

and I get no more information about them currently. May I should add some sort of trivial into compatible name? Something like

Quoted 7 lines

"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"

which makes it clearer, that only ABB trivial sensor, controlled through spidev driver, is connected here?

FWIW, I always thought that devicetree is not supposed to contain such generic information. Is it even appropriate to list something like this in devicetree in the first place ?

If so, what prevents anyone from submitting hundreds of "<company>,spidev-trivial-<device-type>" entries, using the same line of argument ?

Guenter

#12 lore raw

Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device

Quoted 54 lines · On Mon, 21 Jul 2025 21:58:10 -0700 Guenter Roeck <[email protected]> wrote:
Quoted 45 lines · Heiko Schocher

Hello Krzysztof,

Quoted 25 lines · Krzysztof Kozlowski
Quoted 13 lines · Mark Brown
Quoted 9 lines · Heiko Schocher

This series introduces the changes needed for trivial spi based sensors from ABB, currently operated from userspace.

The last patch adds the spidevices to the DTS files, already in mainline.

make dtbs_check showed no errors/warnings for the dts files

[...]

Applied to

Quoted 9 lines

    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] dt-bindings: trivial-devices: Document ABB sensors
       commit: aad2f87cbcab56b322109d26d7b11842a09df91f [2/3] spi: spidev: Add an entry for the ABB spi sensors
       commit: d60f7cab7c04944a79af16caa43c141e780a59c6

Quoted 7 lines

That's unexpected, Mark. Patches received two objections/comments and I don't think discussion was resolved.

ABB is huge company, probably making hundreds or more of sensors. The patchset basically claims that all of them work with spidev. It does not providing any model names or details, so it seems really incomplete to call them trivial devices.

I do not know how many different sensors they have, nor if that department can speak for the whole company...

What I have as information is:
https://lore.kernel.org/linux-spi/[email protected]/

and I get no more information about them currently. May I should add some sort of trivial into compatible name? Something like

Quoted 7 lines

"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"

which makes it clearer, that only ABB trivial sensor, controlled through spidev driver, is connected here?

Quoted 6 lines

FWIW, I always thought that devicetree is not supposed to contain such generic information. Is it even appropriate to list something like this in devicetree in the first place ?

If so, what prevents anyone from submitting hundreds of "<company>,spidev-trivial-<device-type>" entries, using the same line of argument ?

Agreed. These should have separate compatibles based on what any OS etc might want to bind to them. Just because their model in Linux is spidev etc that shouldn't mean a generic ID is appropriate.

Can we at least have some examples to motivate the discussion?

Jonathan

Quoted 3 lines

Guenter

#13 lore raw

Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device

Hello Jonathan,

Quoted 61 lines · Jonathan Cameron
Quoted 58 lines · On Mon, 21 Jul 2025 21:58:10 -0700 Guenter Roeck <[email protected]> wrote:
Quoted 45 lines · Heiko Schocher

Hello Krzysztof,

Quoted 25 lines · Krzysztof Kozlowski
Quoted 13 lines · Mark Brown
Quoted 9 lines · Heiko Schocher

This series introduces the changes needed for trivial spi based sensors from ABB, currently operated from userspace.

The last patch adds the spidevices to the DTS files, already in mainline.

make dtbs_check showed no errors/warnings for the dts files

[...]

Applied to

Quoted 9 lines

    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] dt-bindings: trivial-devices: Document ABB sensors
       commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
       commit: d60f7cab7c04944a79af16caa43c141e780a59c6

Quoted 7 lines

That's unexpected, Mark. Patches received two objections/comments and I don't think discussion was resolved.

ABB is huge company, probably making hundreds or more of sensors. The patchset basically claims that all of them work with spidev. It does not providing any model names or details, so it seems really incomplete to call them trivial devices.

I do not know how many different sensors they have, nor if that department can speak for the whole company...

What I have as information is:
https://lore.kernel.org/linux-spi/[email protected]/

and I get no more information about them currently. May I should add some sort of trivial into compatible name? Something like

Quoted 7 lines

"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"

which makes it clearer, that only ABB trivial sensor, controlled through spidev driver, is connected here?

FWIW, I always thought that devicetree is not supposed to contain such generic information. Is it even appropriate to list something like this in devicetree in the first place ?

Quoted 8 lines
Quoted 2 lines

If so, what prevents anyone from submitting hundreds of "<company>,spidev-trivial-<device-type>" entries, using the same line of argument ?

Agreed. These should have separate compatibles based on what any OS etc might want to bind to them. Just because their model in Linux is spidev etc that shouldn't mean a generic ID is appropriate.

Can we at least have some examples to motivate the discussion?

I am sorry, I get no more information about the sensors... even I do not know the count of variants. What I can say is, that this sensors measure gases, and are only used "internal" on the aristainetos3 carriers.

So a proposal would be:

# ABB gas sensor on aristainetos3 carriers
compatible "abb,aristainetos-gas-sensor"

bye,
Heiko

Quoted 5 lines

Jonathan

Quoted 3 lines

Guenter

Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
#14 lore raw

Re: (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device

In reply to Heiko Schocher
Quoted 31 lines · Heiko Schocher

Hello Krzysztof,

Quoted 28 lines · Krzysztof Kozlowski
Quoted 13 lines · Mark Brown
Quoted 9 lines · Heiko Schocher

This series introduces the changes needed for trivial spi based sensors from ABB, currently operated from userspace.

The last patch adds the spidevices to the DTS files, already in mainline.

make dtbs_check showed no errors/warnings for the dts files

[...]

Applied to

Quoted 9 lines

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] dt-bindings: trivial-devices: Document ABB sensors

       commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
       commit: d60f7cab7c04944a79af16caa43c141e780a59c6

That's unexpected, Mark. Patches received two objections/comments and I don't think discussion was resolved.

Quoted 7 lines
Quoted 4 lines

ABB is huge company, probably making hundreds or more of sensors. The patchset basically claims that all of them work with spidev. It does not providing any model names or details, so it seems really incomplete to call them trivial devices.

I do not know how many different sensors they have, nor if that department can speak for the whole company...

Considering how big company is, they could have 1 or 1000 sensors.

Quoted 10 lines

What I have as information is:
https://lore.kernel.org/linux-spi/[email protected]/

and I get no more information about them currently. May I should add some sort of trivial into compatible name? Something like

"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"

No, you need model numbers.

Quoted 3 lines

which makes it clearer, that only ABB trivial sensor, controlled through spidev driver, is connected here?

No, what is trivial? Which one is trivial and which one is not? How one judges that one sensor should go here and other should not?

Best regards,
Krzysztof