mm-damon-sysfs-remove-damon_sysfs_destroy_targets.patch removed from -mm tree
The quilt patch titled
Subject: mm/damon/sysfs: remove damon_sysfs_destroy_targets()
has been removed from the -mm tree. Its filename was
mm-damon-sysfs-remove-damon_sysfs_destroy_targets.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: SeongJae Park <[email protected]>
Subject: mm/damon/sysfs: remove damon_sysfs_destroy_targets()
Date: Sat, 12 Jul 2025 12:50:13 -0700
The function was introduced for putting pids and deallocating unnecessary targets. Hence it is called before damon_destroy_ctx(). Now vaddr puts pid for each target destruction (cleanup_target()). damon_destroy_ctx() deallocates the targets anyway. So damon_sysfs_destroy_targets() has no reason to exist. Remove it.
---
mm/damon/sysfs.c | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-)
mm/damon/sysfs.c renamed from mm/damon/sysfs.c~mm-damon-sysfs-remove-damon_sysfs_destroy_targets +3 -20
@@ -1295,14 +1295,6 @@ static int damon_sysfs_set_attrs(structreturn damon_set_attrs (ctx, &attrs); } -static void damon_sysfs_destroy_targets (struct damon_ctx *ctx) -{ -struct damon_target *t, *next; - -damon_for_each_target_safe (t, next, ctx) -damon_destroy_target (t, ctx); -} -static int damon_sysfs_set_regions (struct damon_target *t,struct damon_sysfs_regions *sysfs_regions) {
@@ -1337,7 +1329,6 @@ static int damon_sysfs_add_target(struct struct damon_ctx *ctx) {struct damon_target *t =damon_new_target (); -int err = -EINVAL ;if (!t)return -ENOMEM ;
@@ -1345,16 +1336,10 @@ static int damon_sysfs_add_target(structif (damon_target_has_pid (ctx)) { t->pid =find_get_pid (sys_target->pid);if (!t->pid) - goto destroy_targets_out; +/* caller will destroy targets */ +return -EINVAL ; } - err =damon_sysfs_set_regions (t, sys_target->regions); -if (err) - goto destroy_targets_out; -return 0 ; - -destroy_targets_out: -damon_sysfs_destroy_targets (ctx); -return err; +return damon_sysfs_set_regions (t, sys_target->regions); } static int damon_sysfs_add_targets(struct damon_ctx *ctx,
@@ -1458,13 +1443,11 @@ static int damon_sysfs_commit_input(void test_ctx =damon_new_ctx (); err =damon_commit_ctx (test_ctx, param_ctx);if (err) { -damon_sysfs_destroy_targets (test_ctx);damon_destroy_ctx (test_ctx); goto out; } err =damon_commit_ctx (kdamond->damon_ctx, param_ctx); out: -damon_sysfs_destroy_targets (param_ctx);damon_destroy_ctx (param_ctx);return err; }
_
Patches currently in -mm which might be from [email protected] are
mm-damon-core-commit-damos_quota_goal-nid.patch mm-damon-sysfs-implement-refresh_ms-file-under-kdamond-directory.patch mm-damon-sysfs-implement-refresh_ms-file-internal-work.patch docs-admin-guide-mm-damon-usage-document-refresh_ms-file.patch docs-abi-damon-update-for-refresh_ms.patch