perf tests: Fix lib path detection for non-x86 architectures
PATCH 1/1 perf tests: Fix lib path detection for non-x86 architectures
The existing Makefile logic for determining library paths was hardcoded for x86 architectures, causing incorrect behavior on other platforms. This patch implements a portable solution using system bit detection.
--- tools/perf/tests/make | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
tools/perf/tests/make +6 -3
@@ -53,9 +53,12 @@ endif include $(srctree)/tools/scripts/Makefile.arch -# FIXME looks like x86 is the only arch running tests ;-) -# we need some IS_(32/64) flag to make this generic -ifeq ($(ARCH)$(IS_64_BIT), x861) +BITS := $(shell getconf LONG_BIT) +IS_64_BIT ?= 1 +ifeq ($(BITS), 32) +IS_64_BIT = 0 +endif +ifeq ($(IS_64_BIT), 1) lib = lib64 else lib = lib
Signature · 1 line
2.50.1
Namhyung Kim
maintainerQuoted 20 lines · Suchit Karunakaran
The existing
Makefilelogic for determining library paths was hardcoded for x86 architectures, causing incorrect behavior on other platforms. This patch implements a portable solution using system bit detection.Signed-off-by Suchit Karunakaran <[email protected]>--- tools/perf/tests/make | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)tools/perf/tests/make +0
-2@@ -53,9 +53,12 @@ endif include $(srctree)/tools/scripts/Makefile.arch -# FIXME looks like x86 is the only arch running tests ;-) -# we need some IS_(32/64) flag to make this generic
tools/perf/tests/make endif · line 64
Quoted 10 lines
tools/perf/tests/make +6
-1-ifeq ($(ARCH)$(IS_64_BIT), x861) +BITS := $(shell getconf LONG_BIT) +IS_64_BIT ?= 1 +ifeq ($(BITS), 32) +IS_64_BIT = 0 +endif +ifeq ($(IS_64_BIT), 1) lib = lib64 else lib = lib
A dummy question: Does all other architectures have lib64 vs lib separation?
Thanks,
Namhyung
Quoted 3 lines
Signature · 1 line
2.50.1
Quoted 4 lines
A dummy question: Does all other architectures have lib64 vs lib separation?
I had assumed there would always be symlinks, but thanks for pointing that out. After your question, I checked various architectures like x86, ARM, SPARC, s390x, etc and only x86 had both lib and lib64 (with symlinks). On the others, even for 64-bit systems, only a lib directory existed. I also realized this behavior seems to depend on the distro. For example, multiarch distros like Debian use separate directories for lib32 and lib64, and a lib symlink pointing to /usr/lib. On the other hand, Arch Linux has both lib and lib64 as symlinks to /usr/lib. Would it be reasonable if we create a symlink named lib64 for non-x86 architectures? I'd appreciate your thoughts on this. Thanks!
Namhyung Kim
maintainerQuoted 5 lines · Suchit K
Quoted 4 lines
A dummy question: Does all other architectures have lib64 vs lib separation?
Quoted 11 lines
I had assumed there would always be symlinks, but thanks for pointing that out. After your question, I checked various architectures like x86, ARM, SPARC, s390x, etc and only x86 had both lib and lib64 (with symlinks). On the others, even for 64-bit systems, only a lib directory existed. I also realized this behavior seems to depend on the distro. For example, multiarch distros like Debian use separate directories for lib32 and lib64, and a lib symlink pointing to
/usr/lib. On the other hand, Arch Linux has both lib and lib64 as symlinks to/usr/lib. Would it be reasonable if we create a symlink named lib64 for non-x86 architectures? I'd appreciate your thoughts on this. Thanks!
I'd be intrusive if we create a new symlink. Probably we need to check if there's lib64 directory first and use it for 64 bit build. But I feel like this needs more testing.
Can you share what's the problem exactly?
Thanks,
Namhyung
Quoted 10 lines
I'd be intrusive if we create a new symlink. Probably we need to check if there's lib64 directory first and use it for 64 bit build. But I feel like this needs more testing.
Can you share what's the problem exactly?
Thanks,
Namhyung
Yeah I agree it needs more testing. And yes we can check if the lib64 folder exists and then create a symlink. If there's no lib64 folder, we can create a symlink named lib64 to the lib folder. I assume this will cover most of the architectures since the lib folder existed in almost all the architectures that I tested.