Skip to contentSkip to conversation

crypto: keembay - Use min() to simplify ocs_create_linked_list_from_sg()

PATCH In review Thorsten Blum 2 participants 2 messages Jul 20, 2025 – Jul 27, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: keembay - Use min() to simplify ocs_create_linked_list_from_sg()

Use min() to simplify ocs_create_linked_list_from_sg() and improve its readability.

---
 drivers/crypto/intel/keembay/ocs-aes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/intel/keembay/ocs-aes.c +2 -2
index be9f32fc8f42..b69e7bfce9cc 100644
@@ -7,6 +7,7 @@
 
 #include <linux/dma-mapping.h>
 #include <linux/interrupt.h>
+#include <linux/minmax.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/swab.h>
@@ -1473,8 +1474,7 @@ int ocs_create_linked_list_from_sg(const struct ocs_aes_dev *aes_dev,
 	ll = dll_desc->vaddr;
 	for (i = 0; i < dma_nents; i++, sg = sg_next(sg)) {
 		ll[i].src_addr = sg_dma_address(sg) + data_offset;
-		ll[i].src_len = (sg_dma_len(sg) - data_offset) < data_size ?
-				(sg_dma_len(sg) - data_offset) : data_size;
+		ll[i].src_len = min(sg_dma_len(sg) - data_offset, data_size);
 		data_offset = 0;
 		data_size -= ll[i].src_len;
 		/* Current element points to the DMA address of the next one. */
Signature · 1 line
2.50.1
maintainer
#1 lore raw
Quoted 7 lines · Thorsten Blum

Use min() to simplify ocs_create_linked_list_from_sg() and improve its readability.

---
 drivers/crypto/intel/keembay/ocs-aes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt