soc: fsl: qe: convert set_multiple() to returning an integer
Subsystems (3)
PATCH 1/1 soc: fsl: qe: convert set_multiple() to returning an integer
From: Bartosz Golaszewski <[email protected]>
The conversion to using the new GPIO line setter callbacks missed the set_multiple() in this file. Convert it to using the new callback.
---
This is a follow-up to commit 52ccf19527fd ("soc: fsl: qe: use new GPIO line value setter callbacks") in which I did not convert the second GPIO callback. Could you please apply it on top of Christophe's pull-request[1] and queue it for v6.17?
[1] https://patchwork.kernel.org/project/linux-soc/patch/[email protected]/
drivers/soc/fsl/qe/gpio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/soc/fsl/qe/gpio.c +5 -3
@@ -79,8 +79,8 @@ static int qe_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)return 0 ; } -static void qe_gpio_set_multiple (struct gpio_chip *gc, -unsigned long *mask,unsigned long *bits) +static int qe_gpio_set_multiple (struct gpio_chip *gc, +unsigned long *mask,unsigned long *bits) {struct of_mm_gpio_chip *mm_gc =to_of_mm_gpio_chip (gc);struct qe_gpio_chip *qe_gc =gpiochip_get_data (gc);
@@ -104,6 +104,8 @@ static void qe_gpio_set_multiple(struct gpio_chip *gc,iowrite32be (qe_gc->cpdata, ®s->cpdata);spin_unlock_irqrestore (&qe_gc->lock, flags); + +return 0 ; }static int qe_gpio_dir_in (struct gpio_chip *gc,unsigned int gpio)
@@ -320,7 +322,7 @@ static int __init qe_add_gpiochips(void) gc->direction_output = qe_gpio_dir_out; gc->get = qe_gpio_get; gc->set_rv = qe_gpio_set; - gc->set_multiple = qe_gpio_set_multiple; + gc->set_multiple_rv = qe_gpio_set_multiple; ret =of_mm_gpiochip_add_data (np, mm_gc, qe_gc);if (ret)
Signature · 1 line
2.48.1
Christophe Leroy
AppliedQuoted 4 lines · Bartosz Golaszewski
The conversion to using the new GPIO line setter callbacks missed the
set_multiple()in this file. Convert it to using the new callback.
Applied, thanks!
[1/1] soc: fsl: qe: convert set_multiple() to returning an integer
(no commit info)
Best regards,
Signature · 1 line
Christophe Leroy <[email protected]>