ACPI: pci_link: Remove space before \n newline
Subsystems (4)
PATCH 1/1 ACPI: pci_link: Remove space before \n newline
There is an extraneous space before a newline in an acpi_handle_debug message. Remove it.
--- drivers/acpi/pci_link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/pci_link.c +1 -1
@@ -268,7 +268,7 @@ static int acpi_pci_link_get_current(struct acpi_pci_link *link) link->irq.active = irq; -acpi_handle_debug (handle,"Link at IRQ %d \n" , link->irq.active); +acpi_handle_debug (handle,"Link at IRQ %d\n" , link->irq.active); end:return result;
Signature · 1 line
2.50.0
Quoted 4 lines · Colin Ian King
There is an extraneous space before a newline in an
acpi_handle_debugmessage. Remove it.Signed-off-by Colin Ian King <[email protected]>
FWIW,
Fixes for more ACPI-related typos below, feel free to squash or I can send separately.
Quoted 9 lines
--- drivers/acpi/pci_link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/pci_link.c +0
-0
drivers/acpi/pci_link.c static int acpi_pci_link_get_current(struct acpi_pci_link *link) · line 274
Quoted 8 lines
drivers/acpi/pci_link.c +1
-1@@ -268,7 +268,7 @@ static int acpi_pci_link_get_current(struct acpi_pci_link *link) link->irq.active = irq; -acpi_handle_debug (handle,"Link at IRQ %d \n" , link->irq.active); +acpi_handle_debug (handle,"Link at IRQ %d\n" , link->irq.active); end:return result;
Documentation/ABI/testing/sysfs-firmware-acpi +3 -3
@@ -108,15 +108,15 @@ Description: number of a "General Purpose Events" (GPE). A GPE vectors to a specified handler in AML, which - can do a anything the BIOS writer wants from + can do anything the BIOS writer wants from OS context. GPE 0x12, for example, would vector to a level or edge handler called _L12 or _E12. The handler may do its business and return. - Or the handler may send send a Notify event + Or the handler may send a Notify event to a Linux device driver registered on an ACPI device, such as a battery, or a processor. - To figure out where all the SCI's are coming from, + To figure out where all the SCIs are coming from, /sys/firmware/acpi/interrupts contains a file listing every possible source, and the count of how many times it has triggered::
Documentation/firmware-guide/acpi/gpio-properties.rst +2 -2
@@ -92,8 +92,8 @@ and polarity settings. The table below shows the expectations: | | Low | as low, assuming active | +-------------+-------------+-----------------------------------------------+ -That said, for our above example the both GPIOs, since the bias setting -is explicit and _DSD is present, will be treated as active with a high +That said, for our above example, since the bias setting is explicit and +_DSD is present, both GPIOs will be treated as active with a high polarity and Linux will configure the pins in this state until a driver reprograms them differently.
drivers/acpi/bus.c +1 -1
@@ -1406,7 +1406,7 @@ static int __init acpi_bus_init(void) goto error1;/* -* Register the for all standard device notifications. +* Register for all standard device notifications. */ status = acpi_install_notify_handler(ACPI_ROOT_OBJECT, ACPI_SYSTEM_NOTIFY,
Rafael J. Wysocki
maintainerQuoted 5 lines · Bjorn Helgaas
Quoted 3 lines · Colin Ian King
There is an extraneous space before a newline in an
acpi_handle_debugmessage. Remove it.
Quoted 8 lines
Quoted 1 line
Signed-off-by Colin Ian King <[email protected]>FWIW,
Acked-by Bjorn Helgaas <[email protected]>Fixes for more ACPI-related typos below, feel free to squash or I can send separately.
If I can assume your sign-off on this, no need to resend.
Quoted 69 lines
Quoted 17 lines
--- drivers/acpi/pci_link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/pci_link.c +1
-1@@ -268,7 +268,7 @@ static int acpi_pci_link_get_current(struct acpi_pci_link *link) link->irq.active = irq; -acpi_handle_debug (handle,"Link at IRQ %d \n" , link->irq.active); +acpi_handle_debug (handle,"Link at IRQ %d\n" , link->irq.active); end:return result;Documentation/ABI/testing/sysfs-firmware-acpi +3
-3@@ -108,15 +108,15 @@ Description: number of a "General Purpose Events" (GPE). A GPE vectors to a specified handler in AML, which - can do a anything the BIOS writer wants from + can do anything the BIOS writer wants from OS context. GPE 0x12, for example, would vector to a level or edge handler called _L12 or _E12. The handler may do its business and return. - Or the handler may send send a Notify event + Or the handler may send a Notify event to a Linux device driver registered on an ACPI device, such as a battery, or a processor. - To figure out where all the SCI's are coming from, + To figure out where all the SCIs are coming from, /sys/firmware/acpi/interrupts contains a file listing every possible source, and the count of how many times it has triggered::Documentation/firmware-guide/acpi/gpio-properties.rst +2
-2@@ -92,8 +92,8 @@ and polarity settings. The table below shows the expectations: | | Low | as low, assuming active | +-------------+-------------+-----------------------------------------------+ -That said, for our above example the both GPIOs, since the bias setting -is explicit and _DSD is present, will be treated as active with a high +That said, for our above example, since the bias setting is explicit and +_DSD is present, both GPIOs will be treated as active with a high polarity and Linux will configure the pins in this state until a driver reprograms them differently.drivers/acpi/bus.c +1
-1@@ -1406,7 +1406,7 @@ static int __init acpi_bus_init(void) goto error1;/* -* Register the for all standard device notifications. +* Register for all standard device notifications. */ status = acpi_install_notify_handler(ACPI_ROOT_OBJECT, ACPI_SYSTEM_NOTIFY,
Quoted 7 lines · Rafael J. Wysocki
On Mon, Jul 21, 2025 at 11:40 PM Bjorn Helgaas <[email protected]> wrote:
...Quoted 3 lines
Fixes for more ACPI-related typos below, feel free to squash or I can send separately.
If I can assume your sign-off on this, no need to resend.
Of course, sorry, my fault:
commit 9cdbf361a40d ("ACPI: Fix typos")
Author: Bjorn Helgaas <[email protected]> Date: Mon Jul 21 16:37:14 2025 -0500
ACPI: Fix typos
Fix typos in documentation and comments.
Documentation/ABI/testing/sysfs-firmware-acpi +3 -3
@@ -108,15 +108,15 @@ Description: number of a "General Purpose Events" (GPE). A GPE vectors to a specified handler in AML, which - can do a anything the BIOS writer wants from + can do anything the BIOS writer wants from OS context. GPE 0x12, for example, would vector to a level or edge handler called _L12 or _E12. The handler may do its business and return. - Or the handler may send send a Notify event + Or the handler may send a Notify event to a Linux device driver registered on an ACPI device, such as a battery, or a processor. - To figure out where all the SCI's are coming from, + To figure out where all the SCIs are coming from, /sys/firmware/acpi/interrupts contains a file listing every possible source, and the count of how many times it has triggered::
Documentation/firmware-guide/acpi/gpio-properties.rst +2 -2
@@ -92,8 +92,8 @@ and polarity settings. The table below shows the expectations: | | Low | as low, assuming active | +-------------+-------------+-----------------------------------------------+ -That said, for our above example the both GPIOs, since the bias setting -is explicit and _DSD is present, will be treated as active with a high +That said, for our above example, since the bias setting is explicit and +_DSD is present, both GPIOs will be treated as active with a high polarity and Linux will configure the pins in this state until a driver reprograms them differently.
drivers/acpi/bus.c +1 -1
@@ -1406,7 +1406,7 @@ static int __init acpi_bus_init(void) goto error1;/* -* Register the for all standard device notifications. +* Register for all standard device notifications. */ status = acpi_install_notify_handler(ACPI_ROOT_OBJECT, ACPI_SYSTEM_NOTIFY,
Quoted 11 lines · Bjorn Helgaas
Quoted 7 lines · Rafael J. Wysocki
On Mon, Jul 21, 2025 at 11:40 PM Bjorn Helgaas <[email protected]> wrote:
...Quoted 3 lines
Fixes for more ACPI-related typos below, feel free to squash or I can send separately.
If I can assume your sign-off on this, no need to resend.
Of course, sorry, my fault:
No worries.
Quoted 54 lines
commit
9cdbf361a40d("ACPI: Fix typos")Author: Bjorn Helgaas <[email protected]> Date: Mon Jul 21 16:37:14 2025 -0500ACPI: Fix typos
Fix typos in documentation and comments.
Signed-off-by Bjorn Helgaas <[email protected]>Documentation/ABI/testing/sysfs-firmware-acpi +3
-3@@ -108,15 +108,15 @@ Description: number of a "General Purpose Events" (GPE). A GPE vectors to a specified handler in AML, which - can do a anything the BIOS writer wants from + can do anything the BIOS writer wants from OS context. GPE 0x12, for example, would vector to a level or edge handler called _L12 or _E12. The handler may do its business and return. - Or the handler may send send a Notify event + Or the handler may send a Notify event to a Linux device driver registered on an ACPI device, such as a battery, or a processor. - To figure out where all the SCI's are coming from, + To figure out where all the SCIs are coming from, /sys/firmware/acpi/interrupts contains a file listing every possible source, and the count of how many times it has triggered::Documentation/firmware-guide/acpi/gpio-properties.rst +2
-2@@ -92,8 +92,8 @@ and polarity settings. The table below shows the expectations: | | Low | as low, assuming active | +-------------+-------------+-----------------------------------------------+ -That said, for our above example the both GPIOs, since the bias setting -is explicit and _DSD is present, will be treated as active with a high +That said, for our above example, since the bias setting is explicit and +_DSD is present, both GPIOs will be treated as active with a high polarity and Linux will configure the pins in this state until a driver reprograms them differently.drivers/acpi/bus.c +0
-0
drivers/acpi/bus.c static int __init acpi_bus_init(void) · line 1412
Quoted 8 lines
drivers/acpi/bus.c +1
-1@@ -1406,7 +1406,7 @@ static int __init acpi_bus_init(void) goto error1;/* -* Register the for all standard device notifications. +* Register for all standard device notifications. */ status = acpi_install_notify_handler(ACPI_ROOT_OBJECT, ACPI_SYSTEM_NOTIFY,
Applied, thanks!