ARM: dts: am33xx-l4: fix UART compatible
Subsystems (2)
PATCH 1/1 ARM: dts: am33xx-l4: fix UART compatible
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long 'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
--- arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +6 -6
@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x9000 0x1000>; uart0: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <72>;
@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x22000 0x1000>; uart1: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <73>;
@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x24000 0x1000>; uart2: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <74>;
@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa6000 0x1000>; uart3: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <44>;
@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa8000 0x1000>; uart4: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <45>;
@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xaa000 0x1000>; uart5: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <46>;
base-commit: 89be9a83ccf1f88522317ce02f854f30d6115c41
Signature · 1 line
2.50.1
Hi Bruno,
Quoted 9 lines · Bruno Thomsen
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long 'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#Signed-off-by Bruno Thomsen <[email protected]>
Thanks for the patch, I think you forgot to add Kevin Hilman to this email, but other than that LGTM.
Quoted 64 lines
--- arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +6
-6@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x9000 0x1000>; uart0: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <72>;@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x22000 0x1000>; uart1: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <73>;@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x24000 0x1000>; uart2: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <74>;@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa6000 0x1000>; uart3: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <44>;@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa8000 0x1000>; uart4: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <45>;@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xaa000 0x1000>; uart5: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <46>;base-commit:
89be9a83ccf1f88522317ce02f854f30d6115c41
Quoted 9 lines · Bruno Thomsen
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long 'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#[...]
Applied, thanks!
[1/1] ARM: dts: am33xx-l4: fix UART compatible
commit: ca8be8fc2c306efb090791835acfb5b33542ca1d
Best regards,
Signature · 1 line
Kevin Hilman <[email protected]>
Hi Bruno,
Quoted 9 lines · Bruno Thomsen
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long 'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#Signed-off-by Bruno Thomsen <[email protected]>
Thanks for your patch, which is now commit ca8be8fc2c306efb ("ARM:
dts: am33xx-l4: fix UART compatible") in soc/for-next.
This commit broke the serial console on BeagleBone Black. Upon closer look, my .config had CONFIG_SERIAL_OMAP (for "ti,omap3-uart") enabled instead of CONFIG_SERIAL_8250_OMAP (for "ti,am3352-uart"). However, replacing CONFIG_SERIAL_OMAP by CONFIG_SERIAL_8250_OMAP does not help: the serial driver now probes, but I still get no output nor a login prompt.
The same issue is present when using omap2plus_defconfig, which has both serial options enabled.
Quoted 48 lines
arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +5
-5@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x9000 0x1000>; uart0: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <72>;@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x22000 0x1000>; uart1: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <73>;@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x24000 0x1000>; uart2: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <74>;@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa6000 0x1000>; uart3: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <44>;@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa8000 0x1000>; uart4: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <45>;
arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi SYSC_OMAP2_SOFTRESET | · line 1834
Quoted 8 lines
arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +1
-1@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xaa000 0x1000>; uart5: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <46>;
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert,
Den tirs. 30. sep. 2025 kl. 19.08 skrev Geert Uytterhoeven <[email protected]>:
Quoted 17 lines
Hi Bruno,
Quoted 9 lines · Bruno Thomsen
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long 'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#Signed-off-by Bruno Thomsen <[email protected]>Thanks for your patch, which is now commit
ca8be8fc2c306efb("ARM:
dts: am33xx-l4: fix UART compatible") in soc/for-next.
Quoted 6 lines
This commit broke the serial console on BeagleBone Black. Upon closer look, my .config had
CONFIG_SERIAL_OMAP(for "ti,omap3-uart") enabled instead ofCONFIG_SERIAL_8250_OMAP(for "ti,am3352-uart"). However, replacingCONFIG_SERIAL_OMAPbyCONFIG_SERIAL_8250_OMAPdoes not help: the serial driver now probes, but I still get no output nor a login prompt.
You properly need to enable CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP if using an existing console= kernel argument from the bootloader as UARTs will change to ttyS from ttyO.
Switching the UART driver on am33xx based products fixed UART issues we were seeing in our CD test pipelines.
Quoted 2 lines
The same issue is present when using
omap2plus_defconfig, which has both serial options enabled.
I did not check if any defconfigs needed to be updated.
The below kernel configuration snippet is known to work on a product with similar design to the BeagleBone Black.
----------------------8<-------------------
CONFIG_SERIAL_EARLYCON=y CONFIG_SERIAL_8250=y
# CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set # CONFIG_SERIAL_8250_16550A_VARIANTS is not set # CONFIG_SERIAL_8250_FINTEK is not set CONFIG_SERIAL_8250_CONSOLE=y
# CONFIG_SERIAL_8250_DMA is not set CONFIG_SERIAL_8250_NR_UARTS=6 CONFIG_SERIAL_8250_RUNTIME_UARTS=6
# CONFIG_SERIAL_8250_EXTENDED is not set CONFIG_SERIAL_8250_FSL=y
# CONFIG_SERIAL_8250_DW is not set
# CONFIG_SERIAL_8250_RT288X is not set CONFIG_SERIAL_8250_OMAP=y CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP=y CONFIG_SERIAL_OF_PLATFORM=y
----------------------8<-------------------
/Bruno
Quoted 68 lines
Quoted 49 lines
arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +5
-5@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x9000 0x1000>; uart0: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <72>;@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x22000 0x1000>; uart1: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <73>;@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x24000 0x1000>; uart2: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <74>;@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa6000 0x1000>; uart3: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <44>;@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa8000 0x1000>; uart4: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <45>;arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi SYSC_OMAP2_SOFTRESET | · line 1834
Quoted 8 lines
arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +1
-1@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xaa000 0x1000>; uart5: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <46>;Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Bruno,
Quoted 23 lines · Bruno Thomsen
Den tirs. 30. sep. 2025 kl. 19.08 skrev Geert Uytterhoeven <[email protected]>:
Quoted 14 lines · Bruno Thomsen
Quoted 9 lines
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long 'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#Signed-off-by Bruno Thomsen <[email protected]>Thanks for your patch, which is now commit
ca8be8fc2c306efb("ARM:
dts: am33xx-l4: fix UART compatible") in soc/for-next.Quoted 6 lines
This commit broke the serial console on BeagleBone Black. Upon closer look, my .config had
CONFIG_SERIAL_OMAP(for "ti,omap3-uart") enabled instead ofCONFIG_SERIAL_8250_OMAP(for "ti,am3352-uart"). However, replacingCONFIG_SERIAL_OMAPbyCONFIG_SERIAL_8250_OMAPdoes not help: the serial driver now probes, but I still get no output nor a login prompt.
Quoted 3 lines
You properly need to enable
CONFIG_SERIAL_8250_OMAP_TTYO_FIXUPif using an existing console= kernel argument from the bootloader as UARTs will change to ttyS from ttyO.
I did notice that option, and thought it wouldn't hurt to enable it. Still, I do not use console=, as I rely on chosen/stdout-path.
Quoted 2 lines
Switching the UART driver on am33xx based products fixed UART issues we were seeing in our CD test pipelines.
I have found the issue: in the absence of a (legacy) console= parameter, the serial console reles on the driver's default speed, which is 115200 bps (good) for omap-serial, but 9600 bps (bad) for 8250 serial. I have submitted a fix "[PATCH] ARM: dts: am33xx: Add missing serial console speed"[1].
Quoted 2 lines
Quoted 2 lines
The same issue is present when using
omap2plus_defconfig, which has both serial options enabled.
Correction: CONFIG_SERIAL_OMAP is no longer enabled in the defconfig (and IIRC, I had noticed before the serial console was broken with
that config, but didn't bother, as my config still worked ;-)
Quoted 1 line
I did not check if any defconfigs needed to be updated.
After my patch, omap2plus_defconfig works again, too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
DT compatibility break for am335x (Was: Re: [PATCH] ARM: dts: am33xx-l4: fix UART compatible)
In reply to Bruno ThomsenHello Bruno,
Quoted 9 lines · Bruno Thomsen
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long 'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#Signed-off-by Bruno Thomsen <[email protected]>
I tripped over this patch, because it broke the console in barebox after the device tree sync with Linux v6.18-rc1, fortunately caught before release.
I believe the correct resolution for the DT binding warning would have been to extend the compatible list in the binding with ti,omap3-uart if they are indeed compatible.
I have submitted a patch to add the now sole compatible to the barebox driver[1], but please keep DT compatibility in mind with similar changes in future.
[1]: https://lore.kernel.org/barebox/[email protected]/T/#u
Thanks,
Ahmad
Quoted 64 lines
--- arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +6
-6@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x9000 0x1000>; uart0: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <72>;@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x22000 0x1000>; uart1: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <73>;@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x24000 0x1000>; uart2: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <74>;@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa6000 0x1000>; uart3: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <44>;@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa8000 0x1000>; uart4: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <45>;@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xaa000 0x1000>; uart5: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <46>;base-commit:
89be9a83ccf1f88522317ce02f854f30d6115c41
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Re: DT compatibility break for am335x (Was: Re: [PATCH] ARM: dts: am33xx-l4: fix UART compatible)
Hi Ahmad,
Den fre. 7. nov. 2025 kl. 19.47 skrev Ahmad Fatoum <[email protected]>:
Quoted 12 lines
Hello Bruno,
Quoted 8 lines · Bruno Thomsen
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long
'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
Quoted 4 lines
Quoted 1 line
Signed-off-by Bruno Thomsen <[email protected]>I tripped over this patch, because it broke the console in barebox after the device tree sync with Linux v6.18-rc1, fortunately caught before release.
Sorry to have caused you issues in barebox, that was not my intention.
Quoted 4 lines
I believe the correct resolution for the DT binding warning would have been to extend the compatible list in the binding with ti,omap3-uart if they are indeed compatible.
I can see that I forgot to include the full reason for the change in the commit message. We have some products based on ti,am33xx soc and the serial the console had many quirks when using the ti,omap3-uart that we did not see on other soc families. The console did not like opening vi or htop but could only handle simple kernel log. Switching to ti,am3352-uart fixed these issues, so that was why I changed the device trees and not the schema.
Quoted 3 lines
I have submitted a patch to add the now sole compatible to the barebox driver[1], but please keep DT compatibility in mind with similar changes in future.
Thank you for maintaining barebox. On our new platforms we only use barebox as a bootloader as it provides a much easier board boot then u-boot.
/Bruno
Quoted 78 lines
[1]: https://lore.kernel.org/barebox/[email protected]/T/#u
Thanks,
AhmadQuoted 63 lines
--- arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +6
-6@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x9000 0x1000>; uart0: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <72>;@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x22000 0x1000>; uart1: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <73>;@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x24000 0x1000>; uart2: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <74>;@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa6000 0x1000>; uart3: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <44>;@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa8000 0x1000>; uart4: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <45>;@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xaa000 0x1000>; uart5: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <46>;Quoted 1 line
base-commit:
89be9a83ccf1f88522317ce02f854f30d6115c41--
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Re: DT compatibility break for am335x (Was: Re: [PATCH] ARM: dts: am33xx-l4: fix UART compatible)
Hello Bruno,
Quoted 27 lines · Bruno Thomsen
Hi Ahmad,
Den fre. 7. nov. 2025 kl. 19.47 skrev Ahmad Fatoum <[email protected]>:
Quoted 12 lines
Hello Bruno,
Quoted 8 lines · Bruno Thomsen
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long
'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#Quoted 4 lines
Quoted 1 line
Signed-off-by Bruno Thomsen <[email protected]>I tripped over this patch, because it broke the console in barebox after the device tree sync with Linux v6.18-rc1, fortunately caught before release.
Sorry to have caused you issues in barebox, that was not my intention.
Quoted 4 lines
I believe the correct resolution for the DT binding warning would have been to extend the compatible list in the binding with ti,omap3-uart if they are indeed compatible.
Quoted 6 lines
I can see that I forgot to include the full reason for the change in the commit message. We have some products based on ti,am33xx soc and the serial the console had many quirks when using the ti,omap3-uart that we did not see on other soc families. The console did not like opening vi or htop but could only handle simple kernel log. Switching to ti,am3352-uart fixed these issues, so that was why I changed the device trees and not the schema.
Couldn't the same result have been achieved by disabling CONFIG_SERIAL_OMAP? The driver match logic should already have preferred the more specific compatible, so the problem is that two drivers are matching against the same compatible, right?
Quoted 5 lines
Quoted 2 lines
I have submitted a patch to add the now sole compatible to the barebox driver[1], but please keep DT compatibility in mind with similar changes in future.
Thank you for maintaining barebox. On our new platforms we only use barebox as a bootloader as it provides a much easier board boot then u-boot.
Happy to hear. :-)
Cheers,
Ahmad
Quoted 82 lines
/Bruno
Quoted 78 lines
[1]: https://lore.kernel.org/barebox/[email protected]/T/#u
Thanks,
AhmadQuoted 63 lines
--- arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +6
-6@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x9000 0x1000>; uart0: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <72>;@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x22000 0x1000>; uart1: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <73>;@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x24000 0x1000>; uart2: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <74>;@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa6000 0x1000>; uart3: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <44>;@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa8000 0x1000>; uart4: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <45>;@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xaa000 0x1000>; uart5: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <46>;Quoted 1 line
base-commit:
89be9a83ccf1f88522317ce02f854f30d6115c41--
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: DT compatibility break for am335x (Was: Re: [PATCH] ARM: dts: am33xx-l4: fix UART compatible)
Hi Ahmad,
Den ons. 26. nov. 2025 kl. 13.43 skrev Ahmad Fatoum <[email protected]>:
Quoted 38 lines
Hello Bruno,
Quoted 27 lines · Bruno Thomsen
Hi Ahmad,
Den fre. 7. nov. 2025 kl. 19.47 skrev Ahmad Fatoum <[email protected]>:
Quoted 12 lines
Hello Bruno,
Quoted 8 lines · Bruno Thomsen
Fixes the following dtschema check warning:
serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
['ti,am3352-uart', 'ti,omap3-uart'] is too long
'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart'] 'ti,am654-uart' was expected
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#Quoted 4 lines
Quoted 1 line
Signed-off-by Bruno Thomsen <[email protected]>I tripped over this patch, because it broke the console in barebox after the device tree sync with Linux v6.18-rc1, fortunately caught before release.
Sorry to have caused you issues in barebox, that was not my intention.
Quoted 4 lines
I believe the correct resolution for the DT binding warning would have been to extend the compatible list in the binding with ti,omap3-uart if they are indeed compatible.
Quoted 6 lines
I can see that I forgot to include the full reason for the change in the commit message. We have some products based on ti,am33xx soc and the serial the console had many quirks when using the ti,omap3-uart that we did not see on other soc families. The console did not like opening vi or htop but could only handle simple kernel log. Switching to ti,am3352-uart fixed these issues, so that was why I changed the device trees and not the schema.
Quoted 4 lines
Couldn't the same result have been achieved by disabling
CONFIG_SERIAL_OMAP? The driver match logic should already have preferred the more specific compatible, so the problem is that two drivers are matching against the same compatible, right?
Yes, that would have given the same result. I chose to fix the DT schema warning as I'm preparing a few boards (2 existing + 1 new) for upstreaming. But looking at
DT schema check was not pretty for an am335x based DT :)
/Bruno
Quoted 102 lines
Quoted 6 lines
Quoted 3 lines
I have submitted a patch to add the now sole compatible to the barebox driver[1], but please keep DT compatibility in mind with similar changes in future.
Thank you for maintaining barebox. On our new platforms we only use barebox as a bootloader as it provides a much easier board boot then u-boot.
Happy to hear. :-)
Cheers,
AhmadQuoted 82 lines
/Bruno
Quoted 78 lines
[1]: https://lore.kernel.org/barebox/[email protected]/T/#u
Thanks,
AhmadQuoted 63 lines
--- arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi +6
-6@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x9000 0x1000>; uart0: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <72>;@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x22000 0x1000>; uart1: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <73>;@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0x24000 0x1000>; uart2: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <74>;@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa6000 0x1000>; uart3: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <44>;@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xa8000 0x1000>; uart4: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <45>;@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET | ranges = <0x0 0xaa000 0x1000>; uart5: serial@0 { - compatible = "ti,am3352-uart", "ti,omap3-uart"; + compatible = "ti,am3352-uart"; clock-frequency = <48000000>; reg = <0x0 0x1000>; interrupts = <46>;Quoted 1 line
base-commit:
89be9a83ccf1f88522317ce02f854f30d6115c41--
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |--
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |