selftests/damon/sysfs.py: stop DAMON for dumping failures
Subsystems (3)
SeongJae Park
maintainerPATCH 1/1 selftests/damon/sysfs.py: stop DAMON for dumping failures
Commit 4ece01897627 ("selftests/damon: add python and drgn-based DAMON sysfs test") in mm-stable tree introduced sysfs.py that runs drgn for dumping DAMON status. When the DAMON status dumping fails for reasons including drgn uninstalled environment, the test fails without stopping DAMON. Following DAMON selftests that assumes DAMON is not running when they executed therefore fail. Catch dumping failures and stop DAMON for that case.
Fixes 4ece01897627 ("selftests/damon: add python and drgn-based DAMON sysfs test") # mm-stable
Reported-by kernel test robot <[email protected]>
Signed-off-by SeongJae Park <[email protected]>
--- tools/testing/selftests/damon/sysfs.py | 5 +++++ 1 file changed, 5 insertions(+)
tools/testing/selftests/damon/sysfs.py +5 -0
@@ -8,6 +8,10 @@ import subprocess import _damon_sysfs def dump_damon_status_dict(pid): + try: + subprocess.check_output(['which', 'drgn'], stderr=subprocess.DEVNULL) + except: + return None, 'drgn not found' file_dir = os.path.dirname(os.path.abspath(__file__)) dump_script = os.path.join(file_dir, 'drgn_dump_damon_status.py') rc = subprocess.call(['drgn', dump_script, pid, 'damon_dump_output'],
@@ -31,6 +35,7 @@ def main(): status, err = dump_damon_status_dict(kdamonds.kdamonds[0].pid) if err is not None: print(err) + kdamonds.stop() exit(1) if len(status['contexts']) != 1:
base-commit: 49c3f600a9088332b3c1a6db2dc6f3516f273609
Signature · 1 line
2.39.5