Skip to contentSkip to conversation

ASoC: SDCA: Fix implicit cast from le16

PATCH In review Charles Keepax 2 participants 2 messages Jul 22, 2025

Subsystems (3)
lore
Share & tools
lore

Charles Keepax

author maintainer
#0 lore raw

PATCH 1/1 ASoC: SDCA: Fix implicit cast from le16

As the HID wDescriptorLength is explicitly marked as little endian it should be converted to host endian before being used.

Fixes ac558015dfd8 ("ASoC: SDCA: add a HID device for HIDE entity")
---
 sound/soc/sdca/sdca_hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sdca/sdca_hid.c +1 -1
index 2224ade59aff..967f7ec6fb79 100644
@@ -24,7 +24,7 @@ static int sdwhid_parse(struct hid_device *hid)
 	unsigned int rsize;
 	int ret;
 
-	rsize = entity->hide.hid_desc.rpt_desc.wDescriptorLength;
+	rsize = le16_to_cpu(entity->hide.hid_desc.rpt_desc.wDescriptorLength);
 
 	if (!rsize || rsize > HID_MAX_DESCRIPTOR_SIZE) {
 		dev_err(&hid->dev, "invalid size of report descriptor (%u)\n", rsize);
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 4 lines · Charles Keepax

As the HID wDescriptorLength is explicitly marked as little endian it should be converted to host endian before being used.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SDCA: Fix implicit cast from le16

      commit: 246570cd351299959822ac21e75e2975f80ce4b7

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark