Skip to contentSkip to conversation

gpu: ipu-v3: Use dev_fwnode()

PATCH In review Jiri Slaby (SUSE) 2 participants 3 messages Jul 23, 2025 – Sep 8, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: ipu-v3: Use dev_fwnode()

irq_domain_create_simple() takes fwnode as the first argument. It can be extracted from the struct device using dev_fwnode() helper instead of using of_node with of_fwnode_handle().

So use the dev_fwnode() helper.

---
 drivers/gpu/ipu-v3/ipu-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/ipu-v3/ipu-common.c +1 -1
index 333f36e0a715..521d7ec10d85 100644
@@ -1169,7 +1169,7 @@ static int ipu_irq_init(struct ipu_soc *ipu)
 	};
 	int ret, i;
 
-	ipu->domain = irq_domain_create_linear(of_fwnode_handle(ipu->dev->of_node), IPU_NUM_IRQS,
+	ipu->domain = irq_domain_create_linear(dev_fwnode(ipu->dev), IPU_NUM_IRQS,
 					       &irq_generic_chip_ops, ipu);
 	if (!ipu->domain) {
 		dev_err(ipu->dev, "failed to add irq domain\n");
Signature · 1 line
2.50.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Jiri Slaby (SUSE)

irq_domain_create_simple() takes fwnode as the first argument. It can be extracted from the struct device using dev_fwnode() helper instead of using of_node with of_fwnode_handle().

So use the dev_fwnode() helper.

Quoted 4 lines
---
 drivers/gpu/ipu-v3/ipu-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 2 lines
With best wishes
Dmitry
author
#2 lore raw
Quoted 18 lines · Dmitry Baryshkov
Quoted 12 lines · Jiri Slaby (SUSE)

irq_domain_create_simple() takes fwnode as the first argument. It can be extracted from the struct device using dev_fwnode() helper instead of using of_node with of_fwnode_handle().

So use the dev_fwnode() helper.

Quoted 4 lines
---
  drivers/gpu/ipu-v3/ipu-common.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 1 line

Can someone pick this up? Dave?

thanks,

Signature · 2 lines
js
suse labs