Skip to contentSkip to conversation

ssb: use new GPIO line value setter callbacks for the second GPIO chip

PATCH New Bartosz Golaszewski 1 participant 1 message Jul 23, 2025 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ssb: use new GPIO line value setter callbacks for the second GPIO chip

From: Bartosz Golaszewski <[email protected]>

Because the other chip is guarded in an unlikely ifdef, I missed it when converting this driver. Fix it now.

Fixes 757259db79fc ("ssb: use new GPIO line value setter callbacks")

---
Johannes, Michael: I only noticed it now when randbuilding mips with a patch that removed the previous callbacks. I would really appreciate it if we could queue it for v6.17 as it will allow us to complete the treewide conversion of GPIO drivers. Any chance you could fast-track it into your tree?

Thanks,
Bartosz

 drivers/ssb/driver_gpio.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/ssb/driver_gpio.c +5 -3
index 14ad57954a66..e1f5f0a9c8a2 100644
@@ -267,12 +267,14 @@ static int ssb_gpio_extif_get_value(struct gpio_chip *chip, unsigned int gpio)
 	return !!ssb_extif_gpio_in(&bus->extif, 1 << gpio);
 }
 
-static void ssb_gpio_extif_set_value(struct gpio_chip *chip, unsigned int gpio,
-				     int value)
+static int ssb_gpio_extif_set_value(struct gpio_chip *chip, unsigned int gpio,
+				    int value)
 {
 	struct ssb_bus *bus = gpiochip_get_data(chip);
 
 	ssb_extif_gpio_out(&bus->extif, 1 << gpio, value ? 1 << gpio : 0);
+
+	return 0;
 }
 
 static int ssb_gpio_extif_direction_input(struct gpio_chip *chip,
@@ -420,7 +422,7 @@ static int ssb_gpio_extif_init(struct ssb_bus *bus)
 	chip->label		= "ssb_extif_gpio";
 	chip->owner		= THIS_MODULE;
 	chip->get		= ssb_gpio_extif_get_value;
-	chip->set		= ssb_gpio_extif_set_value;
+	chip->set_rv		= ssb_gpio_extif_set_value;
 	chip->direction_input	= ssb_gpio_extif_direction_input;
 	chip->direction_output	= ssb_gpio_extif_direction_output;
 #if IS_ENABLED(CONFIG_SSB_EMBEDDED)
Signature · 1 line
2.48.1