tools/verification: Improvements to rv and rvgen
Subsystems (2)
Gabriele Monaco
maintainercover tools/verification: Improvements to rv and rvgen
This series introduces various improvements to the rv/rvgen tools as first posted in [1]. It also adapts generated kernel files accordingly.
Specifically:
Patch 1 fixes the behaviour of the rv tool with -s and idle tasks.
Patch 2 allows the rv tool to gracefully terminate with SIGTERM
Patch 3 adjusts dot2c not to create lines over 100 columns
Patch 4 properly orders nested monitors in the RV Kconfig file
Patch 5 returns the registration error in all DA monitor instead of 0
This series is based on the linux-next tree.
Changes since [1]:
* Cleanup python code to improve PEP8 compliance
* Fix condition for long line in dot2c
[1] - https://lore.kernel.org/lkml/[email protected]
To: Steven Rostedt <[email protected]>
To: Nam Cao <[email protected]>
Cc: Tomas Glozar <[email protected]>
Cc: Juri Lelli <[email protected]>
Cc: Clark Williams <[email protected]>
Cc: John Kacur <[email protected]>
Gabriele Monaco (5):
tools/rv: Do not skip idle in trace
tools/rv: Stop gracefully also on SIGTERM tools/dot2c: Fix generated files going over 100 column limit verification/rvgen: Organise Kconfig entries for nested monitors
rv: Return init error when registering monitors
kernel/trace/rv/Kconfig | 5 +++++ kernel/trace/rv/monitors/sched/sched.c | 3 +-- kernel/trace/rv/monitors/sco/sco.c | 3 +-- kernel/trace/rv/monitors/scpd/scpd.c | 3 +-- kernel/trace/rv/monitors/sncid/sncid.c | 3 +-- kernel/trace/rv/monitors/snep/snep.c | 3 +-- kernel/trace/rv/monitors/snep/snep.h | 14 +++++++++++-- kernel/trace/rv/monitors/snroc/snroc.c | 3 +-- kernel/trace/rv/monitors/tss/tss.c | 3 +-- kernel/trace/rv/monitors/wip/wip.c | 3 +-- kernel/trace/rv/monitors/wwnr/wwnr.c | 3 +-- tools/verification/rv/src/in_kernel.c | 4 ++-- tools/verification/rv/src/rv.c | 1 + tools/verification/rvgen/rvgen/container.py | 10 ++++++++++ tools/verification/rvgen/rvgen/dot2c.py | 20 ++++++++++--------- tools/verification/rvgen/rvgen/generator.py | 16 ++++++++++----- .../rvgen/rvgen/templates/container/main.c | 3 +-- .../rvgen/rvgen/templates/dot2k/main.c | 3 +-- 18 files changed, 63 insertions(+), 40 deletions(-)
base-commit: a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
Signature · 1 line
2.50.1
Gabriele Monaco
maintainerPATCH 1/5 tools/rv: Do not skip idle in trace
Currently, the userspace RV tool skips trace events triggered by the RV tool itself, this can be changed by passing the parameter -s, which sets the variable config_my_pid to 0 (instead of the tool's PID). This has the side effect of skipping events generated by idle (PID 0).
Set config_my_pid to -1 (an invalid pid) to avoid skipping idle.
--- tools/verification/rv/src/in_kernel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/verification/rv/src/in_kernel.c +2 -2
@@ -431,7 +431,7 @@ ikm_event_handler(struct trace_seq *s, struct tep_record *record,if (config_has_id && (config_my_pid == id))return 0 ; -else if (config_my_pid && (config_my_pid == pid)) +else if (config_my_pid == pid)return 0 ; tep_print_event(trace_event->tep, s, record, "%16s-%-8d [%.3d] ",
@@ -734,7 +734,7 @@ static int parse_arguments(char *monitor_name, int argc, char **argv) config_reactor = optarg;break ;case 's' : - config_my_pid =0 ; + config_my_pid =-1 ;break ;case 't' : config_trace =1 ;
Signature · 1 line
2.50.1
Gabriele Monaco
maintainerPATCH 2/5 tools/rv: Stop gracefully also on SIGTERM
In reply to Gabriele MonacoCurrently the userspace RV tool starts a monitor and waits for the user to press Ctrl-C (SIGINT) to terminate and stop the monitor. This doesn't account for a scenario where a user starts RV in background and simply kills it (SIGTERM unless the user specifies differently). E.g.:
# rv mon wip & # kill %
Would terminate RV without stopping the monitor and next RV executions won't start correctly.
Register the signal handler used for SIGINT also to SIGTERM.
--- tools/verification/rv/src/rv.c | 1 + 1 file changed, 1 insertion(+)
tools/verification/rv/src/rv.c +1 -0
@@ -191,6 +191,7 @@ int main(int argc, char **argv)* and exit. */ signal (SIGINT , stop_rv); +signal (SIGTERM , stop_rv);rv_mon (argc -1 , &argv[1 ]); }
Signature · 1 line
2.50.1
Gabriele Monaco
maintainerPATCH 3/5 tools/dot2c: Fix generated files going over 100 column limit
In reply to Gabriele MonacoThe dot2c.py script generates all states in a single line. This breaks the 100 column limit when the state machines are non-trivial.
Change dot2c.py to generate the states in separate lines in case the generated line is going to be too long.
Also adapt existing monitors with line length over the limit.
--- kernel/trace/rv/monitors/snep/snep.h | 14 ++++++++++++-- tools/verification/rvgen/rvgen/dot2c.py | 20 +++++++++++--------- 2 files changed, 23 insertions(+), 11 deletions(-)
kernel/trace/rv/monitors/snep/snep.h +12 -2
@@ -41,8 +41,18 @@ static const struct automaton_snep automaton_snep = {"schedule_exit" }, .function = { - { non_scheduling_context_snep, non_scheduling_context_snep, scheduling_contex_snep, INVALID_STATE }, - { INVALID_STATE, INVALID_STATE, INVALID_STATE, non_scheduling_context_snep }, + { + non_scheduling_context_snep, + non_scheduling_context_snep, + scheduling_contex_snep, +INVALID_STATE + }, + { +INVALID_STATE , +INVALID_STATE , +INVALID_STATE , + non_scheduling_context_snep + }, }, .initial_state = non_scheduling_context_snep, .final_states = { 1, 0 },
tools/verification/rvgen/rvgen/dot2c.py +11 -9
@@ -152,28 +152,30 @@ class Dot2c(Automata): max_state_name = max(self.states, key = len).__len__() return max(max_state_name, self.invalid_state_str.__len__()) - def __get_state_string_length(self): - maxlen = self.__get_max_strlen_of_states() + self.enum_suffix.__len__() - return "%" + str(maxlen) + "s" - def get_aut_init_function(self): nr_states = self.states.__len__() nr_events = self.events.__len__() buff = [] - strformat = self.__get_state_string_length() - + maxlen = self.__get_max_strlen_of_states() + len(self.enum_suffix) + tab_braces = 2 * 8 + 2 + 1 # "\t\t{ " ... "}" + comma_space = 2 # ", " count last comma here + linetoolong = tab_braces + (maxlen + comma_space) * nr_events > self.line_length for x in range(nr_states): - line = "\t\t{ " + line = "\t\t{\n" if linetoolong else "\t\t{ " for y in range(nr_events): next_state = self.function[x][y] if next_state != self.invalid_state_str: next_state = self.function[x][y] + self.enum_suffix + if linetoolong: + line += "\t\t\t%s" % next_state + else: + line += "%*s" % (maxlen, next_state) if y != nr_events-1: - line = line + strformat % next_state + ", " + line += ",\n" if linetoolong else ", " else: - line = line + strformat % next_state + " }," + line += "\n\t\t}," if linetoolong else " }," buff.append(line) return self.__buff_to_string(buff)
Signature · 1 line
2.50.1
Gabriele Monaco
maintainerPATCH 4/5 verification/rvgen: Organise Kconfig entries for nested monitors
In reply to Gabriele MonacoThe current behaviour of rvgen when running with the -a option is to append the necessary lines at the end of the configuration for Kconfig, Makefile and tracepoints.
This is not always the desired behaviour in case of nested monitors:
while tracepoints are not affected by nesting and the Makefile's only requirement is that the parent monitor is built before its children, in the Kconfig it is better to have children defined right after their parent, otherwise the result has wrong indentation:
[*] foo_parent monitor
[*] foo_child1 monitor
[*] foo_child2 monitor
[*] bar_parent monitor
[*] bar_child1 monitor
[*] bar_child2 monitor
[*] foo_child3 monitor
[*] foo_child4 monitor
Adapt rvgen to look for a different marker for nested monitors in the Kconfig file and append the line right after the last sibling, instead of the last monitor.
Also add the marker when creating a new parent monitor.
--- kernel/trace/rv/Kconfig | 5 +++++ tools/verification/rvgen/rvgen/container.py | 10 ++++++++++ tools/verification/rvgen/rvgen/generator.py | 16 +++++++++++----- 3 files changed, 26 insertions(+), 5 deletions(-)
kernel/trace/rv/Kconfig +5 -0
@@ -43,6 +43,7 @@ config RV_PER_TASK_MONITORS source "kernel/trace/rv/monitors/wip/Kconfig" source "kernel/trace/rv/monitors/wwnr/Kconfig" + source "kernel/trace/rv/monitors/sched/Kconfig" source "kernel/trace/rv/monitors/tss/Kconfig" source "kernel/trace/rv/monitors/sco/Kconfig"
@@ -50,9 +51,13 @@ source "kernel/trace/rv/monitors/snroc/Kconfig" source "kernel/trace/rv/monitors/scpd/Kconfig" source "kernel/trace/rv/monitors/snep/Kconfig" source "kernel/trace/rv/monitors/sncid/Kconfig" +# Add new sched monitors here + source "kernel/trace/rv/monitors/rtapp/Kconfig" source "kernel/trace/rv/monitors/pagefault/Kconfig" source "kernel/trace/rv/monitors/sleep/Kconfig" +# Add new rtapp monitors here + # Add new monitors here config RV_REACTORS
tools/verification/rvgen/rvgen/container.py +10 -0
@@ -20,3 +20,13 @@ class Container(generator.RVGenerator): main_h = self.main_h main_h = main_h.replace("%%MODEL_NAME%%", self.name) return main_h + + def fill_kconfig_tooltip(self): + """Override to produce a marker for this container in the Kconfig""" + container_marker = self._kconfig_marker(self.name) + "\n" + result = super().fill_kconfig_tooltip() + if self.auto_patch: + self._patch_file("Kconfig", + self._kconfig_marker(), container_marker) + return result + return result + container_marker
tools/verification/rvgen/rvgen/generator.py +11 -5
@@ -137,7 +137,8 @@ class RVGenerator: kconfig = kconfig.replace("%%MONITOR_DEPS%%", monitor_deps) return kconfig - def __patch_file(self, file, marker, line): + def _patch_file(self, file, marker, line): + assert self.auto_patch file_to_patch = os.path.join(self.rv_dir, file) content = self._read_file(file_to_patch) content = content.replace(marker, line + "\n" + marker)
@@ -146,7 +147,7 @@ class RVGenerator: def fill_tracepoint_tooltip(self): monitor_class_type = self.fill_monitor_class_type() if self.auto_patch: - self.__patch_file("rv_trace.h", + self._patch_file("rv_trace.h", "// Add new monitors based on CONFIG_%s here" % monitor_class_type, "#include <monitors/%s/%s_trace.h>" % (self.name, self.name)) return " - Patching %s/rv_trace.h, double check the result" % self.rv_dir
@@ -156,10 +157,15 @@ Add this line where other tracepoints are included and %s is defined: #include <monitors/%s/%s_trace.h> """ % (self.rv_dir, monitor_class_type, self.name, self.name) + def _kconfig_marker(self, container=None) -> str: + return "# Add new %smonitors here" % (container + " " + if container else "") + def fill_kconfig_tooltip(self): if self.auto_patch: - self.__patch_file("Kconfig", - "# Add new monitors here", + # monitors with a container should stay together in the Kconfig + self._patch_file("Kconfig", + self._kconfig_marker(self.parent), "source \"kernel/trace/rv/monitors/%s/Kconfig\"" % (self.name)) return " - Patching %s/Kconfig, double check the result" % self.rv_dir
@@ -172,7 +178,7 @@ source \"kernel/trace/rv/monitors/%s/Kconfig\" name = self.name name_up = name.upper() if self.auto_patch: - self.__patch_file("Makefile", + self._patch_file("Makefile", "# Add new monitors here", "obj-$(CONFIG_RV_MON_%s) += monitors/%s/%s.o" % (name_up, name, name)) return " - Patching %s/Makefile, double check the result" % self.rv_dir
Signature · 1 line
2.50.1
Gabriele Monaco
maintainerPATCH 5/5 Return init error when registering monitors
In reply to Gabriele MonacoMonitors generated with dot2k have their registration function (the one called during monitor initialisation) return always 0, even if the registration failed on RV side.
This can hide potential errors.
Return the value returned by the RV register function.
--- kernel/trace/rv/monitors/sched/sched.c | 3 +-- kernel/trace/rv/monitors/sco/sco.c | 3 +-- kernel/trace/rv/monitors/scpd/scpd.c | 3 +-- kernel/trace/rv/monitors/sncid/sncid.c | 3 +-- kernel/trace/rv/monitors/snep/snep.c | 3 +-- kernel/trace/rv/monitors/snroc/snroc.c | 3 +-- kernel/trace/rv/monitors/tss/tss.c | 3 +-- kernel/trace/rv/monitors/wip/wip.c | 3 +-- kernel/trace/rv/monitors/wwnr/wwnr.c | 3 +-- tools/verification/rvgen/rvgen/templates/container/main.c | 3 +-- tools/verification/rvgen/rvgen/templates/dot2k/main.c | 3 +-- 11 files changed, 11 insertions(+), 22 deletions(-)
kernel/trace/rv/monitors/sched/sched.c +1 -2
@@ -21,8 +21,7 @@ struct rv_monitor rv_sched = {static int __init register_sched (void ) { -rv_register_monitor (&rv_sched,NULL ); -return 0 ; +return rv_register_monitor (&rv_sched,NULL ); } static void __exit unregister_sched(void)
kernel/trace/rv/monitors/sco/sco.c +1 -2
@@ -71,8 +71,7 @@ static struct rv_monitor rv_sco = {static int __init register_sco (void ) { -rv_register_monitor (&rv_sco, &rv_sched); -return 0 ; +return rv_register_monitor (&rv_sco, &rv_sched); } static void __exit unregister_sco(void)
kernel/trace/rv/monitors/scpd/scpd.c +1 -2
@@ -79,8 +79,7 @@ static struct rv_monitor rv_scpd = {static int __init register_scpd (void ) { -rv_register_monitor (&rv_scpd, &rv_sched); -return 0 ; +return rv_register_monitor (&rv_scpd, &rv_sched); } static void __exit unregister_scpd(void)
kernel/trace/rv/monitors/sncid/sncid.c +1 -2
@@ -79,8 +79,7 @@ static struct rv_monitor rv_sncid = {static int __init register_sncid (void ) { -rv_register_monitor (&rv_sncid, &rv_sched); -return 0 ; +return rv_register_monitor (&rv_sncid, &rv_sched); } static void __exit unregister_sncid(void)
kernel/trace/rv/monitors/snep/snep.c +1 -2
@@ -79,8 +79,7 @@ static struct rv_monitor rv_snep = {static int __init register_snep (void ) { -rv_register_monitor (&rv_snep, &rv_sched); -return 0 ; +return rv_register_monitor (&rv_snep, &rv_sched); } static void __exit unregister_snep(void)
kernel/trace/rv/monitors/snroc/snroc.c +1 -2
@@ -68,8 +68,7 @@ static struct rv_monitor rv_snroc = {static int __init register_snroc (void ) { -rv_register_monitor (&rv_snroc, &rv_sched); -return 0 ; +return rv_register_monitor (&rv_snroc, &rv_sched); } static void __exit unregister_snroc(void)
kernel/trace/rv/monitors/tss/tss.c +1 -2
@@ -74,8 +74,7 @@ static struct rv_monitor rv_tss = {static int __init register_tss (void ) { -rv_register_monitor (&rv_tss, &rv_sched); -return 0 ; +return rv_register_monitor (&rv_tss, &rv_sched); } static void __exit unregister_tss(void)
kernel/trace/rv/monitors/wip/wip.c +1 -2
@@ -71,8 +71,7 @@ static struct rv_monitor rv_wip = {static int __init register_wip (void ) { -rv_register_monitor (&rv_wip,NULL ); -return 0 ; +return rv_register_monitor (&rv_wip,NULL ); } static void __exit unregister_wip(void)
kernel/trace/rv/monitors/wwnr/wwnr.c +1 -2
@@ -70,8 +70,7 @@ static struct rv_monitor rv_wwnr = {static int __init register_wwnr (void ) { -rv_register_monitor (&rv_wwnr,NULL ); -return 0 ; +return rv_register_monitor (&rv_wwnr,NULL ); } static void __exit unregister_wwnr(void)
tools/verification/rvgen/rvgen/templates/container/main.c +1 -2
@@ -21,8 +21,7 @@ struct rv_monitor rv_%%MODEL_NAME%% = { static int __init register_%%MODEL_NAME%%(void) { - rv_register_monitor(&rv_%%MODEL_NAME%%, NULL); -return 0 ; + return rv_register_monitor(&rv_%%MODEL_NAME%%, NULL); } static void __exit unregister_%%MODEL_NAME%%(void)
tools/verification/rvgen/rvgen/templates/dot2k/main.c +1 -2
@@ -74,8 +74,7 @@ static struct rv_monitor rv_%%MODEL_NAME%% = { static int __init register_%%MODEL_NAME%%(void) { - rv_register_monitor(&rv_%%MODEL_NAME%%, %%PARENT%%); -return 0 ; + return rv_register_monitor(&rv_%%MODEL_NAME%%, %%PARENT%%); } static void __exit unregister_%%MODEL_NAME%%(void)
Signature · 1 line
2.50.1
Steven Rostedt
maintainerQuoted 5 lines · On Wed, 23 Jul 2025 18:12:35 +0200 Gabriele Monaco <[email protected]> wrote:
This series introduces various improvements to the rv/rvgen tools as first posted in [1]. It also adapts generated kernel files accordingly.
Specifically:
Quoted 7 lines
Patch 1 fixes the behaviour of the rv tool with -s and idle tasks.
Patch 2 allows the rv tool to gracefully terminate with SIGTERM
Patch 3 adjusts dot2c not to create lines over 100 columns
Patch 4 properly orders nested monitors in the RV
Kconfigfile
So keeping tools and kernel separate for RV is proving to be quite a pain as patch 4 has conflicts. I'm going to make a third topic branch just for RV. This will include anything in tools/verification and kernel/trace/rv. I'll restructure the patches I already added and move them into this branch, so that all the RV related work is there and not in the latency or tools branches.
So no need to separate RV into kernel and tooling anymore.
Quoted 4 lines
Patch 5 returns the registration error in all DA monitor instead of 0
This series is based on the linux-next tree.
The topic branches I'll have is:
tools - for things like rtla
latency - for the latency tracers (osnoise, etc)
rv - for the runtime verification work.
-- Steve
Gabriele Monaco
maintainer2025-07-24T14:40:23Z Steven Rostedt <[email protected]>:
Quoted 6 lines
Quoted 3 lines · On Wed, 23 Jul 2025 18:12:35 +0200 Gabriele Monaco <[email protected]> wrote:
This series introduces various improvements to the rv/rvgen tools as first posted in [1]. It also adapts generated kernel files accordingly.
Quoted 9 lines
So keeping tools and kernel separate for RV is proving to be quite a pain as patch 4 has conflicts. I'm going to make a third topic branch just for RV. This will include anything in
tools/verificationandkernel/trace/rv. I'll restructure the patches I already added and move them into this branch, so that all the RV related work is there and not in the latency or tools branches.So no need to separate RV into kernel and tooling anymore.
Alright, but I guess going forward I'll try to keep changes separated anyway, if possible.
Right, 4 is problematic here, it should apply cleanly on next though, maybe I should have rebased on your tree instead..
So do I submit together 4,5 and the kernel ones? Or again all together?
Thanks,
Gabriele
Quoted 5 lines
The topic branches I'll have is:
tools - for things like rtla
latency - for the latency tracers (osnoise, etc)
rv - for the runtime verification work.
Steven Rostedt
maintainerQuoted 5 lines · On Thu, 24 Jul 2025 18:07:35 +0000 (UTC) Gabriele Monaco <[email protected]>…
Alright, but I guess going forward I'll try to keep changes separated anyway, if possible.
Right, 4 is problematic here, it should apply cleanly on next though, maybe I should have rebased on your tree instead..
So do I submit together 4,5 and the kernel ones? Or again all together?
If you haven't noticed, I already just took it ;-)
-- Steve
Steven Rostedt
maintainerBTW, please make sure that the cover letter is Cc'd to [email protected] along with the patches. I use patchwork to see the cover letter, but it's not present when it's not Cc'd.
Thanks,
-- Steve
Quoted 59 lines · On Wed, 23 Jul 2025 18:12:35 +0200 Gabriele Monaco <[email protected]> wrote:
This series introduces various improvements to the rv/rvgen tools as first posted in [1]. It also adapts generated kernel files accordingly.
Specifically:
Patch 1 fixes the behaviour of the rv tool with -s and idle tasks.
Patch 2 allows the rv tool to gracefully terminate with SIGTERM
Patch 3 adjusts dot2c not to create lines over 100 columns
Patch 4 properly orders nested monitors in the RV
KconfigfilePatch 5 returns the registration error in all DA monitor instead of 0
This series is based on the linux-next tree.
Changes since [1]:
* Cleanup python code to improve PEP8 compliance
* Fix condition for long line in dot2c[1] - https://lore.kernel.org/lkml/[email protected]
To: Steven Rostedt <[email protected]>
To: Nam Cao <[email protected]>
Cc: Tomas Glozar <[email protected]>
Cc: Juri Lelli <[email protected]>
Cc: Clark Williams <[email protected]>
Cc: John Kacur <[email protected]>Gabriele Monaco (5):
tools/rv: Do not skip idle in trace
tools/rv: Stop gracefully also on SIGTERMtools/dot2c: Fix generated files going over 100 column limit verification/rvgen: OrganiseKconfigentries for nested monitors
rv: Return init error when registering monitorskernel/trace/rv/Kconfig | 5 +++++ kernel/trace/rv/monitors/sched/sched.c | 3 +-- kernel/trace/rv/monitors/sco/sco.c | 3 +-- kernel/trace/rv/monitors/scpd/scpd.c | 3 +-- kernel/trace/rv/monitors/sncid/sncid.c | 3 +-- kernel/trace/rv/monitors/snep/snep.c | 3 +-- kernel/trace/rv/monitors/snep/snep.h | 14 +++++++++++-- kernel/trace/rv/monitors/snroc/snroc.c | 3 +-- kernel/trace/rv/monitors/tss/tss.c | 3 +-- kernel/trace/rv/monitors/wip/wip.c | 3 +-- kernel/trace/rv/monitors/wwnr/wwnr.c | 3 +-- tools/verification/rv/src/in_kernel.c | 4 ++-- tools/verification/rv/src/rv.c | 1 + tools/verification/rvgen/rvgen/container.py | 10 ++++++++++ tools/verification/rvgen/rvgen/dot2c.py | 20 ++++++++++--------- tools/verification/rvgen/rvgen/generator.py | 16 ++++++++++----- .../rvgen/rvgen/templates/container/main.c | 3 +-- .../rvgen/rvgen/templates/dot2k/main.c | 3 +-- 18 files changed, 63 insertions(+), 40 deletions(-)base-commit:
a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
Gabriele Monaco
maintainerQuoted 6 lines · Steven Rostedt
BTW, please make sure that the cover letter is Cc'd to [email protected] along with the patches. I use patchwork to see the cover letter, but it's not present when it's not Cc'd.
Uh, right, will do!
Thanks,
Gabriele
Quoted 72 lines
Thanks,
-- Steve
Quoted 64 lines · On Wed, 23 Jul 2025 18:12:35 +0200 Gabriele Monaco <[email protected]> wrote:
This series introduces various improvements to the rv/rvgen tools as
first posted in [1]. It also adapts generated kernel files accordingly.Specifically:
Patch 1 fixes the behaviour of the rv tool with -s and idle tasks.
Patch 2 allows the rv tool to gracefully terminate with SIGTERM
Patch 3 adjusts dot2c not to create lines over 100 columns
Patch 4 properly orders nested monitors in the RV
KconfigfilePatch 5 returns the registration error in all DA monitor instead of 0
This series is based on the linux-next tree.
Changes since [1]:
* Cleanup python code to improve PEP8 compliance
* Fix condition for long line in dot2c[1] -
https://lore.kernel.org/lkml/[email protected]To: Steven Rostedt <[email protected]>
To: Nam Cao <[email protected]>
Cc: Tomas Glozar <[email protected]>
Cc: Juri Lelli <[email protected]>
Cc: Clark Williams <[email protected]>
Cc: John Kacur <[email protected]>Gabriele Monaco (5):
tools/rv: Do not skip idle in trace
tools/rv: Stop gracefully also on SIGTERMtools/dot2c: Fix generated files going over 100 column limit verification/rvgen: OrganiseKconfigentries for nested monitors
rv: Return init error when registering monitorskernel/trace/rv/Kconfig | 5 +++++ kernel/trace/rv/monitors/sched/sched.c | 3 +-- kernel/trace/rv/monitors/sco/sco.c | 3 +-- kernel/trace/rv/monitors/scpd/scpd.c | 3 +-- kernel/trace/rv/monitors/sncid/sncid.c | 3 +-- kernel/trace/rv/monitors/snep/snep.c | 3 +-- kernel/trace/rv/monitors/snep/snep.h | 14 +++++++++++-- kernel/trace/rv/monitors/snroc/snroc.c | 3 +-- kernel/trace/rv/monitors/tss/tss.c | 3 +-- kernel/trace/rv/monitors/wip/wip.c | 3 +-- kernel/trace/rv/monitors/wwnr/wwnr.c | 3 +-- tools/verification/rv/src/in_kernel.c | 4 ++-- tools/verification/rv/src/rv.c | 1 + tools/verification/rvgen/rvgen/container.py | 10 ++++++++++ tools/verification/rvgen/rvgen/dot2c.py | 20 ++++++++++-----
----
tools/verification/rvgen/rvgen/generator.py | 16 ++++++++++----- .../rvgen/rvgen/templates/container/main.c | 3 +-- .../rvgen/rvgen/templates/dot2k/main.c | 3 +--18 files changed, 63 insertions(+), 40 deletions(-)base-commit:
a933d3dc1968fcfb0ab72879ec304b1971ed1b9a