bus: mhi: host: Fix potential kernel panic by calling dev_err
PATCH 1/1 bus: mhi: host: Fix potential kernel panic by calling dev_err
In mhi_init_irq_setup, the device pointer used for dev_err was not initialized. Use the pointer from pci_dev instead.
Signed-off-by Adam Xue <[email protected]>
--- drivers/bus/mhi/host/init.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/bus/mhi/host/init.c +4 -3
@@ -18,6 +18,7 @@#include <linux/slab.h> #include <linux/vmalloc.h> #include <linux/wait.h> +#include <linux/pci.h> #include "internal.h" #define CREATE_TRACE_POINTS
@@ -194,7 +195,7 @@ void mhi_deinit_free_irq(struct mhi_controller *mhi_cntrl)int mhi_init_irq_setup (struct mhi_controller *mhi_cntrl) {struct mhi_event *mhi_event = mhi_cntrl->mhi_event; -struct device *dev = &mhi_cntrl->mhi_dev->dev; +struct pci_dev *pdev =to_pci_dev (mhi_cntrl->cntrl_dev);unsigned long irq_flags =IRQF_SHARED |IRQF_NO_SUSPEND ;int i, ret;
@@ -221,7 +222,7 @@ int mhi_init_irq_setup(struct mhi_controller *mhi_cntrl)continue ;if (mhi_event->irq >= mhi_cntrl->nr_irqs) { -dev_err (dev,"irq %d not available for event ring\n" , +dev_err (&pdev->dev,"irq %d not available for event ring\n" , mhi_event->irq); ret = -EINVAL ; goto error_request;
@@ -232,7 +233,7 @@ int mhi_init_irq_setup(struct mhi_controller *mhi_cntrl) irq_flags, "mhi", mhi_event);if (ret) { -dev_err (dev,"Error requesting irq:%d for ev:%d\n" , +dev_err (&pdev->dev,"Error requesting irq:%d for ev:%d\n" , mhi_cntrl->irq[mhi_event->irq], i); goto error_request; }
Signature · 4 lines
2.43.0 To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.