nvme: Fix typos
Subsystems (4)
PATCH 1/1 nvme: Fix typos
From: Bjorn Helgaas <[email protected]>
Fix typos in comments.
--- drivers/nvme/host/apple.c | 2 +- drivers/nvme/host/fc.c | 10 +++++----- drivers/nvme/host/pci.c | 2 +- drivers/nvme/host/rdma.c | 2 +- drivers/nvme/host/tcp.c | 2 +- drivers/nvme/target/fc.c | 6 +++--- drivers/nvme/target/rdma.c | 6 +++--- 7 files changed, 15 insertions(+), 15 deletions(-)
drivers/nvme/host/apple.c +1 -1
@@ -302,7 +302,7 @@ static void apple_nvme_submit_cmd(struct apple_nvme_queue *q,/* * This lock here doesn't make much sense at a first glace but -* removing it will result in occasional missed completetion +* removing it will result in occasional missed completion * interrupts even though the commands still appear on the CQ. * It's unclear why this happens but our best guess is that * there is a bug in the firmware triggered when a new command
drivers/nvme/host/fc.c +5 -5
@@ -1363,7 +1363,7 @@ nvme_fc_disconnect_assoc_done(struct nvmefc_ls_req *lsreq, int status)* down, and the related FC-NVME Association ID and Connection IDs * become invalid. * -* The behavior of the fc-nvme initiator is such that it's +* The behavior of the fc-nvme initiator is such that its * understanding of the association and connections will implicitly * be torn down. The action is implicit as it may be due to a loss of * connectivity with the fc-nvme target, so you may never get a
@@ -1955,8 +1955,8 @@ nvme_fc_fcpio_done(struct nvmefc_fcp_req *req) }/* -* For the linux implementation, if we have an unsucceesful -* status, they blk-mq layer can typically be called with the +* For the linux implementation, if we have an unsuccessful +* status, the blk-mq layer can typically be called with the * non-zero status and the content of the cqe isn't important. */ if (status)
@@ -2622,7 +2622,7 @@ nvme_fc_unmap_data(struct nvme_fc_ctrl *ctrl, struct request *rq,* as part of the exchange. The CQE is the last thing for the io, * which is transferred (explicitly or implicitly) with the RSP IU * sent on the exchange. After the CQE is received, the FC exchange is -* terminaed and the Exchange may be used on a different io. +* terminated and the Exchange may be used on a different io. * * The transport to LLDD api has the transport making a request for a * new fcp io request to the LLDD. The LLDD then allocates a FC exchange
@@ -2777,7 +2777,7 @@ nvme_fc_queue_rq(struct blk_mq_hw_ctx *hctx,* as WRITE ZEROES will return a non-zero rq payload_bytes yet * there is no actual payload to be transferred. * To get it right, key data transmission on there being 1 or -* more physical segments in the sg list. If there is no +* more physical segments in the sg list. If there are no * physical segments, there is no payload. */ if (blk_rq_nr_phys_segments (rq)) {
drivers/nvme/host/pci.c +1 -1
@@ -2548,7 +2548,7 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)/* * Free IRQ resources as soon as NVMEQ_ENABLED bit transitions -* from set to unset. If there is a window to it is truely freed, +* from set to unset. If there is a window to it is truly freed, * pci_free_irq_vectors() jumping into this window will crash. * And take lock to avoid racing with pci_free_irq_vectors() in * nvme_dev_disable() path.
drivers/nvme/host/rdma.c +1 -1
@@ -877,7 +877,7 @@ static int nvme_rdma_configure_io_queues(struct nvme_rdma_ctrl *ctrl, bool new)/* * Only start IO queues for which we have allocated the tagset -* and limitted it to the available queues. On reconnects, the +* and limited it to the available queues. On reconnects, the * queue number might have changed. */ nr_queues =min (ctrl->tag_set.nr_hw_queues +1 , ctrl->ctrl.queue_count);
drivers/nvme/host/tcp.c +1 -1
@@ -2174,7 +2174,7 @@ static int nvme_tcp_configure_io_queues(struct nvme_ctrl *ctrl, bool new)/* * Only start IO queues for which we have allocated the tagset -* and limitted it to the available queues. On reconnects, the +* and limited it to the available queues. On reconnects, the * queue number might have changed. */ nr_queues =min (ctrl->tagset->nr_hw_queues +1 , ctrl->queue_count);
drivers/nvme/target/fc.c +3 -3
@@ -459,7 +459,7 @@ nvmet_fc_disconnect_assoc_done(struct nvmefc_ls_req *lsreq, int status)* down, and the related FC-NVME Association ID and Connection IDs * become invalid. * -* The behavior of the fc-nvme target is such that it's +* The behavior of the fc-nvme target is such that its * understanding of the association and connections will implicitly * be torn down. The action is implicit as it may be due to a loss of * connectivity with the fc-nvme host, so the target may never get a
@@ -2313,7 +2313,7 @@ nvmet_fc_transfer_fcp_data(struct nvmet_fc_tgtport *tgtport, ret = tgtport->ops->fcp_op (&tgtport->fc_target_port, fod->fcpreq);if (ret) {/* -* should be ok to set w/o lock as its in the thread of +* should be ok to set w/o lock as it's in the thread of * execution (not an async timer routine) and doesn't * contend with any clearing action */
@@ -2629,7 +2629,7 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport,* and the api of the FC LLDD which may issue a hw command to send the * response, but the LLDD may not get the hw completion for that command * and upcall the nvmet_fc layer before a new command may be -* asynchronously received - its possible for a command to be received +* asynchronously received - it's possible for a command to be received * before the LLDD and nvmet_fc have recycled the job structure. It gives * the appearance of more commands received than fits in the sq. * To alleviate this scenario, a temporary queue is maintained in the
drivers/nvme/target/rdma.c +3 -3
@@ -1731,7 +1731,7 @@ static void nvmet_rdma_queue_connect_fail(struct rdma_cm_id *cm_id,* We registered an ib_client to handle device removal for queues, * so we only need to handle the listening port cm_ids. In this case * we nullify the priv to prevent double cm_id destruction and destroying -* the cm_id implicitely by returning a non-zero rc to the callout. +* the cm_id implicitly by returning a non-zero rc to the callout. */ static int nvmet_rdma_device_removal (struct rdma_cm_id *cm_id,struct nvmet_rdma_queue *queue)
@@ -1742,7 +1742,7 @@ static int nvmet_rdma_device_removal(struct rdma_cm_id *cm_id,/* * This is a queue cm_id. we have registered * an ib_client to handle queues removal -* so don't interfear and just return. +* so don't interfere and just return. */ return 0 ; }
@@ -1760,7 +1760,7 @@ static int nvmet_rdma_device_removal(struct rdma_cm_id *cm_id,/* * We need to return 1 so that the core will destroy -* it's own ID. What a great API design.. +* its own ID. What a great API design.. */ return 1 ; }
Signature · 1 line
2.43.0
Quoted 5 lines · Bjorn Helgaas
From: Bjorn Helgaas<[email protected]>
Fix typos in comments.
Signed-off-by Bjorn Helgaas<[email protected]>
Looks good.
-ck
Christoph Hellwig
maintainerQuoted 3 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
Fix typos in comments.
This created multiple rejects. Can you resend against the current tree? If you don't want to deal with the nvme tree, maybe resend just before/after rc1?
Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
Fix typos in comments.
This created multiple rejects. Can you resend against the current tree? If you don't want to deal with the nvme tree, maybe resend just before/after rc1?
Sure, will do. I'll rebase on nvme/nvme-6.17 (e97c0040215f ("nvme-auth: remove unneeded semicolon")) now, and if that's not the right branch, let me know and I'll redo it around -rc1.
Bjorn
Christoph Hellwig
maintainerQuoted 6 lines · Bjorn Helgaas
Quoted 5 lines · Christoph Hellwig
Quoted 3 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
Fix typos in comments.
Quoted 7 lines
Quoted 3 lines
This created multiple rejects. Can you resend against the current tree? If you don't want to deal with the nvme tree, maybe resend just before/after rc1?
Sure, will do. I'll rebase on nvme/nvme-6.17 (
e97c0040215f("nvme-auth: remove unneeded semicolon")) now, and if that's not the right branch, let me know and I'll redo it around -rc1.
That is the correct branch.