Skip to contentSkip to conversation

ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx

PATCH In review [email protected] 2 participants 3 messages Jul 24, 2025 – Jul 25, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx

From: Edip Hazuri <[email protected]>

The mute led on this laptop is using ALC245 but requires a quirk to work This patch enables the existing quirk for the device.

Tested on Victus 16-r1xxx Laptop. The LED behaviour works as intended.

---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
index 2627e2f49..9656e6ebb 100644
@@ -10874,6 +10874,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8c91, "HP EliteBook 660", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8c97, "HP ZBook", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+	SND_PCI_QUIRK(0x103c, 0x8c99, "HP Victus 16-r1xxx (MB 8C99)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8c9c, "HP Victus 16-s1xxx (MB 8C9C)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8ca1, "HP ZBook Power", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8ca2, "HP ZBook Power", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.50.1
#1 lore raw
Quoted 11 lines · On Thu, 24 Jul 2025 23:07:56 +0200, [email protected] wrote:

From: Edip Hazuri <[email protected]>

The mute led on this laptop is using ALC245 but requires a quirk to work This patch enables the existing quirk for the device.

Tested on Victus 16-r1xxx Laptop. The LED behaviour works as intended.

The HD-audio code was relocated and split to different files recently (for 6.17 kernel), e.g. this Realtek codec is now located in sound/hda/codecs/realtek/alc269.c.

As I already closed the changes for 6.16 and it'll be put for 6.17-rc1, could you rebase on for-next branch of sound.git tree and resubmit?

thanks,

Takashi

#2 lore raw
Quoted 18 lines · On Friday, July 25, 2025 10:13:38 AM GMT+03:00 Takashi Iwai wrote:

On Thu, 24 Jul 2025 23:07:56 +0200,

Quoted 10 lines · [email protected] wrote:

From: Edip Hazuri <[email protected]>

The mute led on this laptop is using ALC245 but requires a quirk to work This patch enables the existing quirk for the device.

Tested on Victus 16-r1xxx Laptop. The LED behaviour works as intended.

The HD-audio code was relocated and split to different files recently (for 6.17 kernel), e.g. this Realtek codec is now located in sound/hda/codecs/realtek/alc269.c.

Quoted 8 lines

As I already closed the changes for 6.16 and it'll be put for 6.17-rc1, could you rebase on for-next branch of sound.git tree and resubmit?

thanks,

Takashi

Hi

I'll rebase and resubmit it as soon as possible
Thank you