Skip to contentSkip to conversation

conf: machine: am64xx: Cleanup assignment whitespace

PATCH In review Ryan Eatmon 2 participants 5 messages Jul 23, 2025 – Jul 24, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 conf: machine: am64xx: Cleanup assignment whitespace

A recent change in bitbake requires that all variable assignments have whitespace between the variable, the operator and the value.

FOO = "1"

---
 meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/conf/machine/include/am64xx.inc +1 -1
index 56b56afe..27165547 100644
@@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x"
 
 MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw"
 
-TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8"
+TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8"
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/3 gadget-init: Add missing SUMMARY

Every recipe should have a SUMMARY and that can only be 72 characters at most. This recipes had a DESCRIPTION and not SUMMARY.

---
 meta-ti-extras/recipes-ti/beagleboard/gadget-init.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-extras/recipes-ti/beagleboard/gadget-init.bb +1 -1
index 3ab00ec3..27b2520e 100644
@@ -1,4 +1,4 @@
-DESCRIPTION = "Units to initialize usb gadgets"
+SUMMARY = "Units to initialize usb gadgets"
 
 PR = "r19"
 
Signature · 1 line
2.17.1
#2 lore raw

PATCH 3/3 check_yocto_rules: Add new rule for recent change

In reply to Ryan Eatmon

- The UBOOT_VERSION bbappend does not need a guard since we are modifying our own layer.

---
 check_yocto_rules.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
check_yocto_rules.json +2 -1
index 7e8eb211..6d33c0aa 100644
@@ -17,7 +17,8 @@
         "skip_files" : [
             "meta-ti-bsp/recipes-core/udev/eudev_%.bbappend",
             "meta-ti-bsp/recipes-devtools/binutils/binutils-cross-canadian_%.bbappend",
-            "meta-ti-bsp/recipes-security/optee/optee-%.bbappend"
+            "meta-ti-bsp/recipes-security/optee/optee-%.bbappend",
+            "meta-ti-bsp/dynamic-layers/openembedded-layer/recipes-bsp/u-boot/u-boot-ti-%.bbappend"
         ]
     },
     "GUARD-2" : {
Signature · 1 line
2.17.1
#3 lore raw
In reply to Ryan Eatmon

Is this change scarthgap specific? I see the change that originally added TI_WKS_BOOTLOADER_APPEND to scarthgap is now being forward-ported to master, thus this fix appears to also be applicable to master?

Quoted 22 lines · Ryan Eatmon via lists.yoctoproject.org

A recent change in bitbake requires that all variable assignments have whitespace between the variable, the operator and the value.

FOO = "1"

---
 meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/conf/machine/include/am64xx.inc +1 -1
index 56b56afe..27165547 100644
@@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x"
 
 MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw"
 
-TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8"
+TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8"
Signature · 1 line
2.17.1
#4 lore raw

Nope. I meant to send this patch as a combo patch. For both master and scarthgap. Oops. Good catch.

Quoted 28 lines · Denys Dmytriyenko

Is this change scarthgap specific? I see the change that originally added TI_WKS_BOOTLOADER_APPEND to scarthgap is now being forward-ported to master, thus this fix appears to also be applicable to master?

Quoted 22 lines · Ryan Eatmon via lists.yoctoproject.org

A recent change in bitbake requires that all variable assignments have whitespace between the variable, the operator and the value.

FOO = "1"

---
  meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-ti-bsp/conf/machine/include/am64xx.inc +1 -1
index 56b56afe..27165547 100644
@@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x"
 
  MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw"
 
-TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8"
+TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8"
Signature · 1 line
2.17.1
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS