Skip to contentSkip to conversation

mm-mglru-stop-try_to_inc_min_seq-if-min_seq-has-not-increased.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jul 25, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/mglru: stop try_to_inc_min_seq() if min_seq[type] has not increased
has been removed from the -mm tree. Its filename was
mm-mglru-stop-try_to_inc_min_seq-if-min_seq-has-not-increased.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Hao Jia <[email protected]>
Subject: mm/mglru: stop try_to_inc_min_seq() if min_seq[type] has not increased
Date: Thu, 3 Jul 2025 10:39:46 +0800

In try_to_inc_min_seq(), if min_seq[type] has not increased. In other words, min_seq[type] == lrugen->min_seq[type]. Then we should return directly to avoid unnecessary overhead later.

Corollary: If min_seq[type] of both anonymous and file is not increased, try_to_inc_min_seq() will fail.

Proof:
It is known that min_seq[type] has not increased, that is, min_seq[type] is equal to lrugen->min_seq[type], then the following:

case 1: min_seq[type] has not been reassigned and changed before judgment min_seq[type] <= lrugen->min_seq[type].
Then the subsequent min_seq[type] <= lrugen->min_seq[type] judgment will always be true.

case 2: min_seq[type] is reassigned to seq, before judgment min_seq[type] <= lrugen->min_seq[type].
Then at least the condition of min_seq[type] > seq must be met before min_seq[type] will be reassigned to seq.
That is to say, before the reassignment, lrugen->min_seq[type] > seq is met, and then min_seq[type] = seq.
Then the following min_seq[type](seq) <= lrugen->min_seq[type] judgment is always true.

Therefore, in try_to_inc_min_seq(), If min_seq[type] of both anonymous and file is not increased, we can return false directly to avoid unnecessary overhead.

---

 mm/vmscan.c |   10 ++++++++++
 1 file changed, 10 insertions(+)
mm/vmscan.c renamed from mm/vmscan.c~mm-mglru-stop-try_to_inc_min_seq-if-min_seq-has-not-increased +10 -0
@@ -3921,6 +3921,7 @@ static bool try_to_inc_min_seq(struct lr
 {
 	int gen, type, zone;
 	bool success = false;
+	bool seq_inc_flag = false;
 	struct lru_gen_folio *lrugen = &lruvec->lrugen;
 	DEFINE_MIN_SEQ(lruvec);
 
@@ -3937,11 +3938,20 @@ static bool try_to_inc_min_seq(struct lr
 			}
 
 			min_seq[type]++;
+			seq_inc_flag = true;
 		}
 next:
 		;
 	}
 
+	/*
+	 * If min_seq[type] of both anonymous and file is not increased,
+	 * we can directly return false to avoid unnecessary checking
+	 * overhead later.
+	 */
+	if (!seq_inc_flag)
+		return success;
+
 	/* see the comment on lru_gen_folio */
 	if (swappiness && swappiness <= MAX_SWAPPINESS) {
 		unsigned long seq = lrugen->max_seq - MIN_NR_GENS;

_

Patches currently in -mm which might be from [email protected] are

mm-mglru-update-mg-lru-proactive-reclaim-statistics-only-to-memcg.patch