pinctrl: tegra30: fix typo with variables to control the drive state on nvidia pins.
Subsystems (2)
PATCH 1/1 pinctrl: tegra30: fix typo with variables to control the drive state on nvidia pins.
From: Chali Anis <[email protected]>
Fixes fd940ff6512b ("pinctrl: tegra30: parse drive groups")
Signed-off-by Chali Anis <[email protected]>
--- drivers/pinctrl/pinctrl-tegra30.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/pinctrl/pinctrl-tegra30.c +5 -5
@@ -669,31 +669,31 @@ static int pinctrl_tegra30_set_drvstate(struct pinctrl_tegra30 *ctrl,if (schmitt >=0 ) { val =readl (regaddr); val &= ~(0x1 << group->schmitt_bit); - val |= hsm << group->schmitt_bit; + val |= schmitt << group->schmitt_bit;writel (val, regaddr); }if (pds >=0 ) { val =readl (regaddr); val &= ~(((1 << group->drvdn_width) -1 ) << group->drvdn_bit); - val |= hsm << group->drvdn_bit; + val |= pds << group->drvdn_bit;writel (val, regaddr); }if (pus >=0 ) { val =readl (regaddr); val &= ~(((1 << group->drvup_width) -1 ) << group->drvup_bit); - val |= hsm << group->drvup_bit; + val |= pus << group->drvup_bit;writel (val, regaddr); }if (srr >=0 ) { val =readl (regaddr); val &= ~(((1 << group->slwr_width) -1 ) << group->slwr_bit); - val |= hsm << group->slwr_bit; + val |= srr << group->slwr_bit;writel (val, regaddr); }if (srf >=0 ) { val =readl (regaddr); val &= ~(((1 << group->slwf_width) -1 ) << group->slwf_bit); - val |= hsm << group->slwf_bit; + val |= srf << group->slwf_bit;writel (val, regaddr); }
Signature · 1 line
2.34.1
Hi Chali,
Thanks for your patch.
Quoted 4 lines · On 7/25/25 06:31, [email protected] wrote:
From: Chali Anis <[email protected]>
Fixes fd940ff6512b ("pinctrl: tegra30: parse drive groups")Signed-off-by Chali Anis <[email protected]>
Reviewed-by Ahmad Fatoum <[email protected]>
Cheers,
Ahmad
Quoted 45 lines
--- drivers/pinctrl/pinctrl-tegra30.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/pinctrl/pinctrl-tegra30.c +5
-5@@ -669,31 +669,31 @@ static int pinctrl_tegra30_set_drvstate(struct pinctrl_tegra30 *ctrl,if (schmitt >=0 ) { val =readl (regaddr); val &= ~(0x1 << group->schmitt_bit); - val |= hsm << group->schmitt_bit; + val |= schmitt << group->schmitt_bit;writel (val, regaddr); }if (pds >=0 ) { val =readl (regaddr); val &= ~(((1 << group->drvdn_width) -1 ) << group->drvdn_bit); - val |= hsm << group->drvdn_bit; + val |= pds << group->drvdn_bit;writel (val, regaddr); }if (pus >=0 ) { val =readl (regaddr); val &= ~(((1 << group->drvup_width) -1 ) << group->drvup_bit); - val |= hsm << group->drvup_bit; + val |= pus << group->drvup_bit;writel (val, regaddr); }if (srr >=0 ) { val =readl (regaddr); val &= ~(((1 << group->slwr_width) -1 ) << group->slwr_bit); - val |= hsm << group->slwr_bit; + val |= srr << group->slwr_bit;writel (val, regaddr); }if (srf >=0 ) { val =readl (regaddr); val &= ~(((1 << group->slwf_width) -1 ) << group->slwf_bit); - val |= hsm << group->slwf_bit; + val |= srf << group->slwf_bit;writel (val, regaddr); }
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Sascha Hauer
AppliedQuoted 1 line · On Fri, 25 Jul 2025 00:31:58 -0400, [email protected] wrote:
Applied, thanks!
[1/1] pinctrl: tegra30: fix typo with variables to control the drive state on nvidia pins.
https://git.pengutronix.de/cgit/barebox/commit/?id=47b3be77fb21 (link may not be stable)
Best regards,
Signature · 1 line
Sascha Hauer <[email protected]>