tools: add support for domain specific Xenstore features
v2 cover tools: add support for domain specific Xenstore features
Add support for limiting the optional Xenstore features via domain configuration. This will be needed when adding features like limiting the scope of Xenstore watch events.
This patch series is handling only the xl/libxl side, libxenstore and C Xenstore (xenstored and xenstore-stubdom). Oxenstored is not covered.
Changes in V2:
- added Jason's Reviewed-by: tags
- a small fix of patch 4
Juergen Gross (7):
tools/libs/store: add get- and set-feature related functions tools/xenstored: support specification of migration stream version tools/xenstored: add missing migration record definitions tools/xenstored: add server feature support tools/xenstored: support SET/GET_FEATURE commands tools/xl: add available Xenstore features to xl info output
tools: allow to limit xenstore features via guest config
docs/man/xl.cfg.5.pod.in | 36 ++++++++ tools/golang/xenlight/helpers.gen.go | 2 + tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 6 ++ tools/include/xenstore.h | 13 +++ tools/libs/light/libxl_dom.c | 12 +++ tools/libs/light/libxl_types.idl | 1 + tools/libs/store/Makefile | 2 +- tools/libs/store/libxenstore.map | 6 ++ tools/libs/store/xs.c | 49 +++++++++++ tools/xenstored/control.c | 6 +- tools/xenstored/core.c | 4 + tools/xenstored/domain.c | 120 ++++++++++++++++++++++++++- tools/xenstored/domain.h | 11 +++ tools/xenstored/lu.c | 35 ++++++-- tools/xenstored/lu.h | 3 +- tools/xenstored/xenstore_state.h | 31 ++++++- tools/xl/Makefile | 3 +- tools/xl/xl_info.c | 22 +++++ tools/xl/xl_parse.c | 3 + tools/xs-clients/xenstore_control.c | 41 ++++++--- 21 files changed, 380 insertions(+), 27 deletions(-)
Signature · 1 line
2.43.0
PATCH v2 1/7 tools/libs/store: add get- and set-feature related functions
Add functions for getting and setting Xenstore features to libxenstore:
xs_get_features_supported(): return the features supported by the running Xenstore implementation as defined in xs_wire.h via the XENSTORE_SERVER_FEATURE_* macros.
xs_get_features_domain(): return the features offered for a specific domain.
xs_set_features_domain(): set the features available for a specific domain.
--- tools/include/xenstore.h | 13 +++++++++ tools/libs/store/Makefile | 2 +- tools/libs/store/libxenstore.map | 6 ++++ tools/libs/store/xs.c | 49 ++++++++++++++++++++++++++++++++ 4 files changed, 69 insertions(+), 1 deletion(-)
tools/include/xenstore.h +13 -0
@@ -264,6 +264,19 @@ bool xs_path_is_subpath(const char *parent, const char *child);*/ bool xs_is_domain_introduced (struct xs_handle *h,unsigned int domid); +/* Get the features supported by Xenstore. +* Returned as a bitmap of XENSTORE_SERVER_FEATURE_* values. +*/ +bool xs_get_features_supported (struct xs_handle *h,unsigned int *features); + +/* Get the features available for a given domain. */ +bool xs_get_features_domain (struct xs_handle *h,unsigned int domid, +unsigned int *features); + +/* Set the features available for a given domain. */ +bool xs_set_features_domain (struct xs_handle *h,unsigned int domid, +unsigned int features); +char *xs_control_command (struct xs_handle *h,const char *cmd,void *data,unsigned int len);/* Deprecated: use xs_control_command() instead. */
tools/libs/store/Makefile +1 -1
@@ -2,7 +2,7 @@ XEN_ROOT=$(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk MAJOR = 4 -MINOR = 0 +MINOR = 1 version-script := libxenstore.map ifeq ($(CONFIG_Linux),y)
tools/libs/store/libxenstore.map +6 -0
@@ -39,3 +39,9 @@ VERS_4.0 { xs_strings_to_perms; local: *; /* Do not expose anything by default */ }; +VERS_4.1 { + global: + xs_get_features_supported; + xs_get_features_domain; + xs_set_features_domain; +} VERS_4.0;
tools/libs/store/xs.c +49 -0
55 lines not on this page · raw message
Signature · 1 line
2.43.0
PATCH v2 2/7 tools/xenstored: support specification of migration stream version
In reply to Juergen GrossIn order to prepare xenstored supporting migration stream versions other than 1, add a parameter to the live update command allowing to specify the version of the migration stream.
This will allow going back from xenstored using version 2 per default to a xenstored only accepting version 1.
For now only version 1 is supported.
--- tools/xenstored/control.c | 6 ++--- tools/xenstored/lu.c | 21 ++++++++++----- tools/xenstored/lu.h | 1 + tools/xs-clients/xenstore_control.c | 41 ++++++++++++++++++++++------- 4 files changed, 50 insertions(+), 19 deletions(-)
tools/xenstored/control.c +3 -3
@@ -289,7 +289,7 @@ static struct cmd_s cmds[] = {* Mini-OS: -b <binary-size> * -d <size> <data-bytes> (multiple of those) * 2. New command-line (optional): -c <cmdline> -* 3. Start of update: -s [-F] [-t <timeout>] +* 3. Start of update: -s [-F] [-t <timeout>] [-v <version>] * Any sub-operation needs to respond with the string "OK" in case * of success, any other response indicates failure. * A started live-update sequence can be aborted via "-a" (not
@@ -297,8 +297,8 @@ static struct cmd_s cmds[] = { * sub-operation). */ { "live-update", do_control_lu, - "[-c <cmdline>] [-F] [-t <timeout>] <file>\n" - " Default timeout is 60 seconds.", 5 }, + "[-c <cmdline>] [-F] [-t <timeout>] [-v <version>] <file>\n" + " Default timeout is 60 seconds, default version is 1.", 7 }, #endif { "logfile", do_control_logfile, "<file>" }, { "memreport", do_control_memreport, "[<file>]" },
tools/xenstored/lu.c +15 -6
@@ -283,7 +283,7 @@ static const char *lu_dump_state(const void *ctx, struct connection *conn)return "Dump state open error" ;memcpy (pre.ident,XS_STATE_IDENT ,sizeof (pre.ident)); - pre.version =htobe32 (XS_STATE_VERSION ); + pre.version =htobe32 (lu_status->version); pre.flags =XS_STATE_FLAGS ;if (fwrite (&pre,sizeof (pre),1 , fp) !=1 ) { ret ="Dump write error" ;
@@ -412,13 +412,16 @@ static bool do_lu_start(struct delayed_request *req) }static const char *lu_start (const void *ctx,struct connection *conn, -bool force,unsigned int to) +bool force,unsigned int to,unsigned int vers) {syslog (LOG_INFO ,"live-update: start, force=%d, to=%u\n" , force, to);if (!lu_status || lu_status->conn != conn)return "Not in live-update session." ; +if (!vers || vers >XS_STATE_VERSION ) +return "Migration stream version not supported." ; +#ifdef __MINIOS__if (lu_status->kernel_size != lu_status->kernel_off)return "Kernel not complete." ;
@@ -426,6 +429,7 @@ static const char *lu_start(const void *ctx, struct connection *conn, lu_status->force = force; lu_status->timeout = to; + lu_status->version = vers; lu_status->started_at =time (NULL ); lu_status->in = conn->in;
@@ -441,6 +445,7 @@ int do_control_lu(const void *ctx, struct connection *conn, const char **vec,unsigned int i;bool force = false;unsigned int to =0 ; +unsigned int vers =XS_STATE_VERSION ;if (num <1 )return EINVAL ;
@@ -457,15 +462,19 @@ int do_control_lu(const void *ctx, struct connection *conn, const char **vec,return EINVAL ; }else if (!strcmp (vec[0 ],"-s" )) {for (i =1 ; i < num; i++) { -if (!strcmp (vec[i],"-F" )) +if (!strcmp (vec[i],"-F" )) { force = true; -else if (!strcmp (vec[i],"-t" ) && i < num -1 ) { + }else if (!strcmp (vec[i],"-t" ) && i < num -1 ) { i++; to =atoi (vec[i]); - }else + }else if (!strcmp (vec[i],"-v" ) && i < num -1 ) { + i++; + vers =atoi (vec[i]); + }else {return EINVAL ; + } } - ret =lu_start (ctx, conn, force, to); + ret =lu_start (ctx, conn, force, to, vers);if (!ret)return errno; }else {
tools/xenstored/lu.h +1 -0
@@ -26,6 +26,7 @@ struct live_update {/* Start parameters. */ bool force;unsigned int timeout; +unsigned int version;time_t started_at; };
tools/xs-clients/xenstore_control.c +31 -10
98 lines not on this page · raw message
Signature · 1 line
2.43.0
PATCH v2 3/7 tools/xenstored: add missing migration record definitions
In reply to Juergen GrossAdd all the missing migration record structures and defines to the xenstore_state.h header file.
Update the version of the migration stream to "2". In order to allow receiving version 1 streams, change the version check of the header to reject only streams with a version higher than the current known one.
--- tools/xenstored/control.c | 2 +- tools/xenstored/lu.c | 2 +- tools/xenstored/xenstore_state.h | 31 ++++++++++++++++++++++++++++++- 3 files changed, 32 insertions(+), 3 deletions(-)
tools/xenstored/control.c +1 -1
@@ -298,7 +298,7 @@ static struct cmd_s cmds[] = { */ { "live-update", do_control_lu, "[-c <cmdline>] [-F] [-t <timeout>] [-v <version>] <file>\n" - " Default timeout is 60 seconds, default version is 1.", 7 }, + " Default timeout is 60 seconds, default version is 2.", 7 }, #endif { "logfile", do_control_logfile, "<file>" }, { "memreport", do_control_memreport, "[<file>]" },
tools/xenstored/lu.c +1 -1
@@ -136,7 +136,7 @@ void lu_read_state(void) pre = state.buf;if (memcmp (pre->ident,XS_STATE_IDENT ,sizeof (pre->ident)) || - pre->version !=htobe32 (XS_STATE_VERSION ) || + !pre->version ||be32toh (pre->version) >XS_STATE_VERSION || pre->flags !=XS_STATE_FLAGS )barf ("Unknown record identifier" ); for (head = state.buf + sizeof(*pre);
tools/xenstored/xenstore_state.h +30 -1
@@ -27,8 +27,10 @@#ifndef htobe32#if __BYTE_ORDER == __LITTLE_ENDIAN#define htobe32 (x) __builtin_bswap32(x) +#define be32toh (x) __builtin_bswap32(x)#else #define htobe32 (x) (x) +#define be32toh (x) (x)#endif #endif
@@ -36,7 +38,7 @@ struct xs_state_preamble {char ident[8 ];#define XS_STATE_IDENT "xenstore"/* To be used without the NUL byte. */ uint32_t version;/* Version in big endian format. */ -#define XS_STATE_VERSION 0x00000001 +#define XS_STATE_VERSION 0x00000002uint32_t flags;/* Endianess. */ #if __BYTE_ORDER == __LITTLE_ENDIAN#define XS_STATE_FLAGS 0x00000000/* Little endian. */
@@ -59,6 +61,9 @@ struct xs_state_record_header {#define XS_STATE_TYPE_WATCH 0x00000003#define XS_STATE_TYPE_TA 0x00000004#define XS_STATE_TYPE_NODE 0x00000005 +#define XS_STATE_TYPE_GLB_QUOTA 0x00000006 +#define XS_STATE_TYPE_DOMAIN 0x00000007 +#define XS_STATE_TYPE_WATCH_EXT 0x00000008uint32_t length;/* Length of record in bytes. */ };
@@ -98,6 +103,15 @@ struct xs_state_watch {uint8_t data[];/* Path bytes, token bytes, 0-7 pad bytes. */ }; +struct xs_state_watch_ext { +uint32_t conn_id;/* Connection this watch is associated with. */ +uint16_t path_length;/* Number of bytes of path watched (incl. 0). */ +uint16_t token_length;/* Number of bytes of watch token (incl. 0). */ +uint16_t depth;/* Number of directory levels below watched path */ +/* to consider for a match. */ +uint8_t data[];/* Path bytes, token bytes, 0-7 pad bytes. */ +}; +/* Transaction: */ struct xs_state_transaction {uint32_t conn_id;/* Connection this TA is associated with. */
@@ -129,4 +143,19 @@ struct xs_state_node {struct xs_state_node_perm perms[]; /* Path and data follows, plus 0-7 pad bytes. */ }; + +/* Global quota data: */ +struct xs_state_glb_quota { +uint16_t n_dom_quota;/* Number of quota values applying to domains. */ +uint16_t n_glob_quota;/* Number of quota values applying globally only. */ +uint32_t quota_val[];/* Array of quota values (domain ones first). */ +}; + +/* Domain data: */ +struct xs_state_domain { +uint16_t domain_id;/* Domain-id identifying the domain. */ +uint16_t n_quota;/* Number of quota values. */ +uint32_t features;/* Server features available to the domain. */ +uint32_t quota_val[];/* Array of quota values. */ +};#endif /* XENSTORE_STATE_H */
Signature · 1 line
2.43.0
PATCH v2 4/7 tools/xenstored: add server feature support
In reply to Juergen GrossAdd per domain server features, which are initialized by the supported features at domain introduction, or by live update from the migration stream. This requires to add the DOMAIN_DATA record to the migration stream, but for now it will only contain the feature word.
Advertise the Xenstore features to guests by setting the appropriate bits in the ring page.
---
V2:
- move setting interface->server_features to introduce_domain()
--- tools/xenstored/domain.c | 60 +++++++++++++++++++++++++++++++++++++++- tools/xenstored/domain.h | 3 ++ tools/xenstored/lu.c | 14 ++++++++-- tools/xenstored/lu.h | 2 +- 4 files changed, 74 insertions(+), 5 deletions(-)
tools/xenstored/domain.c +59 -1
@@ -32,6 +32,7 @@#include "transaction.h" #include "watch.h" #include "control.h" +#include "lu.h" #include <xenevtchn.h> #include <xenmanage.h>
@@ -42,6 +43,8 @@#include <mini-os/xenbus.h> #endif +#define XENSTORE_FEATURES XENSTORE_SERVER_FEATURE_ERROR +static xenmanage_handle *xm_handle;xengnttab_handle **xgt_handle;static evtchn_port_t virq_port;
@@ -115,6 +118,9 @@ struct domain/* Event channel port */ evtchn_port_t port; +/* Server features supported for this domain. */ +unsigned int features; +/* Domain path in store. */ char *path;
@@ -799,6 +805,7 @@ static struct domain *alloc_domain(const void *context, unsigned int domid, domain->unique_id = unique_id; domain->generation = generation; domain->introduced = false; + domain->features =XENSTORE_FEATURES ;if (hashtable_add (domhash, &domain->domid, domain)) {talloc_free (domain);
@@ -992,7 +999,8 @@ void ignore_connection(struct connection *conn, unsigned int err) {trace ("CONN %p ignored, reason %u\n" , conn, err); -if (conn->domain && conn->domain->interface) +if (conn->domain && conn->domain->interface && + (conn->domain->features &XENSTORE_SERVER_FEATURE_ERROR )) conn->domain->interface->error = err; conn->is_ignored = true;
@@ -1032,6 +1040,8 @@ static struct domain *introduce_domain(const void *ctx,return NULL ; } domain->interface = interface; +if (!restore) + interface->server_features = domain->features;if (is_master_domain)setup_structure (restore);
@@ -1849,6 +1859,54 @@ void read_state_connection(const void *ctx, const void *state) } } +static int dump_state_domain (const void *k,void *v,void *arg) +{ +struct domain *domain = v; +FILE *fp = arg; +struct xs_state_domain sd; +struct xs_state_record_header head; + + head.type =XS_STATE_TYPE_DOMAIN ; + head.length =sizeof (sd); +memset (&sd,0 ,sizeof (sd)); + sd.domain_id = domain->domid; + +if (lu_status->version >1 ) + sd.features = domain->features; + +if (fwrite (&head,sizeof (head),1 , fp) !=1 ) +return 1 ; +if (fwrite (&sd,sizeof (sd),1 , fp) !=1 ) +return 1 ; +if (dump_state_align (fp)) +return 1 ; + +return 0 ; +} + +const char *dump_state_domains (FILE *fp) +{ +const char *ret =NULL ; + +if (hashtable_iterate (domhash, dump_state_domain, fp)) + ret ="Dump domain error" ; + +return ret; +} + +void read_state_domain (const void *ctx,const void *state,unsigned int version) +{ +const struct xs_state_domain *sd = state; +struct domain *domain; + + domain =find_domain_struct (sd->domain_id); +if (!domain) +barf ("referenced domain not found" ); + +if (version >1 ) + domain->features = sd->features; +} +struct domain_acc {unsigned int domid;int nodes;
tools/xenstored/domain.h +3 -0
@@ -162,8 +162,11 @@ void wrl_apply_debit_direct(struct connection *conn);void wrl_apply_debit_trans_commit (struct connection *conn);const char *dump_state_connections (FILE *fp); +const char *dump_state_domains (FILE *fp);void read_state_connection (const void *ctx,const void *state); +void read_state_domain (const void *ctx,const void *state, +unsigned int version);struct hashtable *domain_check_acc_init (void );void domain_check_acc_add (const struct node *node,struct hashtable *domains);
tools/xenstored/lu.c +11 -3
@@ -21,6 +21,8 @@#include "lu.h" #include "watch.h" +struct live_update *lu_status; +#ifndef NO_LIVE_UPDATE struct lu_dump_state {
@@ -30,8 +32,6 @@ struct lu_dump_state {char *filename; }; -struct live_update *lu_status; -static int lu_destroy (void *data) { lu_status =NULL ;
@@ -128,6 +128,7 @@ void lu_read_state(void)struct xs_state_record_header *head;void *ctx =talloc_new (NULL );/* Work context for subfunctions. */ struct xs_state_preamble *pre; +unsigned int version;syslog (LOG_INFO ,"live-update: read state\n" );lu_get_dump_state (&state);
@@ -135,8 +136,9 @@ void lu_read_state(void)barf_perror ("No state found after live-update" ); pre = state.buf; + version =be32toh (pre->version);if (memcmp (pre->ident,XS_STATE_IDENT ,sizeof (pre->ident)) || - !pre->version ||be32toh (pre->version) >XS_STATE_VERSION || + !version || version >XS_STATE_VERSION || pre->flags !=XS_STATE_FLAGS )barf ("Unknown record identifier" ); for (head = state.buf + sizeof(*pre);
@@ -159,6 +161,9 @@ void lu_read_state(void)case XS_STATE_TYPE_NODE :read_state_node (ctx, head +1 );break ; +case XS_STATE_TYPE_DOMAIN : +read_state_domain (ctx, head +1 , version); +break ;default :xprintf ("live-update: unknown state record %08x\n" , head->type);
@@ -297,6 +302,9 @@ static const char *lu_dump_state(const void *ctx, struct connection *conn)if (ret) goto out; ret =dump_state_nodes (fp, ctx); +if (ret) + goto out; + ret =dump_state_domains (fp);if (ret) goto out;
tools/xenstored/lu.h +1 -1
@@ -5,7 +5,6 @@* Copyright (C) 2022 Juergen Gross, SUSE LLC */ -#ifndef NO_LIVE_UPDATEstruct live_update {/* For verification the correct connection is acting. */ struct connection *conn;
@@ -32,6 +31,7 @@ struct live_update {extern struct live_update *lu_status; +#ifndef NO_LIVE_UPDATE struct connection *lu_get_connection (void );bool lu_is_pending (void );void lu_read_state (void );
Signature · 1 line
2.43.0
Re: [PATCH v2 4/7] tools/xenstored: add server feature support
Quoted 9 lines · Juergen Gross
Add per domain server features, which are initialized by the supported features at domain introduction, or by live update from the migration stream. This requires to add the
DOMAIN_DATArecord to the migration stream, but for now it will only contain the feature word.Advertise the Xenstore features to guests by setting the appropriate bits in the ring page.
Signed-off-by Juergen Gross <[email protected]>
Thanks,
Jason
PATCH v2 5/7 tools/xenstored: support SET/GET_FEATURE commands
In reply to Juergen GrossAdd support for XS_SET_FEATURE and XS_GET_FEATURE to xenstored.
--- tools/xenstored/core.c | 4 +++ tools/xenstored/domain.c | 60 ++++++++++++++++++++++++++++++++++++++++ tools/xenstored/domain.h | 8 ++++++ 3 files changed, 72 insertions(+)
tools/xenstored/core.c +4 -0
@@ -2031,6 +2031,10 @@ static struct { { "SET_TARGET", do_set_target, XS_FLAG_PRIV }, [XS_RESET_WATCHES] = { "RESET_WATCHES", do_reset_watches }, [XS_DIRECTORY_PART] = { "DIRECTORY_PART", send_directory_part }, + [XS_GET_FEATURE ] = + { "GET_FEATURE", do_get_feature, XS_FLAG_PRIV }, + [XS_SET_FEATURE ] = + { "SET_FEATURE", do_set_feature, XS_FLAG_PRIV }, };static const char *sockmsg_string (enum xsd_sockmsg_type type)
tools/xenstored/domain.c +60 -0
66 lines not on this page · raw message
tools/xenstored/domain.h +8 -0
@@ -82,6 +82,14 @@ int do_get_domain_path(const void *ctx, struct connection *conn,int do_reset_watches (const void *ctx,struct connection *conn,struct buffered_data *in); +/* Get global or per domain server features */ +int do_get_feature (const void *ctx,struct connection *conn, +struct buffered_data *in); + +/* Set per domain server features */ +int do_set_feature (const void *ctx,struct connection *conn, +struct buffered_data *in); +void domain_early_init (void );void domain_init (int evtfd);void dom0_init (void );
Signature · 1 line
2.43.0
PATCH v2 6/7 tools/xl: add available Xenstore features to xl info output
In reply to Juergen GrossAdd the Xenstore feature value to the output of "xl info" in order to prepare for a future capability to limit Xenstore features visible by a guest.
--- tools/xl/Makefile | 3 ++- tools/xl/xl_info.c | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-)
tools/xl/Makefile +2 -1
@@ -13,6 +13,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS) CFLAGS_XL += $(CFLAGS_libxenlight) CFLAGS_XL += $(CFLAGS_libxenutil) +CFLAGS_XL += $(CFLAGS_libxenstore) CFLAGS_XL += -Wshadow XL_OBJS-$(CONFIG_X86) = xl_psr.o
@@ -32,7 +33,7 @@ $(XL_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs i all: xl xl: $(XL_OBJS) - $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) -lyajl $(APPEND_LDFLAGS) .PHONY: install install: all
tools/xl/xl_info.c +22 -0
@@ -28,6 +28,7 @@#include <libxl_utils.h> #include <libxlutil.h> #include <xen-tools/arm-arch-capabilities.h> +#include <xenstore.h> #include "xl.h" #include "xl_utils.h"
@@ -333,6 +334,25 @@ static void output_topologyinfo(void)return ; } +static void output_xenstore_info (void ) +{ +struct xs_handle *xsh; +unsigned int features =0 ; + + xsh =xs_open (0 ); +if (!xsh) { +fprintf (stderr,"xs_open failed.\n" ); +return ; + } + +/* Ignore error, default to "0" for features. */ +xs_get_features_supported (xsh, &features); + +maybe_printf ("xenstore_features : 0x%08x\n" , features); + +xs_close (xsh); +} +static void print_info (int numa) {output_nodeinfo ();
@@ -345,6 +365,8 @@ static void print_info(int numa) }output_xeninfo (); +output_xenstore_info (); +maybe_printf ("xend_config_format : 4\n" );return ;
Signature · 1 line
2.43.0
Re: [PATCH v2 6/7] tools/xl: add available Xenstore features to xl info output
Quoted 6 lines · Juergen Gross
Add the Xenstore feature value to the output of "xl info" in order to prepare for a future capability to limit Xenstore features visible by a guest.
Signed-off-by Juergen Gross <[email protected]>Reviewed-by Jason Andryuk <[email protected]>
Thanks,
Signature · 1 line
Anthony PERARD
PATCH v2 7/7 tools: allow to limit xenstore features via guest config
In reply to Juergen GrossAdd a guest config parameter "xenstore_feature_mask" allowing to limit the Xenstore features the guest can see and use. This can be needed in order to allow migrating a guest to a host running a Xenstore version providing less features than the source host.
---
V2:
- fix typo (Jason Andryuk)
--- docs/man/xl.cfg.5.pod.in | 36 ++++++++++++++++++++++++++++ tools/golang/xenlight/helpers.gen.go | 2 ++ tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 6 +++++ tools/libs/light/libxl_dom.c | 12 ++++++++++ tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 3 +++ 7 files changed, 61 insertions(+)
docs/man/xl.cfg.5.pod.in +36 -0
@@ -714,6 +714,42 @@ If this option is not specified then it will default to B<false>. =back +=head3 Xenstore related settings + +=over 4 + +=item B<xenstore_feature_mask=NUMBER> + +Specify which Xenstore features are visible for the guest. + +This might be needed when a guest should be able to be migrated to a host +running a Xenstore implementation with less features than the one the guest +is created on. + +The visible features are specified via a binary or of the following +values: + +=over 4 + +=item B<0x00000001> + +Xenstore is capable to reconnect to a guest. + +=item B<0x00000002> + +Xenstore will present an error value in case it disconnects due to an error +condition. + +=back + +The features supported by the running Xenstore instance can be retrieved +via the B<xl info> command in dom0. + +The default value is B<0xffffffff>, meaning that all possible Xenstore +features are visible by the guest. + +=back + =head2 Devices The following options define the paravirtual, emulated and physical
tools/golang/xenlight/helpers.gen.go +2 -0
@@ -1174,6 +1174,7 @@ return fmt.Errorf("converting field Vpmu: %v", err) if err := x.TrapUnmappedAccesses.fromC(&xc.trap_unmapped_accesses);err != nil { return fmt.Errorf("converting field TrapUnmappedAccesses: %v", err) } +x.XenstoreFeatureMask = uint32(xc.xenstore_feature_mask) return nil}
@@ -1708,6 +1709,7 @@ return fmt.Errorf("converting field Vpmu: %v", err) if err := x.TrapUnmappedAccesses.toC(&xc.trap_unmapped_accesses); err != nil { return fmt.Errorf("converting field TrapUnmappedAccesses: %v", err) } +xc.xenstore_feature_mask = C.uint32_t(x.XenstoreFeatureMask) return nil }
tools/golang/xenlight/types.gen.go +1 -0
@@ -607,6 +607,7 @@ Altp2M Altp2MMode VmtraceBufKb int Vpmu Defbool TrapUnmappedAccesses Defbool +XenstoreFeatureMask uint32 } type DomainBuildInfoTypeUnion interface {
tools/include/libxl.h +6 -0
@@ -654,6 +654,12 @@*/ #define LIBXL_HAVE_DT_OVERLAY_DOMAIN 1 +/* +* LIBXL_HAVE_XENSTORE_FEATURE_MASK indicates the presence of +* xenstore_feature_mask in struct libxl_domain_build_info. +*/ +#define LIBXL_HAVE_XENSTORE_FEATURE_MASK 1 +/* * libxl memory management *
tools/libs/light/libxl_dom.c +12 -0
@@ -494,6 +494,18 @@ retry_transaction:if (!xs_transaction_end (ctx->xsh, t,0 ))if (errno ==EAGAIN ) goto retry_transaction; + +if (info->xenstore_feature_mask != ~0U ) { +unsigned int features; + +if (xs_get_features_supported (ctx->xsh, &features) && + !xs_set_features_domain (ctx->xsh, domid, + features & info->xenstore_feature_mask)) { +LOG (ERROR ,"Failed to set Xenstore features" ); +return ERROR_FAIL ; + } + } +xs_introduce_domain (ctx->xsh, domid, state->store_mfn, state->store_port);free (vm_path);return 0 ;
tools/libs/light/libxl_types.idl +1 -0
@@ -738,6 +738,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("vpmu", libxl_defbool), ("trap_unmapped_accesses", libxl_defbool), + ("xenstore_feature_mask", uint32, {'init_val': '~0U'}), ], dir=DIR_IN, copy_deprecated_fn="libxl__domain_build_info_copy_deprecated",
tools/xl/xl_parse.c +3 -0
@@ -1409,6 +1409,9 @@ void parse_config_data(const char *config_source,if (!xlu_cfg_get_string (config,"pool" , &buf,0 ))xlu_cfg_replace_string (config,"pool" , &c_info->pool_name,0 ); +if (!xlu_cfg_get_long (config,"xenstore_feature_mask" , &l,0 )) + b_info->xenstore_feature_mask = l; +libxl_domain_build_info_init_type (b_info, c_info->type);if (b_info->type ==LIBXL_DOMAIN_TYPE_PVH ) {
Signature · 1 line
2.43.0
Re: [PATCH v2 7/7] tools: allow to limit xenstore features via guest config
Quoted 11 lines · Juergen Gross
Add a guest config parameter "
xenstore_feature_mask" allowing to limit the Xenstore features the guest can see and use. This can be needed in order to allow migrating a guest to a host running a Xenstore version providing less features than the source host.Signed-off-by Juergen Gross <[email protected]>Reviewed-by Jason Andryuk <[email protected]>---
V2:
- fix typo (Jason Andryuk)
Quoted 10 lines
--- docs/man/xl.cfg.5.pod.in | 36 ++++++++++++++++++++++++++++ tools/golang/xenlight/helpers.gen.go | 2 ++ tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 6 +++++ tools/libs/light/libxl_dom.c | 12 ++++++++++ tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 3 +++ 7 files changed, 61 insertions(+)
For tools/golang:
Re: [PATCH v2 7/7] tools: allow to limit xenstore features via guest config
In reply to Juergen GrossQuoted 6 lines · Juergen Gross
tools/libs/light/libxl_dom.c +0
-0@@ -494,6 +494,18 @@ retry_transaction:if (!xs_transaction_end (ctx->xsh, t,0 ))
tools/libs/light/libxl_dom.c retry_transaction: · line 504
Quoted 10 lines
tools/libs/light/libxl_dom.c +8
-0if (errno ==EAGAIN ) goto retry_transaction; + +if (info->xenstore_feature_mask != ~0U ) { +unsigned int features; + +if (xs_get_features_supported (ctx->xsh, &features) && + !xs_set_features_domain (ctx->xsh, domid, + features & info->xenstore_feature_mask)) { +LOG (ERROR ,"Failed to set Xenstore features" );
Surly xs_{get,set}* set errno on failure, and we know the domid, can you use LOGED for the error message?
tools/libs/light/libxl_dom.c retry_transaction: · line 505
Quoted 1 line
tools/libs/light/libxl_dom.c +1
-0+return ERROR_FAIL ;
Unfortunately, this function does an allocation that isn't collected in GC, vm_path is leaked. Could you replace that by rc=ERROR_FAIL; goto out;, then place out: at the right place and return rc at the end of the function?
tools/libs/light/libxl_dom.c retry_transaction: · line 511
Quoted 6 lines
tools/libs/light/libxl_dom.c +3
-0+ } + } +xs_introduce_domain (ctx->xsh, domid, state->store_mfn, state->store_port);free (vm_path);return 0 ;
Thanks,
Signature · 1 line
Anthony PERARD
Re: [PATCH v2 7/7] tools: allow to limit xenstore features via guest config
Quoted 12 lines · Anthony PERARD
Quoted 11 lines · Juergen Gross
tools/libs/light/libxl_dom.c +3
-0@@ -494,6 +494,18 @@ retry_transaction:if (!xs_transaction_end (ctx->xsh, t,0 ))if (errno ==EAGAIN ) goto retry_transaction; + +if (info->xenstore_feature_mask != ~0U ) { +unsigned int features;
Quoted 8 lines
tools/libs/light/libxl_dom.c retry_transaction: · line 504
Quoted 5 lines
tools/libs/light/libxl_dom.c +5
-0+ +if (xs_get_features_supported (ctx->xsh, &features) && + !xs_set_features_domain (ctx->xsh, domid, + features & info->xenstore_feature_mask)) { +LOG (ERROR ,"Failed to set Xenstore features" );Surly xs_{get,set}* set errno on failure, and we know the domid, can you use LOGED for the error message?
Okay.
Quoted 7 lines
tools/libs/light/libxl_dom.c retry_transaction: · line 505
Quoted 2 lines
tools/libs/light/libxl_dom.c +1
-0+return ERROR_FAIL ;Unfortunately, this function does an allocation that isn't collected in GC,
vm_pathis leaked. Could you replace that byrc=ERROR_FAIL; goto out;, then place out: at the right place and returnrcat the end of the function?
Yes, of course.
Thanks,
Juergen