mm/damon/vaddr: Skip isolating folios already in destination nid
Subsystems (2)
PATCH 1/1 mm/damon/vaddr: Skip isolating folios already in destination nid
From: Bijan Tabatabai <[email protected]>
damos_va_migrate_dests_add() determines the node a folio should be in based on the struct damos_migrate_dests associated with the migration scheme and adds the folio to the linked list corresponding to that node so it can be migrated later. Currently, folios are isolated and added to the list even if they are already in the node they should be in.
In using damon weighted interleave more, I've found that the overhead of needlessly adding these folios to the migration lists can be quite high. The overhead comes from isolating folios and placing them in the migration lists inside of damos_va_migrate_dests_add(), as well as the cost of handling those folios in damon_migrate_pages(). This patch eliminates that overhead by simply avoiding the addition of folios that are already in their intended location to the migration list.
To show the benefit of this patch, we start the test workload and start a DAMON instance attached to that workload with a migrate_hot scheme that has one dest field sending data to the local node. This way, we are only measuring the overheads of the scheme, and not the cost of migrating pages, since data will be allocated to the local node by default. I tested with two workloads: the embedding reduction workload used in [1] and a microbenchmark that allocates 20GB of data then sleeps, which is similar to the memory usage of the embedding reduction workload.
The time taken in damos_va_migrate_dests_add() and damon_migrate_pages() each aggregation interval is shown below.
Before this patch:
damos_va_migrate_dests_add damon_migrate_pages
microbenchmark ~2ms ~3ms embedding reduction ~1s ~3s
After this patch:
damos_va_migrate_dests_add damon_migrate_pages
microbenchmark 0us ~40us embedding reduction 0us ~100us
I did not do an in depth analysis for why things are much slower in the embedding reduction workload than the microbenchmark. However, I assume it's because the embedding reduction workload oversaturates the bandwidth of the local memory node, increasing the memory access latency, and in turn making the pointer chasing involved in iterating through a linked list much slower.
Regardless of that, this patch results in a significant speedup.
[1] https://lore.kernel.org/damon/[email protected]/
---
Sorry I missed this in the original patchset!
mm/damon/vaddr.c | 4 ++++ 1 file changed, 4 insertions(+)
mm/damon/vaddr.c +4 -0
@@ -711,6 +711,10 @@ static void damos_va_migrate_dests_add(struct folio *folio, target -= dests->weight_arr[i]; } +/* If the folio is already in the right node, don't do anything */ +if (folio_nid (folio) == dests->node_id_arr[i]) +return ; + isolate:if (!folio_isolate_lru (folio))return ;
Signature · 1 line
2.43.5
Quoted 15 lines · On Fri, 25 Jul 2025 11:33:00 -0500 Bijan Tabatabai <[email protected]> wrote:
From: Bijan Tabatabai <[email protected]>
damos_va_migrate_dests_add()determines the node a folio should be in based on the structdamos_migrate_destsassociated with the migration scheme and adds the folio to the linked list corresponding to that node so it can be migrated later. Currently, folios are isolated and added to the list even if they are already in the node they should be in.In using damon weighted interleave more, I've found that the overhead of needlessly adding these folios to the migration lists can be quite high. The overhead comes from isolating folios and placing them in the migration lists inside of
damos_va_migrate_dests_add(), as well as the cost of handling those folios indamon_migrate_pages(). This patch eliminates that overhead by simply avoiding the addition of folios that are already in their intended location to the migration list.
[...]
Quoted 1 line
Signed-off-by Bijan Tabatabai <[email protected]>
Quoted 2 lines
---
Sorry I missed this in the original patchset!
No worry!
Andrew, could we squash this into commit 19c1dc15c859 ("mm/damon/vaddr: use damos->migrate_dests in migrate_{hot,cold}") on mm-stable? I think this is just a simple fixup.
Quoted 21 lines
mm/damon/vaddr.c | 4 ++++ 1 file changed, 4 insertions(+)mm/damon/vaddr.c +4
-0@@ -711,6 +711,10 @@ static void damos_va_migrate_dests_add(struct folio *folio, target -= dests->weight_arr[i]; } +/* If the folio is already in the right node, don't do anything */ +if (folio_nid (folio) == dests->node_id_arr[i]) +return ; + isolate:if (!folio_isolate_lru (folio))return ;Signature · 1 line
2.43.5
Thanks,
SJ
SeongJae Park
maintainer+ Andrew
Quoted 57 lines · On Fri, 25 Jul 2025 12:36:37 -0700 SeongJae Park <[email protected]> wrote:
Quoted 15 lines · On Fri, 25 Jul 2025 11:33:00 -0500 Bijan Tabatabai <[email protected]> wrote:
From: Bijan Tabatabai <[email protected]>
damos_va_migrate_dests_add()determines the node a folio should be in based on the structdamos_migrate_destsassociated with the migration scheme and adds the folio to the linked list corresponding to that node so it can be migrated later. Currently, folios are isolated and added to the list even if they are already in the node they should be in.In using damon weighted interleave more, I've found that the overhead of needlessly adding these folios to the migration lists can be quite high. The overhead comes from isolating folios and placing them in the migration lists inside of
damos_va_migrate_dests_add(), as well as the cost of handling those folios indamon_migrate_pages(). This patch eliminates that overhead by simply avoiding the addition of folios that are already in their intended location to the migration list.[...]
Quoted 1 line
Signed-off-by Bijan Tabatabai <[email protected]>Reviewed-by SeongJae Park <[email protected]>Quoted 2 lines
---
Sorry I missed this in the original patchset!No worry!
Andrew, could we squash this into commit
19c1dc15c859("mm/damon/vaddr: usedamos->migrate_destsin migrate_{hot,cold}") on mm-stable? I think this is just a simple fixup.Quoted 21 lines
mm/damon/vaddr.c | 4 ++++ 1 file changed, 4 insertions(+)mm/damon/vaddr.c +4
-0@@ -711,6 +711,10 @@ static void damos_va_migrate_dests_add(struct folio *folio, target -= dests->weight_arr[i]; } +/* If the folio is already in the right node, don't do anything */ +if (folio_nid (folio) == dests->node_id_arr[i]) +return ; + isolate:if (!folio_isolate_lru (folio))return ;Signature · 1 line
2.43.5Thanks,
SJ
Quoted 60 lines · Bijan Tabatabai
From: Bijan Tabatabai <[email protected]>
damos_va_migrate_dests_add()determines the node a folio should be in based on the structdamos_migrate_destsassociated with the migration scheme and adds the folio to the linked list corresponding to that node so it can be migrated later. Currently, folios are isolated and added to the list even if they are already in the node they should be in.In using damon weighted interleave more, I've found that the overhead of needlessly adding these folios to the migration lists can be quite high. The overhead comes from isolating folios and placing them in the migration lists inside of
damos_va_migrate_dests_add(), as well as the cost of handling those folios indamon_migrate_pages(). This patch eliminates that overhead by simply avoiding the addition of folios that are already in their intended location to the migration list.To show the benefit of this patch, we start the test workload and start a DAMON instance attached to that workload with a
migrate_hotscheme that has one dest field sending data to the local node. This way, we are only measuring the overheads of the scheme, and not the cost of migrating pages, since data will be allocated to the local node by default. I tested with two workloads: the embedding reduction workload used in [1] and a microbenchmark that allocates 20GB of data then sleeps, which is similar to the memory usage of the embedding reduction workload.The time taken in
damos_va_migrate_dests_add()anddamon_migrate_pages()each aggregation interval is shown below.Before this patch:
damos_va_migrate_dests_adddamon_migrate_pagesmicrobenchmark ~2ms ~3ms embedding reduction ~1s ~3sAfter this patch:
damos_va_migrate_dests_adddamon_migrate_pagesmicrobenchmark 0us ~40us embedding reduction 0us ~100usI did not do an in depth analysis for why things are much slower in the embedding reduction workload than the microbenchmark. However, I assume it's because the embedding reduction workload oversaturates the bandwidth of the local memory node, increasing the memory access latency, and in turn making the pointer chasing involved in iterating through a linked list much slower.
Regardless of that, this patch results in a significant speedup.[1] https://lore.kernel.org/damon/[email protected]/
Signed-off-by Bijan Tabatabai <[email protected]>---
Sorry I missed this in the original patchset!mm/damon/vaddr.c | 4 ++++ 1 file changed, 4 insertions(+)mm/damon/vaddr.c +0
-0
mm/damon/vaddr.c static void damos_va_migrate_dests_add(struct folio *folio, · line 717
Quoted 7 lines
mm/damon/vaddr.c +4
-0@@ -711,6 +711,10 @@ static void damos_va_migrate_dests_add(struct folio *folio, target -= dests->weight_arr[i]; } +/* If the folio is already in the right node, don't do anything */ +if (folio_nid (folio) == dests->node_id_arr[i]) +return ; +
I have seen good improvements with similar changes in PTE A bit scan based patches.
Feel free to add
Quoted 3 lines
mm/damon/vaddr.c +0
-0isolate:if (!folio_isolate_lru (folio))return ;