Skip to contentSkip to conversation

selftests: bpf: fix legacy netfilter options

PATCH Applied Jakub Kicinski 3 participants 4 messages Jul 26, 2025

Subsystems (5)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 selftests: bpf: fix legacy netfilter options

Recent commit to add NETFILTER_XTABLES_LEGACY missed setting a couple of configs to y. They are still enabled but as modules which appears to have upset BPF CI, e.g.:

   test_bpf_nf_ct:FAIL:iptables-legacy -t raw -A PREROUTING -j CONNMARK --set-mark 42/0 unexpected error: 768 (errno 0)
Fixes 3c3ab65f00eb ("selftests: net: Enable legacy netfilter legacy options.")

---
Targeting net-next 'cause that's where the bad commit is.

---
 tools/testing/selftests/bpf/config | 2 ++
 1 file changed, 2 insertions(+)
tools/testing/selftests/bpf/config +2 -0
index 521836776733..e8c6c77b96cb 100644
@@ -97,6 +97,8 @@ CONFIG_NF_TABLES_NETDEV=y
 CONFIG_NF_TABLES_IPV4=y
 CONFIG_NF_TABLES_IPV6=y
 CONFIG_NETFILTER_INGRESS=y
+CONFIG_IP_NF_IPTABLES_LEGACY=y
+CONFIG_IP6_NF_IPTABLES_LEGACY=y
 CONFIG_NETFILTER_XTABLES_LEGACY=y
 CONFIG_NF_FLOW_TABLE=y
 CONFIG_NF_FLOW_TABLE_INET=y
Signature · 1 line
2.50.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jakub Kicinski

Recent commit to add NETFILTER_XTABLES_LEGACY missed setting a couple of configs to y. They are still enabled but as modules which appears to have upset BPF CI, e.g.:

    test_bpf_nf_ct:FAIL:iptables-legacy -t raw -A PREROUTING -j CONNMARK --set-mark 42/0 unexpected error: 768 (errno 0)
Fixes 3c3ab65f00eb ("selftests: net: Enable legacy netfilter legacy options.")
author maintainer
#2 lore raw
Quoted 11 lines · On Sat, 26 Jul 2025 20:54:33 +0200 Daniel Borkmann wrote:
Quoted 8 lines · Jakub Kicinski

Recent commit to add NETFILTER_XTABLES_LEGACY missed setting a couple of configs to y. They are still enabled but as modules which appears to have upset BPF CI, e.g.:

    test_bpf_nf_ct:FAIL:iptables-legacy -t raw -A PREROUTING -j CONNMARK --set-mark 42/0 unexpected error: 768 (errno 0)
Fixes 3c3ab65f00eb ("selftests: net: Enable legacy netfilter legacy options.")

Thank you for the quick ack!

#3 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Sat, 26 Jul 2025 08:53:49 -0700 you wrote:

Recent commit to add NETFILTER_XTABLES_LEGACY missed setting a couple of configs to y. They are still enabled but as modules which appears to have upset BPF CI, e.g.:

   test_bpf_nf_ct:FAIL:iptables-legacy -t raw -A PREROUTING -j CONNMARK --set-mark 42/0 unexpected error: 768 (errno 0)
Fixes 3c3ab65f00eb ("selftests: net: Enable legacy netfilter legacy options.")

[...]

Here is the summary with links:
- [net-next] selftests: bpf: fix legacy netfilter options

    https://git.kernel.org/netdev/net-next/c/38b74b212a34

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html