spacemit: introduce P1 PMIC support
Subsystems (6)
v10 cover spacemit: introduce P1 PMIC support
The SpacemiT P1 is an I2C-controlled PMIC that implements 6 buck converters and 12 LDOs. It contains a load switch, ADC channels, GPIOs, a real-time clock, and a watchdog timer.
This series introduces a multifunction driver for the P1 PMIC as well as drivers for its regulators and RTC.
This version makes a few minor changes to DTS files suggested by Yixun Lan. It also reworks the function that determines the regmap_config structure to use, and adds a function that frees that structure when it's no longer needed (if it was dynamically allocated).
-Alex
This series is available here:
https://github.com/riscstar/linux/tree/outgoing/pmic-v10
Between version 9 and version 10:
- The #address-cells and #size-cells for the i2c8 DTS node were moved into its primary definition in "k1.dtsi".
- The interrupts property for the i2c8 DTS node was moved below its clock-related properties.
- The status property in the pmic@41 DTS node was dropped.
- The function that provides the regmap_config structure to use was reworked a bit.
- A new function was added to free the regmap_config structure after it's no longer needed.
Here is version 9 of this series:
https://lore.kernel.org/lkml/[email protected]/
Between version 8 and version 9:
- The max_config value is always used if it is provided with the simple_mfd_data structure.
- The regmap_config structure used is allocated dynamically if necessary; otherwise regmap_config_8r_8v is used.
- A small duplicated comment is removed
Here is version 8 of this series:
https://lore.kernel.org/lkml/[email protected]/
More complete history is available at that link.
Alex Elder (8):
dt-bindings: mfd: add support the SpacemiT P1 PMIC
mfd: simple-mfd-i2c: specify max_register
mfd: simple-mfd-i2c: add SpacemiT P1 support
regulator: spacemit: support SpacemiT P1 regulators
rtc: spacemit: support the SpacemiT P1 RTC
riscv: dts: spacemit: enable the i2c8 adapter
riscv: dts: spacemit: define fixed regulators
riscv: dts: spacemit: define regulator constraints
.../devicetree/bindings/mfd/spacemit,p1.yaml | 86 +++++++++ .../boot/dts/spacemit/k1-bananapi-f3.dts | 135 ++++++++++++++ arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi | 7 + arch/riscv/boot/dts/spacemit/k1.dtsi | 13 ++ drivers/mfd/Kconfig | 11 ++ drivers/mfd/simple-mfd-i2c.c | 57 +++++- drivers/mfd/simple-mfd-i2c.h | 5 +- drivers/regulator/Kconfig | 12 ++ drivers/regulator/Makefile | 1 + drivers/regulator/spacemit-p1.c | 157 ++++++++++++++++ drivers/rtc/Kconfig | 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-spacemit-p1.c | 167 ++++++++++++++++++ 13 files changed, 653 insertions(+), 9 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/spacemit,p1.yaml create mode 100644 drivers/regulator/spacemit-p1.c create mode 100644 drivers/rtc/rtc-spacemit-p1.c
base-commit: d7af19298454ed155f5cf67201a70f5cf836c842
Signature · 1 line
2.48.1
PATCH v10 1/8 dt-bindings: mfd: add support the SpacemiT P1 PMIC
Enable the SpacemiT P1, which is an I2C-controlled PMIC. Initially only the RTC and regulators will be supported.
--- .../devicetree/bindings/mfd/spacemit,p1.yaml | 86 +++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/spacemit,p1.yaml
Documentation/devicetree/bindings/mfd/spacemit,p1.yaml new file +86 -0
@@ -0,0 +1,86 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/spacemit,p1.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: SpacemiT P1 Power Management Integrated Circuit + +maintainers: + - Troy Mitchell <[email protected]> + +description: + P1 is an I2C-controlled PMIC produced by SpacemiT. It implements six + constant-on-time buck converters and twelve low-dropout regulators. + It also contains a load switch, watchdog timer, real-time clock, eight + 12-bit ADC channels, and six GPIOs. Additional details are available + in the "Power Stone/P1" section at the following link. + https://developer.spacemit.com/documentation + +properties: + compatible: + const: spacemit,p1 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + vin-supply: + description: Input supply phandle. + + regulators: + type: object + + patternProperties: + "^(buck[1-6]|aldo[1-4]|dldo[1-7])$": + type: object + $ref: /schemas/regulator/regulator.yaml# + unevaluatedProperties: false + + unevaluatedProperties: false + +required: + - compatible + - reg + - interrupts + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pmic@41 { + compatible = "spacemit,p1"; + reg = <0x41>; + interrupts = <64>; + + regulators { + buck1 { + regulator-name = "buck1"; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3450000>; + regulator-ramp-delay = <5000>; + regulator-always-on; + }; + + aldo1 { + regulator-name = "aldo1"; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + regulator-boot-on; + }; + + dldo1 { + regulator-name = "dldo1"; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + regulator-boot-on; + }; + }; + }; + };
Signature · 1 line
2.48.1
PATCH v10 2/8 mfd: simple-mfd-i2c: specify max_register
In reply to Alex ElderAll devices supported by simple MFD use the same 8-bit register 8-bit value regmap configuration. There is an option available for a device to specify a custom configuration, but no existing device uses it.
Rather than requiring a "full" regmap configuration to be provided to change only the max_register value, Lee Jones suggested allowing max_register to be specified in the simple_mfd_data structure. The 8-bit register 8-bit configuration is still used by default, but max_register is also applied if it is non-zero.
If both regmap_config and max_register are provided, the max_register field in the regmap_config structure is ignored.
---
v10: - Rename simple_regmap_config() -> simple_regmap_config_get()
- Introduce simple_regmap_config_put() to free regmap_config
drivers/mfd/simple-mfd-i2c.c | 45 ++++++++++++++++++++++++++++++++---- drivers/mfd/simple-mfd-i2c.h | 5 +--- 2 files changed, 41 insertions(+), 9 deletions(-)
drivers/mfd/simple-mfd-i2c.c +40 -5
@@ -29,6 +29,40 @@ static const struct regmap_config regmap_config_8r_8v = { .val_bits = 8, }; +static const struct regmap_config * +simple_regmap_config_get (const struct simple_mfd_data *data) +{ +struct regmap_config *regmap_config; +const struct regmap_config *source; + +if (!data) +return ®map_config_8r_8v; + + source = data->regmap_config ? : ®map_config_8r_8v; + +if (!data->max_register) +return source; + + regmap_config =kmemdup (source,sizeof (*regmap_config),GFP_KERNEL ); +if (regmap_config) + regmap_config->max_register = data->max_register; + +return regmap_config; +} + +static void simple_regmap_config_put (const struct simple_mfd_data *data, +const struct regmap_config *regmap_config) +{ +/* This condition holds if data is null */ +if (regmap_config == ®map_config_8r_8v) +return ; + +if (regmap_config == data->regmap_config) +return ; + +kfree (regmap_config); +} +static int simple_mfd_i2c_probe (struct i2c_client *i2c) {const struct simple_mfd_data *simple_mfd_data;
@@ -38,13 +72,14 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c) simple_mfd_data =device_get_match_data (&i2c->dev); -/* If no regmap_config is specified, use the default 8reg and 8val bits */ -if (!simple_mfd_data || !simple_mfd_data->regmap_config) - regmap_config = ®map_config_8r_8v; -else - regmap_config = simple_mfd_data->regmap_config; + regmap_config =simple_regmap_config_get (simple_mfd_data); +if (!regmap_config) +return -ENOMEM ; regmap =devm_regmap_init_i2c (i2c, regmap_config); + +simple_regmap_config_put (simple_mfd_data, regmap_config); +if (IS_ERR (regmap))return PTR_ERR (regmap);
drivers/mfd/simple-mfd-i2c.h +1 -4
@@ -8,10 +8,6 @@* shared by all sub-devices. Children can use their parent's device structure * (dev.parent) in order to reference it. * -* This driver creates a single register map with the intention for it to be -* shared by all sub-devices. Children can use their parent's device structure -* (dev.parent) in order to reference it. -* * Once the register map has been successfully initialised, any sub-devices * represented by child nodes in Device Tree or via the MFD cells in the * associated C file will be subsequently registered.
@@ -25,6 +21,7 @@struct simple_mfd_data {const struct regmap_config *regmap_config; +unsigned int max_register;const struct mfd_cell *mfd_cell;size_t mfd_cell_size; };
Signature · 1 line
2.48.1
Lee Jones
maintainerRe: [PATCH v10 2/8] mfd: simple-mfd-i2c: specify max_register
Quoted 15 lines · Alex Elder
All devices supported by simple MFD use the same 8-bit register 8-bit value regmap configuration. There is an option available for a device to specify a custom configuration, but no existing device uses it.
Rather than requiring a "full" regmap configuration to be provided to change only the
max_registervalue, Lee Jones suggested allowingmax_registerto be specified in thesimple_mfd_datastructure. The 8-bit register 8-bit configuration is still used by default, butmax_registeris also applied if it is non-zero.If both
regmap_configandmax_registerare provided, themax_registerfield in theregmap_configstructure is ignored.Signed-off-by Alex Elder <[email protected]>Suggested-by Lee Jones <[email protected]>
Quoted 7 lines
---
v10: - Renamesimple_regmap_config()->simple_regmap_config_get()
- Introducesimple_regmap_config_put()to freeregmap_configdrivers/mfd/simple-mfd-i2c.c | 45 ++++++++++++++++++++++++++++++++---- drivers/mfd/simple-mfd-i2c.h | 5 +--- 2 files changed, 41 insertions(+), 9 deletions(-)
This has gone from an in-function 11 line change to 50 lines and the inclusion of 2 new functions. As much as I _really_ appreciate the time and effort you have put into this [0], the added complexity being added here doesn't sit right with me. How would you like to go back to your v4 idea of providing a bespoke regmap_config for for device?
[0] Beers on me for sending you down this path!
Signature · 1 line
Lee Jones [李琼斯]
Re: [PATCH v10 2/8] mfd: simple-mfd-i2c: specify max_register
Quoted 25 lines · Lee Jones
Quoted 15 lines · Alex Elder
All devices supported by simple MFD use the same 8-bit register 8-bit value regmap configuration. There is an option available for a device to specify a custom configuration, but no existing device uses it.
Rather than requiring a "full" regmap configuration to be provided to change only the
max_registervalue, Lee Jones suggested allowingmax_registerto be specified in thesimple_mfd_datastructure. The 8-bit register 8-bit configuration is still used by default, butmax_registeris also applied if it is non-zero.If both
regmap_configandmax_registerare provided, themax_registerfield in theregmap_configstructure is ignored.Signed-off-by Alex Elder <[email protected]>Suggested-by Lee Jones <[email protected]>Quoted 7 lines
---
v10: - Renamesimple_regmap_config()->simple_regmap_config_get()
- Introducesimple_regmap_config_put()to freeregmap_configdrivers/mfd/simple-mfd-i2c.c | 45 ++++++++++++++++++++++++++++++++---- drivers/mfd/simple-mfd-i2c.h | 5 +--- 2 files changed, 41 insertions(+), 9 deletions(-)
Quoted 5 lines
This has gone from an in-function 11 line change to 50 lines and the inclusion of 2 new functions. As much as I _really_ appreciate the time and effort you have put into this [0], the added complexity being added here doesn't sit right with me. How would you like to go back to your v4 idea of providing a bespoke
regmap_configfor for device?
I LOVE this suggestion. I will send v11 shortly and it will be very much like v6 (or something like that).
Quoted 1 line
[0] Beers on me for sending you down this path!
I'm looking forward to seeing you again, beer or not.
Thanks Lee.
-Alex
Lee Jones
maintainerRe: [PATCH v10 2/8] mfd: simple-mfd-i2c: specify max_register
Quoted 32 lines · Alex Elder
Quoted 25 lines · Lee Jones
Quoted 15 lines · Alex Elder
All devices supported by simple MFD use the same 8-bit register 8-bit value regmap configuration. There is an option available for a device to specify a custom configuration, but no existing device uses it.
Rather than requiring a "full" regmap configuration to be provided to change only the
max_registervalue, Lee Jones suggested allowingmax_registerto be specified in thesimple_mfd_datastructure. The 8-bit register 8-bit configuration is still used by default, butmax_registeris also applied if it is non-zero.If both
regmap_configandmax_registerare provided, themax_registerfield in theregmap_configstructure is ignored.Signed-off-by Alex Elder <[email protected]>Suggested-by Lee Jones <[email protected]>Quoted 7 lines
---
v10: - Renamesimple_regmap_config()->simple_regmap_config_get()
- Introducesimple_regmap_config_put()to freeregmap_configdrivers/mfd/simple-mfd-i2c.c | 45 ++++++++++++++++++++++++++++++++---- drivers/mfd/simple-mfd-i2c.h | 5 +--- 2 files changed, 41 insertions(+), 9 deletions(-)Quoted 5 lines
This has gone from an in-function 11 line change to 50 lines and the inclusion of 2 new functions. As much as I _really_ appreciate the time and effort you have put into this [0], the added complexity being added here doesn't sit right with me. How would you like to go back to your v4 idea of providing a bespoke
regmap_configfor for device?
Quoted 6 lines
I LOVE this suggestion. I will send v11 shortly and it will be very much like v6 (or something like that).
Quoted 1 line
[0] Beers on me for sending you down this path!
I'm looking forward to seeing you again, beer or not.
Likewise! =:-)
Signature · 1 line
Lee Jones [李琼斯]
PATCH v10 3/8 mfd: simple-mfd-i2c: add SpacemiT P1 support
In reply to Alex ElderEnable support for the RTC and regulators found in the SpacemiT P1 PMIC. Support is implemented by the simple I2C MFD driver.
The P1 PMIC is normally implemented with the SpacemiT K1 SoC. This PMIC provides 6 buck converters and 12 LDO regulators. It also implements a switch, watchdog timer, real-time clock, and more. Initially its RTC and regulators are supported.
--- drivers/mfd/Kconfig | 11 +++++++++++ drivers/mfd/simple-mfd-i2c.c | 12 ++++++++++++ 2 files changed, 23 insertions(+)
drivers/mfd/Kconfig +11 -0
@@ -1238,6 +1238,17 @@ config MFD_QCOM_RPM Say M here if you want to include support for the Qualcomm RPM as a module. This will build a module called "qcom_rpm". +config MFD_SPACEMIT_P1 + tristate "SpacemiT P1 PMIC" + depends on I2C + select MFD_SIMPLE_MFD_I2C + help + This option supports the I2C-based SpacemiT P1 PMIC, which + contains regulators, a power switch, GPIOs, an RTC, and more. + This option is selected when any of the supported sub-devices + is configured. The basic functionality is implemented by the + simple MFD I2C driver. + config MFD_SPMI_PMIC tristate "Qualcomm SPMI PMICs" depends on ARCH_QCOM || COMPILE_TEST
drivers/mfd/simple-mfd-i2c.c +12 -0
@@ -128,12 +128,24 @@ static const struct simple_mfd_data maxim_mon_max77705 = { .mfd_cell_size = ARRAY_SIZE(max77705_sensor_cells), }; +static const struct mfd_cell spacemit_p1_cells[] = { + { .name ="spacemit-p1-regulator" , }, + { .name ="spacemit-p1-rtc" , }, +}; + +static const struct simple_mfd_data spacemit_p1 = { + .mfd_cell = spacemit_p1_cells, + .mfd_cell_size =ARRAY_SIZE (spacemit_p1_cells), + .max_register =0xaa , +}; +static const struct of_device_id simple_mfd_i2c_of_match[] = { { .compatible ="kontron,sl28cpld" }, { .compatible ="silergy,sy7636a" , .data = &silergy_sy7636a}, { .compatible ="maxim,max5970" , .data = &maxim_max5970}, { .compatible ="maxim,max5978" , .data = &maxim_max5970}, { .compatible ="maxim,max77705-battery" , .data = &maxim_mon_max77705}, + { .compatible ="spacemit,p1" , .data = &spacemit_p1, }, {} };MODULE_DEVICE_TABLE (of, simple_mfd_i2c_of_match);
Signature · 1 line
2.48.1
PATCH v10 4/8 regulator: spacemit: support SpacemiT P1 regulators
In reply to Alex ElderAdd support for the regulators found in the SpacemiT P1 PMIC. This PMIC provides 6 buck converters and 12 LDO regulators.
The PMIC is implemented as a multi-function device. These regulators are probed based on this driver being named in a MFD cell in the simple MFD I2C driver.
--- drivers/regulator/Kconfig | 12 +++ drivers/regulator/Makefile | 1 + drivers/regulator/spacemit-p1.c | 157 ++++++++++++++++++++++++++++++++ 3 files changed, 170 insertions(+) create mode 100644 drivers/regulator/spacemit-p1.c
drivers/regulator/Kconfig +12 -0
@@ -1395,6 +1395,18 @@ config REGULATOR_SLG51000 The SLG51000 is seven compact and customizable low dropout regulators. +config REGULATOR_SPACEMIT_P1 + tristate "SpacemiT P1 regulators" + depends on ARCH_SPACEMIT || COMPILE_TEST + select MFD_SPACEMIT_P1 + default ARCH_SPACEMIT + help + Enable support for regulators implemented by the SpacemiT P1 + power controller. The P1 implements 6 high-efficiency buck + converters and 12 programmable LDO regulators. To compile this + driver as a module, choose M here. The module will be called + "spacemit-pmic". + config REGULATOR_STM32_BOOSTER tristate "STMicroelectronics STM32 BOOSTER" depends on ARCH_STM32 || COMPILE_TEST
drivers/regulator/Makefile +1 -0
@@ -162,6 +162,7 @@ obj-$(CONFIG_REGULATOR_S5M8767) += s5m8767.o obj-$(CONFIG_REGULATOR_SC2731) += sc2731-regulator.o obj-$(CONFIG_REGULATOR_SKY81452) += sky81452-regulator.o obj-$(CONFIG_REGULATOR_SLG51000) += slg51000-regulator.o +obj-$(CONFIG_REGULATOR_SPACEMIT_P1) += spacemit-p1.o obj-$(CONFIG_REGULATOR_STM32_BOOSTER) += stm32-booster.o obj-$(CONFIG_REGULATOR_STM32_VREFBUF) += stm32-vrefbuf.o obj-$(CONFIG_REGULATOR_STM32_PWR) += stm32-pwr.o
drivers/regulator/spacemit-p1.c new file +157 -0
157 lines not on this page · raw message
Signature · 1 line
2.48.1
kernel test robot
build botRe: [PATCH v10 4/8] regulator: spacemit: support SpacemiT P1 regulators
kernel test robot noticed the following build warnings:
Hi Alex,
kernel test robot noticed the following build warnings:
[auto build test WARNING on d7af19298454ed155f5cf67201a70f5cf836c842]
url: https://github.com/intel-lab-lkp/linux/commits/Alex-Elder/dt-bindings-mfd-add-support-the-SpacemiT-P1-PMIC/20250726-211530 base: d7af19298454ed155f5cf67201a70f5cf836c842 patch link: https://lore.kernel.org/r/20250726131003.3137282-5-elder%40riscstar.com patch subject: [PATCH v10 4/8] regulator: spacemit: support SpacemiT P1 regulators config: alpha-kismet-CONFIG_MFD_SPACEMIT_P1-CONFIG_REGULATOR_SPACEMIT_P1-0-0 (https://download.01.org/0day-ci/archive/20250728/[email protected]/config) reproduce: (https://download.01.org/0day-ci/archive/20250728/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
kismet warnings: (new ones prefixed by >>)
>> kismet: WARNING: unmet direct dependencies detected for MFD_SPACEMIT_P1 when selected by REGULATOR_SPACEMIT_P1
WARNING: unmet direct dependencies detected for MFD_SPACEMIT_P1
Depends on [n]: HAS_IOMEM [=y] && I2C [=n]
Selected by [y]:
- REGULATOR_SPACEMIT_P1 [=y] && REGULATOR [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y])
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Re: [PATCH v10 4/8] regulator: spacemit: support SpacemiT P1 regulators
Quoted 3 lines · kernel test robot
Hi Alex,
kernel test robot noticed the following build warnings:
I have a fix for this, and will include it in v11 of this series when I publish it. I will wait to do that until I get additional feedback.
The fix is to make REGULATOR_SPACEMIT_P1 depend on I2C, in addition to ARCH_SPACEMIT || COMPILE_TEST.
-Alex
Quoted 22 lines
[auto build test WARNING on
d7af19298454ed155f5cf67201a70f5cf836c842]url: https://github.com/intel-lab-lkp/linux/commits/Alex-Elder/dt-bindings-mfd-add-support-the-SpacemiT-P1-PMIC/20250726-211530 base: d7af19298454ed155f5cf67201a70f5cf836c842 patch link: https://lore.kernel.org/r/20250726131003.3137282-5-elder%40riscstar.com patch subject: [PATCH v10 4/8] regulator: spacemit: support SpacemiT P1 regulators config: alpha-kismet-CONFIG_MFD_SPACEMIT_P1-CONFIG_REGULATOR_SPACEMIT_P1-0-0 (https://download.01.org/0day-ci/archive/20250728/[email protected]/config) reproduce: (https://download.01.org/0day-ci/archive/20250728/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/kismet warnings: (new ones prefixed by >>)
Quoted 1 line
Quoted 1 line
kismet: WARNING: unmet direct dependencies detected for
MFD_SPACEMIT_P1when selected byREGULATOR_SPACEMIT_P1WARNING: unmet direct dependencies detected for
MFD_SPACEMIT_P1
Depends on [n]:HAS_IOMEM[=y] && I2C [=n]
Selected by [y]:
-REGULATOR_SPACEMIT_P1[=y] && REGULATOR [=y] && (ARCH_SPACEMIT||COMPILE_TEST[=y])
PATCH v10 5/8 rtc: spacemit: support the SpacemiT P1 RTC
In reply to Alex ElderAdd support for the RTC found in the SpacemiT P1 PMIC. Initially only setting and reading the time are supported.
The PMIC is implemented as a multi-function device. This RTC is probed based on this driver being named in a MFD cell in the simple MFD I2C driver.
--- drivers/rtc/Kconfig | 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-spacemit-p1.c | 167 ++++++++++++++++++++++++++++++++++ 3 files changed, 178 insertions(+) create mode 100644 drivers/rtc/rtc-spacemit-p1.c
drivers/rtc/Kconfig +10 -0
@@ -406,6 +406,16 @@ config RTC_DRV_MAX77686 This driver can also be built as a module. If so, the module will be called rtc-max77686. +config RTC_DRV_SPACEMIT_P1 + tristate "SpacemiT P1 RTC" + depends on ARCH_SPACEMIT || COMPILE_TEST + select MFD_SPACEMIT_P1 + default ARCH_SPACEMIT + help + Enable support for the RTC function in the SpacemiT P1 PMIC. + This driver can also be built as a module, which will be called + "spacemit-p1-rtc". + config RTC_DRV_NCT3018Y tristate "Nuvoton NCT3018Y" depends on OF
drivers/rtc/Makefile +1 -0
@@ -171,6 +171,7 @@ obj-$(CONFIG_RTC_DRV_SD2405AL) += rtc-sd2405al.o obj-$(CONFIG_RTC_DRV_SD3078) += rtc-sd3078.o obj-$(CONFIG_RTC_DRV_SH) += rtc-sh.o obj-$(CONFIG_RTC_DRV_SNVS) += rtc-snvs.o +obj-$(CONFIG_RTC_DRV_SPACEMIT_P1) += rtc-spacemit-p1.o obj-$(CONFIG_RTC_DRV_SPEAR) += rtc-spear.o obj-$(CONFIG_RTC_DRV_STARFIRE) += rtc-starfire.o obj-$(CONFIG_RTC_DRV_STK17TA8) += rtc-stk17ta8.o
drivers/rtc/rtc-spacemit-p1.c new file +167 -0
167 lines not on this page · raw message
Signature · 1 line
2.48.1
PATCH v10 6/8 riscv: dts: spacemit: enable the i2c8 adapter
In reply to Alex ElderDefine properties for the I2C adapter that provides access to the SpacemiT P1 PMIC. Enable this adapter on the Banana Pi BPI-F3.
---
v10: - Move a few things around as suggested by Yixun Lan
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 12 ++++++++++++ arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi | 7 +++++++ arch/riscv/boot/dts/spacemit/k1.dtsi | 13 +++++++++++++ 3 files changed, 32 insertions(+)
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts +12 -0
@@ -40,6 +40,18 @@ &emmc { status = "okay"; }; +&i2c8 { + pinctrl-0 = <&i2c8_cfg>; + pinctrl-names = "default"; + status = "okay"; + + pmic@41 { + compatible = "spacemit,p1"; + reg = <0x41>; + interrupts = <64>; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_2_cfg>;
arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi +7 -0
@@ -11,6 +11,13 @@ #define K1_GPIO(x) (x / 32) (x % 32) &pinctrl { + i2c8_cfg: i2c8-cfg { + i2c8-0-pins { + pinmux = <K1_PADCONF(93, 0)>, /* PWR_SCL */ + <K1_PADCONF(94, 0)>; /* PWR_SDA */ + }; + }; + uart0_2_cfg: uart0-2-cfg { uart0-2-pins { pinmux = <K1_PADCONF(68, 2)>,
arch/riscv/boot/dts/spacemit/k1.dtsi +13 -0
@@ -459,6 +459,19 @@ pwm7: pwm@d401bc00 { status = "disabled"; }; + i2c8: i2c@d401d800 { + compatible = "spacemit,k1-i2c"; + reg = <0x0 0xd401d800 0x0 0x38>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&syscon_apbc CLK_TWSI8>, + <&syscon_apbc CLK_TWSI8_BUS>; + clock-names = "func", "bus"; + clock-frequency = <400000>; + interrupts = <19>; + status = "disabled"; + }; + pinctrl: pinctrl@d401e000 { compatible = "spacemit,k1-pinctrl"; reg = <0x0 0xd401e000 0x0 0x400>;
Signature · 1 line
2.48.1
PATCH v10 7/8 riscv: dts: spacemit: define fixed regulators
In reply to Alex ElderDefine the DC power input and the 4v power as fixed supplies in the Banana Pi BPI-F3.
--- .../boot/dts/spacemit/k1-bananapi-f3.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts +19 -0
@@ -28,6 +28,25 @@ led1 { default-state = "on"; }; }; + + reg_dc_in: dc-in-12v { + compatible = "regulator-fixed"; + regulator-name = "dc_in_12v"; + regulator-min-microvolt = <12000000>; + regulator-max-microvolt = <12000000>; + regulator-boot-on; + regulator-always-on; + }; + + reg_vcc_4v: vcc-4v { + compatible = "regulator-fixed"; + regulator-name = "vcc_4v"; + regulator-min-microvolt = <4000000>; + regulator-max-microvolt = <4000000>; + regulator-boot-on; + regulator-always-on; + vin-supply = <®_dc_in>; + }; }; &emmc {
Signature · 1 line
2.48.1
PATCH v10 8/8 riscv: dts: spacemit: define regulator constraints
In reply to Alex ElderDefine basic constraints for the regulators in the SpacemiT P1 PMIC, as implemented in the Banana Pi BPI-F3.
--- .../boot/dts/spacemit/k1-bananapi-f3.dts | 104 ++++++++++++++++++ 1 file changed, 104 insertions(+)
arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts +104 -0
@@ -68,6 +68,110 @@ pmic@41 { compatible = "spacemit,p1"; reg = <0x41>; interrupts = <64>; + vin-supply = <®_vcc_4v>; + + regulators { + buck1 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3450000>; + regulator-ramp-delay = <5000>; + regulator-always-on; + }; + + buck2 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3450000>; + regulator-ramp-delay = <5000>; + regulator-always-on; + }; + + buck3 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <5000>; + regulator-always-on; + }; + + buck4 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <5000>; + regulator-always-on; + }; + + buck5 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3450000>; + regulator-ramp-delay = <5000>; + regulator-always-on; + }; + + buck6 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3450000>; + regulator-ramp-delay = <5000>; + regulator-always-on; + }; + + aldo1 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + regulator-boot-on; + }; + + aldo2 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + }; + + aldo3 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + }; + + aldo4 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + }; + + dldo1 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + regulator-boot-on; + }; + + dldo2 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + }; + + dldo3 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + }; + + dldo4 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + regulator-always-on; + }; + + dldo5 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + }; + + dldo6 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + regulator-always-on; + }; + + dldo7 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <3400000>; + }; + }; }; };
Signature · 1 line
2.48.1