drivers/nfc/s3fwrn5/uart.c:147:15: error: implicit declaration of function 'devm_gpio_request_one'
kernel test robot
build bottree: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next head: 4740e1e2f320061c2f0dbadc0dd3dfb58df986d5 commit: 678bae2eaa812662929a83b3de399645e9de93ad [4/5] gpiolib: make legacy interfaces optional config: um-randconfig-002-20250726 (https://download.01.org/0day-ci/archive/20250726/[email protected]/config) compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250726/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
drivers/nfc/s3fwrn5/uart.c: In function 's3fwrn82_uart_parse_dt':
>> drivers/nfc/s3fwrn5/uart.c:100:14: error: implicit declaration of function 'gpio_is_valid'; did you mean 'uuid_is_valid'? [-Werror=implicit-function-declaration]
100 | if (!gpio_is_valid(phy->common.gpio_en))
| ^~~~~~~~~~~~~
| uuid_is_valid
drivers/nfc/s3fwrn5/uart.c: In function 's3fwrn82_uart_probe':
>> drivers/nfc/s3fwrn5/uart.c:147:15: error: implicit declaration of function 'devm_gpio_request_one' [-Werror=implicit-function-declaration]
147 | ret = devm_gpio_request_one(&phy->ser_dev->dev, phy->common.gpio_en,
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/nfc/s3fwrn5/uart.c:148:37: error: 'GPIOF_OUT_INIT_HIGH' undeclared (first use in this function)
148 | GPIOF_OUT_INIT_HIGH, "s3fwrn82_en");
| ^~~~~~~~~~~~~~~~~~~
drivers/nfc/s3fwrn5/uart.c:148:37: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/nfc/s3fwrn5/uart.c:154:37: error: 'GPIOF_OUT_INIT_LOW' undeclared (first use in this function)
154 | GPIOF_OUT_INIT_LOW, "s3fwrn82_fw_wake");
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/nfc/s3fwrn5/phy_common.c: In function 's3fwrn5_phy_set_wake':
>> drivers/nfc/s3fwrn5/phy_common.c:22:9: error: implicit declaration of function 'gpio_set_value'; did you mean 'pte_set_val'? [-Werror=implicit-function-declaration]
22 | gpio_set_value(phy->gpio_fw_wake, wake);
| ^~~~~~~~~~~~~~
| pte_set_valcc1: some warnings being treated as errors
vim +/devm_gpio_request_one +147 drivers/nfc/s3fwrn5/uart.c
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 90
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 91 static int s3fwrn82_uart_parse_dt(struct serdev_device *serdev)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 92 {
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 93 struct s3fwrn82_uart_phy *phy = serdev_device_get_drvdata(serdev);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 94 struct device_node *np = serdev->dev.of_node;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 95
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 96 if (!np)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 97 return -ENODEV;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 98
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 99 phy->common.gpio_en = of_get_named_gpio(np, "en-gpios", 0);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 @100 if (!gpio_is_valid(phy->common.gpio_en))
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 101 return -ENODEV;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 102
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 103 phy->common.gpio_fw_wake = of_get_named_gpio(np, "wake-gpios", 0);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 104 if (!gpio_is_valid(phy->common.gpio_fw_wake))
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 105 return -ENODEV;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 106
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 107 return 0;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 108 }
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 109
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 110 static int s3fwrn82_uart_probe(struct serdev_device *serdev)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 111 {
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 112 struct s3fwrn82_uart_phy *phy;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 113 int ret = -ENOMEM;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 114
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 115 phy = devm_kzalloc(&serdev->dev, sizeof(*phy), GFP_KERNEL);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 116 if (!phy)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 117 goto err_exit;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 118
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 119 phy->recv_skb = alloc_skb(NCI_SKB_BUFF_LEN, GFP_KERNEL);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 120 if (!phy->recv_skb)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 121 goto err_exit;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 122
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 123 mutex_init(&phy->common.mutex);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 124 phy->common.mode = S3FWRN5_MODE_COLD;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 125
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 126 phy->ser_dev = serdev;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 127 serdev_device_set_drvdata(serdev, phy);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 128 serdev_device_set_client_ops(serdev, &s3fwrn82_serdev_ops);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 129 ret = serdev_device_open(serdev);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 130 if (ret) {
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 131 dev_err(&serdev->dev, "Unable to open device\n");
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 132 goto err_skb;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 133 }
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 134
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 135 ret = serdev_device_set_baudrate(serdev, 115200);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 136 if (ret != 115200) {
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 137 ret = -EINVAL;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 138 goto err_serdev;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 139 }
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 140
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 141 serdev_device_set_flow_control(serdev, false);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 142
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 143 ret = s3fwrn82_uart_parse_dt(serdev);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 144 if (ret < 0)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 145 goto err_serdev;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 146
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 @147 ret = devm_gpio_request_one(&phy->ser_dev->dev, phy->common.gpio_en,
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 @148 GPIOF_OUT_INIT_HIGH, "s3fwrn82_en");
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 149 if (ret < 0)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 150 goto err_serdev;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 151
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 152 ret = devm_gpio_request_one(&phy->ser_dev->dev,
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 153 phy->common.gpio_fw_wake,
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 @154 GPIOF_OUT_INIT_LOW, "s3fwrn82_fw_wake");
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 155 if (ret < 0)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 156 goto err_serdev;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 157
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 158 ret = s3fwrn5_probe(&phy->common.ndev, phy, &phy->ser_dev->dev,
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 159 &uart_phy_ops);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 160 if (ret < 0)
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 161 goto err_serdev;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 162
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 163 return ret;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 164
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 165 err_serdev:
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 166 serdev_device_close(serdev);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 167 err_skb:
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 168 kfree_skb(phy->recv_skb);
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 169 err_exit:
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 170 return ret;
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 171 }
3f52c2cb7e3ada Bongsu Jeon 2020-12-02 172 :::::: The code at line 147 was first introduced by commit
:::::: 3f52c2cb7e3ada37513dabb69a22cf917dba754f nfc: s3fwrn5: Support a UART interface
:::::: TO: Bongsu Jeon <[email protected]>
:::::: CC: Jakub Kicinski <[email protected]>
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Quoted 34 lines · kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next head: 4740e1e2f320061c2f0dbadc0dd3dfb58df986d5 commit: 678bae2eaa812662929a83b3de399645e9de93ad [4/5] gpiolib: make legacy interfaces optional config: um-randconfig-002-20250726 (https://download.01.org/0day-ci/archive/20250726/[email protected]/config) compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250726/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
drivers/nfc/s3fwrn5/uart.c: In function 's3fwrn82_uart_parse_dt':Quoted 1 line
Quoted 1 line
drivers/nfc/s3fwrn5/uart.c:100:14: error: implicit declaration of function 'gpio_is_valid'; did you mean 'uuid_is_valid'? [-Werror=implicit-function-declaration]100 | if (!gpio_is_valid(phy->common.gpio_en)) | ^~~~~~~~~~~~~ | uuid_is_valid
drivers/nfc/s3fwrn5/uart.c: In function 's3fwrn82_uart_probe':Quoted 1 line
Quoted 1 line
drivers/nfc/s3fwrn5/uart.c:147:15: error: implicit declaration of function 'devm_gpio_request_one' [-Werror=implicit-function-declaration]147 | ret = devm_gpio_request_one(&phy->ser_dev->dev, phy->common.gpio_en, | ^~~~~~~~~~~~~~~~~~~~~Quoted 1 line
Quoted 1 line
drivers/nfc/s3fwrn5/uart.c:148:37: error: 'GPIOF_OUT_INIT_HIGH' undeclared (first use in this function)148 | GPIOF_OUT_INIT_HIGH, "s3fwrn82_en"); | ^~~~~~~~~~~~~~~~~~~
drivers/nfc/s3fwrn5/uart.c:148:37: note: each undeclared identifier is reported only once for each function it appears inQuoted 1 line
Quoted 1 line
drivers/nfc/s3fwrn5/uart.c:154:37: error: 'GPIOF_OUT_INIT_LOW' undeclared (first use in this function)154 | GPIOF_OUT_INIT_LOW, "s3fwrn82_fw_wake"); | ^~~~~~~~~~~~~~~~~~cc1: some warnings being treated as errors
--
drivers/nfc/s3fwrn5/phy_common.c: In function 's3fwrn5_phy_set_wake':
Quoted 9 lines
Quoted 1 line
Quoted 1 line
drivers/nfc/s3fwrn5/phy_common.c:22:9: error: implicit declaration of function 'gpio_set_value'; did you mean 'pte_set_val'? [-Werror=implicit-function-declaration]22 | gpio_set_value(phy->gpio_fw_wake, wake); | ^~~~~~~~~~~~~~ | pte_set_valcc1: some warnings being treated as errors
vim +/devm_gpio_request_one +147
drivers/nfc/s3fwrn5/uart.c
Hi Arnd!
Will you be able to address it quickly or should I drop this patch from my queue? I would like to send my PR to Torvalds early next week, Wednesday at the latest.
Bartosz
Quoted 7 lines · Bartosz Golaszewski
On Sat, Jul 26, 2025 at 1:10 PM kernel test robot <[email protected]> wrote:
Hi Arnd!
Will you be able to address it quickly or should I drop this patch from my queue? I would like to send my PR to Torvalds early next week, Wednesday at the latest.
I've sent a fix now, but feel free to drop the original patch instead if you think it's too risky. It took me a while to reproduce the problem with arch/um allmodconfig because there are so many other drivers that turn on gpiolib and end up hiding the issue.
I also saw a few preexisting bugs in that config where drivers already fail to build when GPIOLIB is disabled.
Arnd