Skip to contentSkip to conversation

package/aardvark-dns: add CPE identifier

PATCH Applied Thomas Perale via buildroot 1 participant 6 messages Jul 27, 2025 – Feb 13

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/aardvark-dns: add CPE identifier

The cpe:2.3:a:containers:aardvark-dns:*:*:*:*:*:*:*:* is valid for this package.

See https://nvd.nist.gov/products/cpe/detail/5F79D5CD-D716-4190-BE08-31EB5EEB233F

The CPE version strip the 'v' prefix from the version.

---
 package/aardvark-dns/aardvark-dns.mk | 2 ++
 1 file changed, 2 insertions(+)
package/aardvark-dns/aardvark-dns.mk +2 -0
index 1d2e06fd03..1394218fbc 100644
@@ -11,5 +11,7 @@ AARDVARK_DNS_SITE_METHOD = git
 
 AARDVARK_DNS_LICENSE = Apache-2.0
 AARDVARK_DNS_LICENSE_FILES = LICENSE
+AARDVARK_DNS_CPE_ID_VENDOR = containers
+AARDVARK_DNS_CPE_ID_VERSION = $(subst v,,$(AARDVARK_DNS_VERSION))
 
 $(eval $(cargo-package))
Signature · 6 lines
2.50.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author Reviewed-by Thomas Petazzoni on v1 1/1
#1 lore raw

Hello,

Quoted 8 lines · On Sun, 27 Jul 2025 21:25:37 +0200 Thomas Perale via buildroot…

The cpe:2.3:a:containers:aardvark-dns:*:*:*:*:*:*:*:* is valid for this package.

See https://nvd.nist.gov/products/cpe/detail/5F79D5CD-D716-4190-BE08-31EB5EEB233F

The CPE version strip the 'v' prefix from the version.

even though, I would really prefer us to be able to have the _VERSION field without the v prefix in the first place. Indeed your tricky with AARDVARK_DNS_CPE_ID_VERSION works for the CVE matching, but it doesn't work for release-monitoring.org matching.

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

In reply of:

Quoted 12 lines

Hello,

Quoted 7 lines · On Sun, 27 Jul 2025 21:25:37 +0200 Thomas Perale via buildroot…

The cpe:2.3:a:containers:aardvark-dns:*:*:*:*:*:*:*:* is valid for this package.

See https://nvd.nist.gov/products/cpe/detail/5F79D5CD-D716-4190-BE08-31EB5EEB233F

The CPE version strip the 'v' prefix from the version.

Quoted 8 lines
Quoted 1 line

even though, I would really prefer us to be able to have the _VERSION field without the v prefix in the first place. Indeed your tricky with AARDVARK_DNS_CPE_ID_VERSION works for the CVE matching, but it doesn't work for release-monitoring.org matching.

Hi Thomas,

Thanks for giving a look. I saw similar trick was used in a number of other packages (icu, tinyxml, glibc).

If I'm not missing anything there are no way yet to define both the a <pkg>_VERSION and <pkg>_DL_VERSION variable. See the following code from pkg-generic.mk:

https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/pkg-generic.mk#L491-500

If <pkg>_VERSION is defined it will always override <pkg>_DL_VERSION.

Defining the aardvark-dns version like this could be a solution to the issue you raised but would require some changes in pkg-generic.mk

AARDVARK_DNS_VERSION = 1.15.0 AARDVARK_DNS_DL_VERSION = v$(AARDVARK_DNS_VERSION)

Or maybe some trick with the "<pkg>_SOURCE" variable ?

Regards,
Thomas.

Quoted 10 lines

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Hello,

+Yann in Cc.

Quoted 9 lines · On Tue, 29 Jul 2025 22:02:49 +0200 Thomas Perale <[email protected]> wrote:

Thanks for giving a look. I saw similar trick was used in a number of other packages (icu, tinyxml, glibc).

If I'm not missing anything there are no way yet to define both the a <pkg>_VERSION and <pkg>_DL_VERSION variable. See the following code from pkg-generic.mk:

https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/pkg-generic.mk#L491-500

Quoted 7 lines

If <pkg>_VERSION is defined it will always override <pkg>_DL_VERSION.

Defining the aardvark-dns version like this could be a solution to the issue you raised but would require some changes in pkg-generic.mk

AARDVARK_DNS_VERSION = 1.15.0 AARDVARK_DNS_DL_VERSION = v$(AARDVARK_DNS_VERSION)

Correct, that would be ideal, and I tried to implement exactly this a while ago:

https://gitlab.com/tpetazzoni/buildroot/-/commits/dl-version?ref_type=heads

And didn't manage to get something that works fully (my patch series has a test that verifies the different combinations, and the tests are failing). I'm pretty sure I discussed my code with Yann E. Morin back in the days, and our conclusion was that adding another variable was probably needed to solve the issue, but it was a while ago, I don't recall the exact details.

Best regards,

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw
In reply to Thomas Petazzoni via buildroot

Hi Thomas and Thomas,

Quoted 12 lines · Thomas Petazzoni via buildroot

Hello,

Quoted 7 lines · On Sun, 27 Jul 2025 21:25:37 +0200 Thomas Perale via buildroot…

The cpe:2.3:a:containers:aardvark-dns:*:*:*:*:*:*:*:* is valid for this package.

See https://nvd.nist.gov/products/cpe/detail/5F79D5CD-D716-4190-BE08-31EB5EEB233F

The CPE version strip the 'v' prefix from the version.

Quoted 8 lines
Quoted 1 line

even though, I would really prefer us to be able to have the _VERSION field without the v prefix in the first place. Indeed your tricky with AARDVARK_DNS_CPE_ID_VERSION works for the CVE matching, but it doesn't work for release-monitoring.org matching.

Until we have an generic infrastructure handling that, I applied this patch to master.

Quoted 5 lines

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw
In reply to Thomas Perale via buildroot

In reply of:

Quoted 8 lines

The cpe:2.3:a:containers:aardvark-dns:*:*:*:*:*:*:*:* is valid for this package.

See https://nvd.nist.gov/products/cpe/detail/5F79D5CD-D716-4190-BE08-31EB5EEB233F

The CPE version strip the 'v' prefix from the version.

Applied to 2025.11.x. Thanks

Quoted 23 lines
---
 package/aardvark-dns/aardvark-dns.mk | 2 ++
 1 file changed, 2 insertions(+)
package/aardvark-dns/aardvark-dns.mk +2 -0
index 1d2e06fd03..1394218fbc 100644
@@ -11,5 +11,7 @@ AARDVARK_DNS_SITE_METHOD = git
 
 AARDVARK_DNS_LICENSE = Apache-2.0
 AARDVARK_DNS_LICENSE_FILES = LICENSE
+AARDVARK_DNS_CPE_ID_VENDOR = containers
+AARDVARK_DNS_CPE_ID_VERSION = $(subst v,,$(AARDVARK_DNS_VERSION))
 
 $(eval $(cargo-package))
Signature · 6 lines
2.50.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot