Skip to contentSkip to conversation

drm/i915/display: Use the recomended min_hblank values

PATCH Superseded Arun R Murthy 1 participant 1 message Jul 28, 2025

Subsystems (3)

v4 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 drm/i915/display: Use the recomended min_hblank values

Use recommended values as per wa_14021694213 to compare with the calculated value and choose minimum of them.

v2: corrected checkpatch warning and retain the restriction for min_hblank (Jani)
v3: use calculated value to compare with recomended value and choose minimum of them (Imre)
v4: As driver supported min bpc is 8, omit the condition check for bpc6 with ycbcr420. Added a note for the same (Imre)

Bspec: 74379

---
 drivers/gpu/drm/i915/display/intel_dp.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dp.c +16 -1
index 54d88f24b6893e1f8009f00dda87d8dae5dfc137..a3872764e3d8b1d596f3150db0edf71bf9ea9748 100644
@@ -3182,7 +3182,22 @@ int intel_dp_compute_min_hblank(struct intel_crtc_state *crtc_state,
 	 */
 	min_hblank = min_hblank - 2;
 
-	min_hblank = min(10, min_hblank);
+	/*
+	 * min_hblank formula is undergoing a change, to avoid underrun use the
+	 * recomended value in spec to compare with the calculated one and use the
+	 * minimum value
+	 */
+	if (intel_dp_is_uhbr(crtc_state)) {
+		/*
+		 * Note: Driver doesn't support 6bpc and unusual to have 6bpc
+		 * with YCBCR420, for which the spec suggests a minimum hblank
+		 * value of 2(Hence this condition is omitted).
+		 */
+		min_hblank = min(3, min_hblank);
+	} else {
+		min_hblank = min(10, min_hblank);
+	}
+
 	crtc_state->min_hblank = min_hblank;
 
 	return 0;

---
base-commit: eb0c2b25072b5c56e8c41d7099050bf53bebaa14
change-id: 20250728-min_hblank-263ceb40508c

Best regards,

Signature · 1 line
Arun R Murthy <[email protected]>