assert rmap behaves as expected
Subsystems (4)
v2 cover assert rmap behaves as expected
As David suggested, currently we don't have a high level test case to verify the behavior of rmap. This patch set introduce the verification on rmap by migration.
Patch 1 is a preparation to move ksm related operation into vm_util. Patch 2 is the new test case for rmap.
Currently it covers following four scenarios:
* anonymous page
* shmem page
* pagecache page
* ksm page
v1->v2:
* do check on file opening in init_global_file_handlers()
* factor out ksm_merge() and ksm_unmerge() instead of partial of it
* align the return value of helpers: 0 on success, -errno on error
* skip instead of assert if numa not available
* check ksm sys file before continue
* use private anonymous map instead of shared map
* check pfn instead of content
* retry migrate
* fault in region for each process by FORCE_READ()
RFC->v1:
* open file in function itself instead of pass fd as parameter
* fault in the region by accessing it instead of print content
Wei Yang (2):
selftests/mm: put general ksm operation into vm_util selftests/mm: assert rmap behave as expected
MAINTAINERS | 1 + tools/testing/selftests/mm/.gitignore | 1 + tools/testing/selftests/mm/Makefile | 3 + .../selftests/mm/ksm_functional_tests.c | 128 +----- tools/testing/selftests/mm/rmap.c | 432 ++++++++++++++++++ tools/testing/selftests/mm/run_vmtests.sh | 4 + tools/testing/selftests/mm/vm_util.c | 123 +++++ tools/testing/selftests/mm/vm_util.h | 7 + 8 files changed, 588 insertions(+), 111 deletions(-) create mode 100644 tools/testing/selftests/mm/rmap.c
Signature · 1 line
2.34.1
PATCH v2 1/2 selftests/mm: put general ksm operation into vm_util
There are some general ksm operations could be used by other related test case. Put them into vm_util for common use.
This is a preparation patch for later use.
---
v2:
* do check on file opening in init_global_file_handlers()
* factor out ksm_merge() and ksm_unmerge() instead of partial of it
* align the return value of helpers: 0 on success, -errno on error
v1: open/close fd in function itself instead of pass as parameter
--- .../selftests/mm/ksm_functional_tests.c | 128 +++--------------- tools/testing/selftests/mm/vm_util.c | 123 +++++++++++++++++ tools/testing/selftests/mm/vm_util.h | 7 + 3 files changed, 147 insertions(+), 111 deletions(-)
tools/testing/selftests/mm/ksm_functional_tests.c +17 -111
@@ -38,11 +38,6 @@ enum ksm_merge_mode { };static int mem_fd; -static int ksm_fd; -static int ksm_full_scans_fd; -static int proc_self_ksm_stat_fd; -static int proc_self_ksm_merging_pages_fd; -static int ksm_use_zero_pages_fd;static int pagemap_fd;static size_t pagesize;
@@ -73,88 +68,6 @@ static bool range_maps_duplicates(char *addr, unsigned long size)return false; } -static long get_my_ksm_zero_pages (void ) -{ -char buf[200 ]; -char *substr_ksm_zero; -size_t value_pos; -ssize_t read_size; -unsigned long my_ksm_zero_pages; - -if (!proc_self_ksm_stat_fd) -return 0 ; - - read_size =pread (proc_self_ksm_stat_fd, buf,sizeof (buf) -1 ,0 ); -if (read_size <0 ) -return -errno; - - buf[read_size] =0 ; - - substr_ksm_zero =strstr (buf,"ksm_zero_pages" ); -if (!substr_ksm_zero) -return 0 ; - - value_pos =strcspn (substr_ksm_zero,"0123456789" ); - my_ksm_zero_pages =strtol (substr_ksm_zero + value_pos,NULL ,10 ); - -return my_ksm_zero_pages; -} - -static long get_my_merging_pages (void ) -{ -char buf[10 ]; -ssize_t ret; - -if (proc_self_ksm_merging_pages_fd <0 ) -return proc_self_ksm_merging_pages_fd; - - ret =pread (proc_self_ksm_merging_pages_fd, buf,sizeof (buf) -1 ,0 ); -if (ret <=0 ) -return -errno; - buf[ret] =0 ; - -return strtol (buf,NULL ,10 ); -} - -static long ksm_get_full_scans (void ) -{ -char buf[10 ]; -ssize_t ret; - - ret =pread (ksm_full_scans_fd, buf,sizeof (buf) -1 ,0 ); -if (ret <=0 ) -return -errno; - buf[ret] =0 ; - -return strtol (buf,NULL ,10 ); -} - -static int ksm_merge (void ) -{ -long start_scans, end_scans; - -/* Wait for two full scans such that any possible merging happened. */ - start_scans =ksm_get_full_scans (); -if (start_scans <0 ) -return start_scans; -if (write (ksm_fd,"1" ,1 ) !=1 ) -return -errno; -do { - end_scans =ksm_get_full_scans (); -if (end_scans <0 ) -return end_scans; - }while (end_scans < start_scans +2 ); - -return 0 ; -} - -static int ksm_unmerge (void ) -{ -if (write (ksm_fd,"2" ,1 ) !=1 ) -return -errno; -return 0 ; -} -static char *__mmap_and_merge_range (char val,unsigned long size,int prot,enum ksm_merge_mode mode) {
@@ -163,12 +76,12 @@ static char *__mmap_and_merge_range(char val, unsigned long size, int prot,int ret;/* Stabilize accounting by disabling KSM completely. */ -if (ksm_unmerge ()) { +if (ksm_stop () <0 ) {ksft_print_msg ("Disabling (unmerging) KSM failed\n" );return err_map; } -if (get_my_merging_pages () >0 ) { +if (ksm_get_self_merging_pages () >0 ) {ksft_print_msg ("Still pages merged\n" );return err_map; }
@@ -218,7 +131,7 @@ static char *__mmap_and_merge_range(char val, unsigned long size, int prot, }/* Run KSM to trigger merging and wait. */ -if (ksm_merge ()) { +if (ksm_start () <0 ) {ksft_print_msg ("Running KSM failed\n" ); goto unmap; }
@@ -227,7 +140,7 @@ static char *__mmap_and_merge_range(char val, unsigned long size, int prot,* Check if anything was merged at all. Ignore the zero page that is * accounted differently (depending on kernel support). */ -if (val && !get_my_merging_pages ()) { +if (val && !ksm_get_self_merging_pages ()) {ksft_print_msg ("No pages got merged\n" ); goto unmap; }
@@ -286,15 +199,12 @@ static void test_unmerge_zero_pages(void)ksft_print_msg ("[RUN] %s\n" , __func__); -if (proc_self_ksm_stat_fd <0 ) { -ksft_test_result_skip ("open(\"/proc/self/ksm_stat\") failed\n" ); -return ; - } -if (ksm_use_zero_pages_fd <0 ) { -ksft_test_result_skip ("open \"/sys/kernel/mm/ksm/use_zero_pages\" failed\n" ); +if (ksm_get_self_zero_pages () <0 ) { +ksft_test_result_skip ("accessing \"/proc/self/ksm_stat\" failed\n" );return ; } -if (write (ksm_use_zero_pages_fd,"1" ,1 ) !=1 ) { + +if (ksm_use_zero_pages () <0 ) {ksft_test_result_skip ("write \"/sys/kernel/mm/ksm/use_zero_pages\" failed\n" );return ; }
@@ -306,7 +216,7 @@ static void test_unmerge_zero_pages(void)/* Check if ksm_zero_pages is updated correctly after KSM merging */ pages_expected = size / pagesize; -if (pages_expected !=get_my_ksm_zero_pages ()) { +if (pages_expected !=ksm_get_self_zero_pages ()) {ksft_test_result_fail ("'ksm_zero_pages' updated after merging\n" ); goto unmap; }
@@ -319,7 +229,7 @@ static void test_unmerge_zero_pages(void)/* Check if ksm_zero_pages is updated correctly after unmerging */ pages_expected /=2 ; -if (pages_expected !=get_my_ksm_zero_pages ()) { +if (pages_expected !=ksm_get_self_zero_pages ()) {ksft_test_result_fail ("'ksm_zero_pages' updated after unmerging\n" ); goto unmap; }
@@ -329,7 +239,7 @@ static void test_unmerge_zero_pages(void) *((unsigned int *)&map[offs]) = offs;/* Now we should have no zeropages remaining. */ -if (get_my_ksm_zero_pages ()) { +if (ksm_get_self_zero_pages ()) {ksft_test_result_fail ("'ksm_zero_pages' updated after write fault\n" ); goto unmap; }
@@ -685,19 +595,15 @@ static void init_global_file_handles(void) mem_fd =open ("/proc/self/mem" ,O_RDWR );if (mem_fd <0 )ksft_exit_fail_msg ("opening /proc/self/mem failed\n" ); - ksm_fd =open ("/sys/kernel/mm/ksm/run" ,O_RDWR ); -if (ksm_fd <0 ) -ksft_exit_skip ("open(\"/sys/kernel/mm/ksm/run\") failed\n" ); - ksm_full_scans_fd =open ("/sys/kernel/mm/ksm/full_scans" ,O_RDONLY ); -if (ksm_full_scans_fd <0 ) -ksft_exit_skip ("open(\"/sys/kernel/mm/ksm/full_scans\") failed\n" ); +if (ksm_stop () <0 ) +ksft_exit_skip ("accessing \"/sys/kernel/mm/ksm/run\") failed\n" ); +if (ksm_get_full_scans () <0 ) +ksft_exit_skip ("accessing \"/sys/kernel/mm/ksm/full_scans\") failed\n" ); pagemap_fd =open ("/proc/self/pagemap" ,O_RDONLY );if (pagemap_fd <0 )ksft_exit_skip ("open(\"/proc/self/pagemap\") failed\n" ); - proc_self_ksm_stat_fd =open ("/proc/self/ksm_stat" ,O_RDONLY ); - proc_self_ksm_merging_pages_fd =open ("/proc/self/ksm_merging_pages" , -O_RDONLY ); - ksm_use_zero_pages_fd =open ("/sys/kernel/mm/ksm/use_zero_pages" ,O_RDWR ); +if (ksm_get_self_merging_pages () <0 ) +ksft_exit_skip ("accessing \"/proc/self/ksm_merging_pages\") failed\n" ); }int main (int argc,char **argv)
tools/testing/selftests/mm/vm_util.c +123 -0
126 lines not on this page · raw message
tools/testing/selftests/mm/vm_util.h +7 -0
@@ -129,6 +129,13 @@ static inline void log_test_result(int result)void *sys_mremap (void *old_address,unsigned long old_size,unsigned long new_size,int flags,void *new_address); +long ksm_get_self_zero_pages (void ); +long ksm_get_self_merging_pages (void ); +long ksm_get_full_scans (void ); +int ksm_use_zero_pages (void ); +int ksm_start (void ); +int ksm_stop (void ); +/* * On ppc64 this will only work with radix 2M hugepage size */
Signature · 1 line
2.34.1
Re: [Patch v2 1/2] selftests/mm: put general ksm operation into vm_util
Ping...
Quoted 388 lines · Wei Yang
There are some general ksm operations could be used by other related test case. Put them into
vm_utilfor common use.This is a preparation patch for later use.
Signed-off-by Wei Yang <[email protected]>Suggested-by David Hildenbrand <[email protected]>Cc David Hildenbrand <[email protected]>Cc Lorenzo Stoakes <[email protected]>Cc Rik van Riel <[email protected]>Cc Liam R. Howlett <[email protected]>Cc Vlastimil Babka <[email protected]>Cc Harry Yoo <[email protected]>---
v2:
* do check on file opening ininit_global_file_handlers()
* factor outksm_merge()andksm_unmerge()instead of partial of it
* align the return value of helpers: 0 on success, -errno on error
v1: open/close fd in function itself instead of pass as parameter
---.../selftests/mm/ksm_functional_tests.c | 128 +++--------------- tools/testing/selftests/mm/vm_util.c | 123 +++++++++++++++++ tools/testing/selftests/mm/vm_util.h | 7 + 3 files changed, 147 insertions(+), 111 deletions(-)tools/testing/selftests/mm/ksm_functional_tests.c +17
-111@@ -38,11 +38,6 @@ enum ksm_merge_mode { };static int mem_fd; -static int ksm_fd; -static int ksm_full_scans_fd; -static int proc_self_ksm_stat_fd; -static int proc_self_ksm_merging_pages_fd; -static int ksm_use_zero_pages_fd;static int pagemap_fd;static size_t pagesize;@@ -73,88 +68,6 @@ static bool range_maps_duplicates(char *addr, unsigned long size)return false; } -static long get_my_ksm_zero_pages (void ) -{ -char buf[200 ]; -char *substr_ksm_zero; -size_t value_pos; -ssize_t read_size; -unsigned long my_ksm_zero_pages; - -if (!proc_self_ksm_stat_fd) -return 0 ; - - read_size =pread (proc_self_ksm_stat_fd, buf,sizeof (buf) -1 ,0 ); -if (read_size <0 ) -return -errno; - - buf[read_size] =0 ; - - substr_ksm_zero =strstr (buf,"ksm_zero_pages" ); -if (!substr_ksm_zero) -return 0 ; - - value_pos =strcspn (substr_ksm_zero,"0123456789" ); - my_ksm_zero_pages =strtol (substr_ksm_zero + value_pos,NULL ,10 ); - -return my_ksm_zero_pages; -} - -static long get_my_merging_pages (void ) -{ -char buf[10 ]; -ssize_t ret; - -if (proc_self_ksm_merging_pages_fd <0 ) -return proc_self_ksm_merging_pages_fd; - - ret =pread (proc_self_ksm_merging_pages_fd, buf,sizeof (buf) -1 ,0 ); -if (ret <=0 ) -return -errno; - buf[ret] =0 ; - -return strtol (buf,NULL ,10 ); -} - -static long ksm_get_full_scans (void ) -{ -char buf[10 ]; -ssize_t ret; - - ret =pread (ksm_full_scans_fd, buf,sizeof (buf) -1 ,0 ); -if (ret <=0 ) -return -errno; - buf[ret] =0 ; - -return strtol (buf,NULL ,10 ); -} - -static int ksm_merge (void ) -{ -long start_scans, end_scans; - -/* Wait for two full scans such that any possible merging happened. */ - start_scans =ksm_get_full_scans (); -if (start_scans <0 ) -return start_scans; -if (write (ksm_fd,"1" ,1 ) !=1 ) -return -errno; -do { - end_scans =ksm_get_full_scans (); -if (end_scans <0 ) -return end_scans; - }while (end_scans < start_scans +2 ); - -return 0 ; -} - -static int ksm_unmerge (void ) -{ -if (write (ksm_fd,"2" ,1 ) !=1 ) -return -errno; -return 0 ; -} -static char *__mmap_and_merge_range (char val,unsigned long size,int prot,enum ksm_merge_mode mode) {@@ -163,12 +76,12 @@ static char *__mmap_and_merge_range(char val, unsigned long size, int prot,int ret;/* Stabilize accounting by disabling KSM completely. */ -if (ksm_unmerge ()) { +if (ksm_stop () <0 ) {ksft_print_msg ("Disabling (unmerging) KSM failed\n" );return err_map; } -if (get_my_merging_pages () >0 ) { +if (ksm_get_self_merging_pages () >0 ) {ksft_print_msg ("Still pages merged\n" );return err_map; }@@ -218,7 +131,7 @@ static char *__mmap_and_merge_range(char val, unsigned long size, int prot, }/* Run KSM to trigger merging and wait. */ -if (ksm_merge ()) { +if (ksm_start () <0 ) {ksft_print_msg ("Running KSM failed\n" ); goto unmap; }@@ -227,7 +140,7 @@ static char *__mmap_and_merge_range(char val, unsigned long size, int prot,* Check if anything was merged at all. Ignore the zero page that is * accounted differently (depending on kernel support). */ -if (val && !get_my_merging_pages ()) { +if (val && !ksm_get_self_merging_pages ()) {ksft_print_msg ("No pages got merged\n" ); goto unmap; }@@ -286,15 +199,12 @@ static void test_unmerge_zero_pages(void)ksft_print_msg ("[RUN] %s\n" , __func__); -if (proc_self_ksm_stat_fd <0 ) { -ksft_test_result_skip ("open(\"/proc/self/ksm_stat\") failed\n" ); -return ; - } -if (ksm_use_zero_pages_fd <0 ) { -ksft_test_result_skip ("open \"/sys/kernel/mm/ksm/use_zero_pages\" failed\n" ); +if (ksm_get_self_zero_pages () <0 ) { +ksft_test_result_skip ("accessing \"/proc/self/ksm_stat\" failed\n" );return ; } -if (write (ksm_use_zero_pages_fd,"1" ,1 ) !=1 ) { + +if (ksm_use_zero_pages () <0 ) {ksft_test_result_skip ("write \"/sys/kernel/mm/ksm/use_zero_pages\" failed\n" );return ; }@@ -306,7 +216,7 @@ static void test_unmerge_zero_pages(void)/* Check if ksm_zero_pages is updated correctly after KSM merging */ pages_expected = size / pagesize; -if (pages_expected !=get_my_ksm_zero_pages ()) { +if (pages_expected !=ksm_get_self_zero_pages ()) {ksft_test_result_fail ("'ksm_zero_pages' updated after merging\n" ); goto unmap; }@@ -319,7 +229,7 @@ static void test_unmerge_zero_pages(void)/* Check if ksm_zero_pages is updated correctly after unmerging */ pages_expected /=2 ; -if (pages_expected !=get_my_ksm_zero_pages ()) { +if (pages_expected !=ksm_get_self_zero_pages ()) {ksft_test_result_fail ("'ksm_zero_pages' updated after unmerging\n" ); goto unmap; }@@ -329,7 +239,7 @@ static void test_unmerge_zero_pages(void) *((unsigned int *)&map[offs]) = offs;/* Now we should have no zeropages remaining. */ -if (get_my_ksm_zero_pages ()) { +if (ksm_get_self_zero_pages ()) {ksft_test_result_fail ("'ksm_zero_pages' updated after write fault\n" ); goto unmap; }@@ -685,19 +595,15 @@ static void init_global_file_handles(void) mem_fd =open ("/proc/self/mem" ,O_RDWR );if (mem_fd <0 )ksft_exit_fail_msg ("opening /proc/self/mem failed\n" ); - ksm_fd =open ("/sys/kernel/mm/ksm/run" ,O_RDWR ); -if (ksm_fd <0 ) -ksft_exit_skip ("open(\"/sys/kernel/mm/ksm/run\") failed\n" ); - ksm_full_scans_fd =open ("/sys/kernel/mm/ksm/full_scans" ,O_RDONLY ); -if (ksm_full_scans_fd <0 ) -ksft_exit_skip ("open(\"/sys/kernel/mm/ksm/full_scans\") failed\n" ); +if (ksm_stop () <0 ) +ksft_exit_skip ("accessing \"/sys/kernel/mm/ksm/run\") failed\n" ); +if (ksm_get_full_scans () <0 ) +ksft_exit_skip ("accessing \"/sys/kernel/mm/ksm/full_scans\") failed\n" ); pagemap_fd =open ("/proc/self/pagemap" ,O_RDONLY );if (pagemap_fd <0 )ksft_exit_skip ("open(\"/proc/self/pagemap\") failed\n" ); - proc_self_ksm_stat_fd =open ("/proc/self/ksm_stat" ,O_RDONLY ); - proc_self_ksm_merging_pages_fd =open ("/proc/self/ksm_merging_pages" , -O_RDONLY ); - ksm_use_zero_pages_fd =open ("/sys/kernel/mm/ksm/use_zero_pages" ,O_RDWR ); +if (ksm_get_self_merging_pages () <0 ) +ksft_exit_skip ("accessing \"/proc/self/ksm_merging_pages\") failed\n" ); }int main (int argc,char **argv)tools/testing/selftests/mm/vm_util.c +123
-0@@ -555,3 +555,126 @@ bool detect_huge_zeropage(void)close (fd);return enabled; } + +long ksm_get_self_zero_pages (void ) +{ +int proc_self_ksm_stat_fd; +char buf[200 ]; +char *substr_ksm_zero; +size_t value_pos; +ssize_t read_size; + + proc_self_ksm_stat_fd =open ("/proc/self/ksm_stat" ,O_RDONLY ); +if (proc_self_ksm_stat_fd <0 ) +return -errno; + + read_size =pread (proc_self_ksm_stat_fd, buf,sizeof (buf) -1 ,0 ); +close (proc_self_ksm_stat_fd); +if (read_size <0 ) +return -errno; + + buf[read_size] =0 ; + + substr_ksm_zero =strstr (buf,"ksm_zero_pages" ); +if (!substr_ksm_zero) +return 0 ; + + value_pos =strcspn (substr_ksm_zero,"0123456789" ); +return strtol (substr_ksm_zero + value_pos,NULL ,10 ); +} + +long ksm_get_self_merging_pages (void ) +{ +int proc_self_ksm_merging_pages_fd; +char buf[10 ]; +ssize_t ret; + + proc_self_ksm_merging_pages_fd =open ("/proc/self/ksm_merging_pages" , +O_RDONLY ); +if (proc_self_ksm_merging_pages_fd <0 ) +return -errno; + + ret =pread (proc_self_ksm_merging_pages_fd, buf,sizeof (buf) -1 ,0 ); +close (proc_self_ksm_merging_pages_fd); +if (ret <=0 ) +return -errno; + buf[ret] =0 ; + +return strtol (buf,NULL ,10 ); +} + +long ksm_get_full_scans (void ) +{ +int ksm_full_scans_fd; +char buf[10 ]; +ssize_t ret; + + ksm_full_scans_fd =open ("/sys/kernel/mm/ksm/full_scans" ,O_RDONLY ); +if (ksm_full_scans_fd <0 ) +return -errno; + + ret =pread (ksm_full_scans_fd, buf,sizeof (buf) -1 ,0 ); +close (ksm_full_scans_fd); +if (ret <=0 ) +return -errno; + buf[ret] =0 ; + +return strtol (buf,NULL ,10 ); +} + +int ksm_use_zero_pages (void ) +{ +int ksm_use_zero_pages_fd; +ssize_t ret; + + ksm_use_zero_pages_fd =open ("/sys/kernel/mm/ksm/use_zero_pages" ,O_RDWR ); +if (ksm_use_zero_pages_fd <0 ) +return -errno; + + ret =write (ksm_use_zero_pages_fd,"1" ,1 ); +close (ksm_use_zero_pages_fd); +return ret ==1 ?0 : -errno; +} + +int ksm_start (void ) +{ +int ksm_fd; +ssize_t ret; +long start_scans, end_scans; + + ksm_fd =open ("/sys/kernel/mm/ksm/run" ,O_RDWR ); +if (ksm_fd <0 ) +return -errno; + +/* Wait for two full scans such that any possible merging happened. */ + start_scans =ksm_get_full_scans (); +if (start_scans <0 ) { +close (ksm_fd); +return start_scans; + } + ret =write (ksm_fd,"1" ,1 ); +close (ksm_fd); +if (ret !=1 ) +return -errno; +do { + end_scans =ksm_get_full_scans (); +if (end_scans <0 ) +return end_scans; + }while (end_scans < start_scans +2 ); + +return 0 ; +} + +int ksm_stop (void ) +{ +int ksm_fd; +ssize_t ret; + + ksm_fd =open ("/sys/kernel/mm/ksm/run" ,O_RDWR ); +if (ksm_fd <0 ) +return -errno; + + ret =write (ksm_fd,"2" ,1 ); +close (ksm_fd); +return ret ==1 ?0 : -errno; +}tools/testing/selftests/mm/vm_util.h +7
-0@@ -129,6 +129,13 @@ static inline void log_test_result(int result)void *sys_mremap (void *old_address,unsigned long old_size,unsigned long new_size,int flags,void *new_address); +long ksm_get_self_zero_pages (void ); +long ksm_get_self_merging_pages (void ); +long ksm_get_full_scans (void ); +int ksm_use_zero_pages (void ); +int ksm_start (void ); +int ksm_stop (void ); +/* * On ppc64 this will only work with radix 2M hugepage size */ Signature · 1 line
2.34.1
Signature · 2 lines
Wei Yang Help you, Help me
Andrew Morton
maintainerRe: [Patch v2 1/2] selftests/mm: put general ksm operation into vm_util
Quoted 1 line · On Fri, 15 Aug 2025 06:47:17 +0000 Wei Yang <[email protected]> wrote:
Ping...
Pong. https://lkml.kernel.org/r/20250728020930.w7sv5eccp4kcizts@master
indicates that we're awaiting v2?
Re: [Patch v2 1/2] selftests/mm: put general ksm operation into vm_util
Quoted 6 lines · Andrew Morton
Quoted 1 line · On Fri, 15 Aug 2025 06:47:17 +0000 Wei Yang <[email protected]> wrote:
Ping...
Pong. https://lkml.kernel.org/r/20250728020930.w7sv5eccp4kcizts@master
indicates that we're awaiting v2?
That is a trivial error handling issue. I just want to point it out ahead and wait for other comments.
In case this is misleading, I am sorry for that.
If a v3 is preferred, I will resend it.
Signature · 2 lines
Wei Yang Help you, Help me
Andrew Morton
maintainerRe: [Patch v2 1/2] selftests/mm: put general ksm operation into vm_util
Quoted 8 lines · On Sat, 16 Aug 2025 08:57:53 +0000 Wei Yang <[email protected]> wrote:
Quoted 6 lines · Andrew Morton
Quoted 1 line · On Fri, 15 Aug 2025 06:47:17 +0000 Wei Yang <[email protected]> wrote:
Ping...
Pong. https://lkml.kernel.org/r/20250728020930.w7sv5eccp4kcizts@master
indicates that we're awaiting v2?
Quoted 6 lines
That is a trivial error handling issue. I just want to point it out ahead and wait for other comments.
In case this is misleading, I am sorry for that.
If a v3 is preferred, I will resend it.
Now is a good time to fix and resend, please.
And it's a few weeks old, so perhaps a redo will attract some reviews this time.
Re: [Patch v2 1/2] selftests/mm: put general ksm operation into vm_util
Quoted 13 lines · Andrew Morton
Quoted 11 lines · On Sat, 16 Aug 2025 08:57:53 +0000 Wei Yang <[email protected]> wrote:
Quoted 6 lines · Andrew Morton
Quoted 1 line · On Fri, 15 Aug 2025 06:47:17 +0000 Wei Yang <[email protected]> wrote:
Ping...
Pong. https://lkml.kernel.org/r/20250728020930.w7sv5eccp4kcizts@master
indicates that we're awaiting v2?That is a trivial error handling issue. I just want to point it out ahead and wait for other comments.
Quoted 8 lines
Quoted 3 lines
In case this is misleading, I am sorry for that.
If a v3 is preferred, I will resend it.
Now is a good time to fix and resend, please.
And it's a few weeks old, so perhaps a redo will attract some reviews this time.
Sure, will do it.
Signature · 2 lines
Wei Yang Help you, Help me
PATCH v2 2/2 selftests/mm: assert rmap behave as expected
In reply to Wei YangAs David suggested, currently we don't have a high level test case to verify the behavior of rmap. This patch introduce the verification on rmap by migration.
The general idea is if migrate one shared page between processes, this would be reflected in all related processes. Otherwise, we have problem in rmap.
Currently it covers following four scenarios:
* anonymous page
* shmem page
* pagecache page
* ksm page
---
v2:
* skip instead of assert if numa not available
* check ksm sys file before continue
* use private anonymous map instead of shared map
* check pfn instead of content
* retry migrate
* fault in region for each process by FORCE_READ()
* behave -> behaves
v1: fault in region by just accessing it instead of print it
--- MAINTAINERS | 1 + tools/testing/selftests/mm/.gitignore | 1 + tools/testing/selftests/mm/Makefile | 3 + tools/testing/selftests/mm/rmap.c | 432 ++++++++++++++++++++++ tools/testing/selftests/mm/run_vmtests.sh | 4 + 5 files changed, 441 insertions(+) create mode 100644 tools/testing/selftests/mm/rmap.c
MAINTAINERS +1 -0
@@ -15970,6 +15970,7 @@ S: Maintained F: include/linux/rmap.h F: mm/page_vma_mapped.c F: mm/rmap.c +F: tools/testing/selftests/mm/rmap.c MEMORY MANAGEMENT - SECRETMEM M: Andrew Morton <[email protected]>
tools/testing/selftests/mm/.gitignore +1 -0
@@ -58,3 +58,4 @@ pkey_sighandler_tests_32 pkey_sighandler_tests_64 guard-regions merge +rmap
tools/testing/selftests/mm/Makefile +3 -0
@@ -101,6 +101,7 @@ TEST_GEN_FILES += hugetlb_dio TEST_GEN_FILES += droppable TEST_GEN_FILES += guard-regions TEST_GEN_FILES += merge +TEST_GEN_FILES += rmap ifneq ($(ARCH),arm64) TEST_GEN_FILES += soft-dirty
@@ -228,6 +229,8 @@ $(OUTPUT)/ksm_tests: LDLIBS += -lnuma $(OUTPUT)/migration: LDLIBS += -lnuma +$(OUTPUT)/rmap: LDLIBS += -lnuma + local_config.mk local_config.h: check_config.sh /bin/sh ./check_config.sh $(CC)
tools/testing/selftests/mm/rmap.c new file +432 -0
432 lines not on this page · raw message
tools/testing/selftests/mm/run_vmtests.sh +4 -0
@@ -85,6 +85,8 @@ separated by spaces: test handling of page fragment allocation and freeing - vma_merge test VMA merge cases behave as expected +- rmap + test rmap behaves as expected example: ./run_vmtests.sh -t "hmm mmap ksm" EOF
@@ -532,6 +534,8 @@ CATEGORY="page_frag" run_test ./test_page_frag.sh aligned CATEGORY="page_frag" run_test ./test_page_frag.sh nonaligned +CATEGORY="rmap" run_test ./rmap + echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}" | tap_prefix echo "1..${count_total}" | tap_output
Signature · 1 line
2.34.1
Re: [Patch v2 2/2] selftests/mm: assert rmap behave as expected
On Sat, Jul 26, 2025 at 02:52:23AM +0000, Wei Yang wrote:
[...]
tools/testing/selftests/mm/rmap.c line 397
Quoted 10 lines
tools/testing/selftests/mm/rmap.c new file +10
-0+ +int merge_and_migrate (struct global_data *data) +{ +int pagemap_fd; +int ret =0 ; + +if (data->region ==MAP_FAILED ) +return FAIL_ON_WORK ; + +ksm_start ();
Forget to check the return value here.
Will update it.
Quoted 11 lines
tools/testing/selftests/mm/rmap.c new file +11
-0+ + ret =try_to_move_page (data->region); + + pagemap_fd =open ("/proc/self/pagemap" ,O_RDONLY ); +if (pagemap_fd ==-1 ) +return FAIL_ON_WORK ; + *data->expected_pfn =pagemap_get_pfn (pagemap_fd, data->region); + +return ret; +} +
Signature · 2 lines
Wei Yang Help you, Help me